Changeset 703 for GPL/trunk/alsa-kernel/pci/atiixp.c

Timestamp:

Sep 26, 2021, 6:18:40 PM (4 years ago)

Author:

David Azarewicz

Message:

Merge changes from next branch.

Location:

GPL/trunk

Files:

• . (modified) (1 prop)
• alsa-kernel/pci/atiixp.c (modified) (8 diffs)

GPL/trunk/alsa-kernel/pci/atiixp.c

@@ -1050 +1050 @@
                 runtime->hw.formats = SNDRV_PCM_FMTBIT_IEC958_SUBFRAME_LE;
         }
-        if ((err = snd_pcm_hw_constraint_integer(runtime, SNDRV_PCM_HW_PARAM_PERIODS)) < 0)
+        err = snd_pcm_hw_constraint_integer(runtime, SNDRV_PCM_HW_PARAM_PERIODS);
+        if (err < 0)
                 return err;
         runtime->private_data = dma;
@@ -1426 +1427 @@
                 return -ENXIO;
 
-        if ((err = snd_ac97_bus(chip->card, 0, &ops, chip, &pbus)) < 0)
+        err = snd_ac97_bus(chip->card, 0, &ops, chip, &pbus);
+        if (err < 0)
                 return err;
         pbus->clock = clock;
@@ -1442 +1444 @@
                 if (! chip->spdif_over_aclink)
                         ac97.scaps |= AC97_SCAP_NO_SPDIF;
-                if ((err = snd_ac97_mixer(pbus, &ac97, &chip->ac97[i])) < 0) {
+                err = snd_ac97_mixer(pbus, &ac97, &chip->ac97[i]);
+                if (err < 0) {
                         chip->ac97[i] = NULL; /* to be sure */
                         dev_dbg(chip->card->dev,
@@ -1573 +1576 @@
         int err;
 
-        if ((err = pci_enable_device(pci)) < 0)
+        err = pci_enable_device(pci);
+        if (err < 0)
                 return err;
 
@@ -1587 +1591 @@
         chip->pci = pci;
         chip->irq = -1;
-        if ((err = pci_request_regions(pci, "ATI IXP AC97")) < 0) {
+        err = pci_request_regions(pci, "ATI IXP AC97");
+        if (err < 0) {
                 pci_disable_device(pci);
                 kfree(chip);
@@ -1610 +1615 @@
         pci_set_master(pci);
 
-        if ((err = snd_device_new(card, SNDRV_DEV_LOWLEVEL, chip, &ops)) < 0) {
+        err = snd_device_new(card, SNDRV_DEV_LOWLEVEL, chip, &ops);
+        if (err < 0) {
                 snd_atiixp_free(chip);
                 return err;
@@ -1633 +1639 @@
         strcpy(card->driver, spdif_aclink ? "ATIIXP" : "ATIIXP-SPDMA");
         strcpy(card->shortname, "ATI IXP");
-        if ((err = snd_atiixp_create(card, pci, &chip)) < 0)
+        err = snd_atiixp_create(card, pci, &chip);
+        if (err < 0)
                 goto __error;
         card->private_data = chip;
 
-        if ((err = snd_atiixp_aclink_reset(chip)) < 0)
+        err = snd_atiixp_aclink_reset(chip);
+        if (err < 0)
                 goto __error;
 
         chip->spdif_over_aclink = spdif_aclink;
 
-        if ((err = snd_atiixp_mixer_new(chip, ac97_clock, ac97_quirk)) < 0)
+        err = snd_atiixp_mixer_new(chip, ac97_clock, ac97_quirk);
+        if (err < 0)
                 goto __error;
 
-        if ((err = snd_atiixp_pcm_new(chip)) < 0)
+        err = snd_atiixp_pcm_new(chip);
+        if (err < 0)
                 goto __error;
         
@@ -1662 +1672 @@
                  chip->addr, chip->irq);
 
-        if ((err = snd_card_register(card)) < 0)
+        err = snd_card_register(card);
+        if (err < 0)
                 goto __error;