Anthony Lam (:antlam) Find me, @antlam on Slack! Reporter
	Description • 10 years ago

With all this work that we're doing around Passwords management, we should expose a "Passwords" item in the menu to access about:passwords easier.

Option 1: 
 - 3-dot menu -> Settings -> Privacy -> Manage passwords -> Opens "about:passwords"

Option 2:
 - 3-dot menu -> Tools -> Passwords -> Opens "about:passwords"

	Mark Finkle (:mfinkle) (use needinfo?)
	Comment 1 • 10 years ago

(In reply to Anthony Lam (:antlam) from comment #0)
> With all this work that we're doing around Passwords management, we should
> expose a "Passwords" item in the menu to access about:passwords easier.
> 
> Option 1: 
>  - 3-dot menu -> Settings -> Privacy -> Manage passwords -> Opens
> "about:passwords"
> 
> Option 2:
>  - 3-dot menu -> Tools -> Passwords -> Opens "about:passwords"

On first blush, I would go with the Tools menu approach, but then I remembered that Robin had ideas to reduce the menu size a bit and use other entry points. I think having a Settings > Privacy entry point makes some sense, and eases our Menu load.

Ryan is working on other "fast acccess to passwords" approaches too, for those situations where we want to make it as easy as possible. It's a different use case than just wanting to get to the Password Manager. For that case, I think we should try the Settings approach first. Maybe we'll find ways to migrate some lesser used menus to Settings. We have talked about doing that for Add-ons in the past.

	Richard Newman [:rnewman]
	Comment 2 • 10 years ago

Might I suggest a long-press handler in a password field as another "expectable" entry point?

Perhaps "Passwords for this site…"?

	:Margaret Leibovic
	Comment 3 • 10 years ago

These "fast access" entry points are good ideas, but I still think that we should have a canonical way to get to your password manager, such as an item buried in settings.

To be consistent with our similar about: pages (add-ons, downloads), I would vote for an item in the Tools menu. If we don't like the Tools menu as a spot for things like this, we should revive that menu reorganization bug.

	Mark Finkle (:mfinkle) (use needinfo?)
	Comment 4 • 10 years ago

(In reply to :Margaret Leibovic from comment #3)

> To be consistent with our similar about: pages (add-ons, downloads), I would
> vote for an item in the Tools menu. If we don't like the Tools menu as a
> spot for things like this, we should revive that menu reorganization bug.

I would like to use this bug to revive the Menu re-org a bit. Maybe not do the entire re-org, but we could start with moving some items, like Tools > Add-ons and (yet to be added) Passwords to the Setting system.

Menu Reorg - Settings is bug 1073294
Menu Reorg is bug 1069035

	Richard Newman [:rnewman]
	Comment 5 • 10 years ago

Bear in mind that the following activity stack is not possible:

  BrowserApp > GeckoPreferences > BrowserApp

so there might be some gymnastics here if password management is a content page that's accessed via settings, particularly if you want to be able to hit Back in about:passwords and go back to the settings UI.

	Mark Finkle (:mfinkle) (use needinfo?)
	Comment 6 • 10 years ago

Right. This is already the case for Settings > Mozilla > About Firefox

	Anthony Lam (:antlam) Find me, @antlam on Slack! Reporter
	Comment 7 • 10 years ago

(In reply to Anthony Lam (:antlam) from comment #0)
> Option 2:
>  - 3-dot menu -> Tools -> Passwords -> Opens "about:passwords"

This looks like the best choice right now. As Mark pointed out, we could surface some of the settings under Settings as well. But we still need a "Passwords" item in Tools.

	Robin Andersen [:tecgirl]
	Comment 8 • 10 years ago

I'm all for surfacing as much as possible but not so sure users would know to look in "Tools" for Password Management. I would press for Option 1.

	Chenxia Liu [:liuche] Assignee
	Comment 9 • 10 years ago

/r/4283 - Bug 1121681 - Add "Passwords" entry point in menu. r=mhaigh

Pull down this commit:

hg pull review -r 50f5c97e537141de3d5e369d35684ffa2cfc251e

	Chenxia Liu [:liuche] Assignee
	Comment 10 • 10 years ago

Added entry points in both the "Tools" menu and in the "Settings > Privacy" preferences. Also added nightly flags for new code + tests because about:passwords is behind the Nightly flag.

	Chenxia Liu [:liuche] Assignee
	Comment 12 • 10 years ago

Also considering putting a category separator because we now have 3 passwords preference items.

	Chenxia Liu [:liuche] Assignee
	Comment 13 • 10 years ago

Comment on attachment 8568876 [details]
MozReview Request: bz://1121681/liuche

/r/4283 - Bug 1121681 - Add "Passwords" entry point in menu. r=mhaigh
/r/4289 - Passwords category.

Pull down these commits:

hg pull review -r eb1b74f093833f79283819e4edbe894d97d05eeb

	Chenxia Liu [:liuche] Assignee
	Comment 14 • 10 years ago

Comment on attachment 8568876 [details]
MozReview Request: bz://1121681/liuche

/r/4283 - Bug 1121681 - Add "Passwords" entry point in menu. r=margaret
/r/4289 - Passwords category.

Pull down these commits:

hg pull review -r d33a297c73f80afc5cee0e472c193fc437a67794

	Anthony Lam (:antlam) Find me, @antlam on Slack! Reporter
	Comment 15 • 10 years ago

Comment on attachment 8568888 [details]
Screenshot: Category

Yeah this is probably where I would put it. + for that!

Two things though :)
 - could we change this ordering so that "Manage" is first under "LOGINS"?
 - We should probably say "Manage Logins" rather than "Manage passwords"

	Anthony Lam (:antlam) Find me, @antlam on Slack! Reporter
	Comment 16 • 10 years ago

Likewise it should probably be Tools > Logins rather than Tools > Passwords I think

	:Margaret Leibovic
	Comment 17 • 10 years ago

https://reviewboard.mozilla.org/r/4283/#review3525

r+ if you update the strings to be what antlam wants :)

::: mobile/android/base/resources/menu-xlarge-v11/browser_app_menu.xml
(Diff revision 2)
> +            <item android:id="@+id/passwords"

Ugh, we have 4 versions of this file.

::: mobile/android/base/tests/testSettingsMenuItems.java
(Diff revision 2)
> +    final String[] MANAGE_PASSWORDS_ARR = { StringHelper.MANAGE_PASSWORDS_LABEL };

Good job remembering to update the tests.

	:Margaret Leibovic
	Comment 18 • 10 years ago

https://reviewboard.mozilla.org/r/4289/#review3527

Ship It!

	:Margaret Leibovic
	Comment 19 • 10 years ago

Comment on attachment 8568876 [details]
MozReview Request: bz://1121681/liuche

https://reviewboard.mozilla.org/r/4281/#review3529

Ship It!

	Chenxia Liu [:liuche] Assignee
	Comment 20 • 10 years ago

https://hg.mozilla.org/integration/fx-team/rev/14486598bf2d
https://hg.mozilla.org/integration/fx-team/rev/b726620f6dc2

	Carsten Book [:Tomcat]
	Comment 21 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/14486598bf2d
https://hg.mozilla.org/mozilla-central/rev/b726620f6dc2

	Teodora Vermesan (:TeoVermesan)
	Comment 22 • 10 years ago

Tested with:
Device: Nexus 4 (Android 4.4)
Build: Firefox for Android 39.0a1 (2015-03-04)
Tapping the three-dot-menu -> Settings -> Privacy -> Manage logins will open "about:passwords"
Also a category separator "Logins" is displayed  containing  the following 3 passwords preferences: "Manage logins", "Remember passwords", "Use master password".
Tapping the three-dot-menu -> Tools -> Logins will also open "about:passwords"