-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transcoded version of api sample oit_depth_peeling based on Vulkan-Hpp #1038
Transcoded version of api sample oit_depth_peeling based on Vulkan-Hpp #1038
Conversation
ad6c29d
to
3d48c2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only took a look the documentation side of things, will test the sample itself later.
Aside from the image link, can you also add the translated sample to the navigation in nav.adoc
?
6c76ed7
to
da2ecc2
Compare
Am I wrong in thinking that the "I did a full batch run using the batch command line argument" checkbox was added to ensure that the author of any change that touches the framework ran a batch test themselves before pushing a change for review? I realize that this only has a small change to the framework, but surely just leaving the checkbox unchecked wasn't the intention when it was added. |
Exactly. That's what the checkbox is meant for (we discussed this during the last call). But the PR (#1025) that added this was merged prematurely and I have no way of reverting that. Right now batch mode will probably crash at some point as some samples still need to be fixed or until #1036 is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a few minor documentation related comments.
Sample itself works fine for me, though I noticed some coloring differences between this and the non-hpp version. Nothing dramatic though.
9f3da97
to
3f7a98a
Compare
3f7a98a
to
18eb893
Compare
Description
Introduces a new Vulkan-Hpp-based sample, which is a transcoded version of the oit_depth_peeling api sample.
Build tested on Win10 with VS2022. Run tested on Win10 with NVidia GPU.
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batch
command line argument to make sure all samples still work properlySample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: