-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small batch mode fixes #1036
Small batch mode fixes #1036
Conversation
samples/performance/command_buffer_usage/command_buffer_usage.cpp
Outdated
Show resolved
Hide resolved
Aside from gary's comment this looks fine. This will be very useful for maintainers, esp. being able to have the batch run continue when inactive. That way I can finally run it on my second screen while doing other stuff 👍🏻 |
@tomadamatkinson: Are you able to fix what Gary noted? Getting those fixes merged would make future PRs a lot easier. If you can't find the time for that, I'm happy to jump in :) |
6e46f7f
33ae90a
to
6e46f7f
Compare
@SaschaWillems @gary-sweet this should be resolved now! |
Awesome. Thank you very much :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@gary-sweet thats a weird one... Just to check, you've pulled the up to date version of the branch. I did rebase on main. Do you see this behaviour with any other sliders? The slider I changed is now inline with the other slider usage |
Yes
Well, if I run command_buffer_usage on main, I just get: All the other sliders appear to have the label to the right of them (which I think is how they're supposed to be looking at the screenshots from those samples). |
Interesting, I'll take another look! |
Changing the slider code in command_buffer_usage.cpp to:
solves the problem for me. The |
fix %d fix label fix
2d9c540
to
c5188ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thanks.
Description
A series of small batch mode fixes that i found when running batch mode. This does not fix validation errors but does fix segfaults / assertions.
Added
force_render
which allows batch mode to override theupdate if focused
functionality so that you can multi task whilst running batch mode in the background.Tested on Linux. Samples may still have existing issues on other platforms
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batch
command line argument to make sure all samples still work properly