Changeset 53 for trunk/src/helpers/gpih.c

Timestamp:

Apr 2, 2001, 12:38:55 PM (24 years ago)

Author:

umoeller

Message:

Dialog mgr.

File:

• trunk/src/helpers/gpih.c (modified) (10 diffs)

trunk/src/helpers/gpih.c

@@ -33 +33 @@
     // as unsigned char
 
+#define INCL_DOSSEMAPHORES
 #define INCL_DOSERRORS
 
 #define INCL_WINWINDOWMGR
+#define INCL_WINMESSAGEMGR
 #define INCL_WINPOINTERS
 #define INCL_WINSYS
@@ -92 +94 @@
  *      By contrast, the GpiBox expects an inclusive-inclusive rectangle.
  */
+
+/* ******************************************************************
+ *
+ *   Global variables
+ *
+ ********************************************************************/
+
+static HMTX     G_hmtxLCIDs = NULLHANDLE;
 
 /* ******************************************************************
@@ -492 +502 @@
 
 /*
+ *@@ gpihLockLCIDs:
+ *      requests the mutex for serializing the
+ *      lcids.
+ *
+ *      With GPI, lcids are a process-wide resource and not
+ *      guaranteed to be unique. In the worst case, while your
+ *      font routines are running, another thread modifies the
+ *      lcids and you get garbage. If your fonts suddenly
+ *      turn to "System Proportional", you know this has
+ *      happened.
+ *
+ *      As a result, whenever you work on lcids, request this
+ *      mutex during your processing. If you do this consistently
+ *      across all your code, you should be safe.
+ *
+ *      gpihFindFont uses this mutex. If you call GpiCreateLogFont
+ *      yourself somewhere, do this after you called this function.
+ *
+ *      Call gpihUnlockLCIDs to unlock.
+ *
+ *@@added V0.9.9 (2001-04-01) [umoeller]
+ */
+
+BOOL gpihLockLCIDs(VOID)
+{
+    BOOL brc = FALSE;
+
+    if (G_hmtxLCIDs == NULLHANDLE)
+        // first call: create
+        brc = !DosCreateMutexSem(NULL,
+                                 &G_hmtxLCIDs,
+                                 0,
+                                 TRUE);     // request!
+    else
+        // subsequent calls: request
+        brc = !WinRequestMutexSem(G_hmtxLCIDs, SEM_INDEFINITE_WAIT);
+
+    return (brc);
+}
+
+/*
+ *@@ UnlockLCIDs:
+ *      releases the mutex for serializing the
+ *      lcids.
+ *
+ *@@added V0.9.9 (2001-04-01) [umoeller]
+ */
+
+VOID gpihUnlockLCIDs(VOID)
+{
+    DosReleaseMutexSem(G_hmtxLCIDs);
+}
+
+/*
  *@@ gpihQueryNextLCID:
  *      returns the next available lcid for the given HPS.
@@ -498 +562 @@
  *      Gets called by gpihFindFont automatically.
  *
- *      This is possibly the sickest code I've ever written.
- *
- *      Warning: This function is _not_ thread-safe.
- *      We use GpiQueryNumberSetIds to find out the no. of
- *      LCID's in use by the process. In the worst case,
- *      between that call and the call to GpiCreateLogFont,
- *      another font has been created, and you'll get garbage.
+ *      WARNING: This function by itself is not thread-safe.
+ *      See gpihLockLCIDs for how to serialize this.
  *
  *@@added V0.9.3 (2000-05-06) [umoeller]
+ *@@changed V0.9.9 (2001-04-01) [umoeller]: removed all those sick sub-allocs
  */
 
@@ -524 +584 @@
     else
     {
-        #define GQNCL_BLOCK_SIZE 400*sizeof(LONG)
+        // #define GQNCL_BLOCK_SIZE 400*sizeof(LONG)
+
+        PLONG  alTypes = NULL;  // object types
+        PSTR8  aNames = NULL;   // font names
+        PLONG  allcids = NULL;  // local identifiers
+
+        if (    (alTypes = (PLONG)malloc(lCount * sizeof(LONG)))
+             && (aNames = (PSTR8)malloc(lCount * sizeof(STR8)))
+             && (allcids = (PLONG)malloc(lCount * sizeof(LONG)))
+           )
+        {
+            if (GpiQuerySetIds(hps,
+                               lCount,
+                               alTypes,
+                               aNames,
+                               allcids))
+            {
+                // FINALLY we have all the lcids in use.
+                BOOL    fContinue = TRUE;
+                lcidNext = 1;
+
+                // now, check if this lcid is in use already:
+                while (fContinue)
+                {
+                    BOOL fFound = FALSE;
+                    ULONG ul;
+                    fContinue = FALSE;
+                    for (ul = 0;
+                         ul < lCount;
+                         ul++)
+                    {
+                        if (allcids[ul] == lcidNext)
+                        {
+                            fFound = TRUE;
+                            break;
+                        }
+                    }
+
+                    if (fFound)
+                    {
+                        // lcid found:
+                        // try next higher one
+                        lcidNext++;
+                        fContinue = TRUE;
+                    }
+                    // else: return that one
+                }
+            }
+        }
+
+        if (alTypes)
+            free(alTypes);
+        if (aNames)
+            free(aNames);
+        if (allcids)
+            free(allcids);
+
+/*
         PLONG   pBase;
-
         APIRET  arc;
 
@@ -612 +728 @@
             arc = DosFreeMem(pBase);
         }
+        */
     }
 
@@ -744 +861 @@
  *          certain point sizes only.
  *
- *      4)  <B>Warning: This function is _not_ thread-safe.</B>
- *          Since logical font IDs are shared across the
- *          process, this function should _not_ be called
- *          from several threads at the same time.
+ *      4)  Since logical font IDs are shared across the
+ *          process, a mutex is requested while the lcids are
+ *          being queried and/or manipulated. In other words,
+ *          this func is now thread-safe (V0.9.9).
  *
  *          This calls gpihQueryNextFontID in turn to find the
  *          next free lcid. See remarks there.
- *          If your fonts suddenly change to "System Proportional"
- *          in your application, you probably have a serialization
- *          problem.
- *
- *          To make this thread-safe, create your own wrapper
- *          function which calls this function while a mutex
- *          semaphore is held by the wrapper. Then use only
- *          the wrapper in your code.
  *
  *      <B>Font metrics:</B>
@@ -793 +902 @@
  *@@changed V0.9.3 (2000-05-06) [umoeller]: usFormat didn't work; fixed
  *@@changed V0.9.4 (2000-08-08) [umoeller]: added fFamily
+ *@@changed V0.9.9 (2001-04-01) [umoeller]: made this thread-safe, finally
  */
 
@@ -981 +1091 @@
     free(pfm);
 
-    // new logical font ID: last used plus one
-    lLCIDReturn = gpihQueryNextFontID(hps);
-
-    GpiCreateLogFont(hps,
-                     NULL,  // don't create "logical font name" (STR8)
-                     lLCIDReturn,
-                     &FontAttrs);
+    if (gpihLockLCIDs())        // V0.9.9 (2001-04-01) [umoeller]
+    {
+        // new logical font ID: last used plus one
+        lLCIDReturn = gpihQueryNextFontID(hps);
+
+        GpiCreateLogFont(hps,
+                         NULL,  // don't create "logical font name" (STR8)
+                         lLCIDReturn,
+                         &FontAttrs);
+
+        gpihUnlockLCIDs();
+    }
 
     return (lLCIDReturn);
@@ -1025 +1140 @@
  *
  *@@added V0.9.0 [umoeller]
- */
-
-LONG gpihFindPresFont(HWND hwnd,          // in: window to search for presparam
+ *@@changed V0.9.9 (2001-04-01) [umoeller]: now supporting NULLHANDLE hwnd
+ */
+
+LONG gpihFindPresFont(HWND hwnd,          // in: window to search for presparam or NULLHANDLE
                       BOOL fInherit,      // in: search parent windows too?
                       HPS hps,            // in: HPS for font selection
-                      PSZ pszDefaultFont, // in: default font if not found (i.e. "8.Helv")
+                      const char *pcszDefaultFont, // in: default font if not found (i.e. "8.Helv")
                       PFONTMETRICS pFontMetrics, // out: font metrics of created font (optional)
                       PLONG plSize)       // out: presparam's point size (optional)
 {
     CHAR    szPPFont[200] = "";
-    PSZ     pszFontFound = 0;
+    const char *pcszFontFound = 0;
     CHAR    szFaceName[300] = "";
     ULONG   ulFontSize = 0;
 
-    if (WinQueryPresParam(hwnd,
-                          PP_FONTNAMESIZE,          // first PP to query
-                          0,                        // second PP to query
-                          NULL,                     // out: which one is returned
-                          (ULONG)sizeof(szPPFont),  // in: buffer size
-                          (PVOID)&szPPFont,         // out: PP value returned
-                          (fInherit)
-                               ? 0
-                               : QPF_NOINHERIT))
+    if (    (hwnd)        // V0.9.9 (2001-04-01) [umoeller]
+         && (WinQueryPresParam(hwnd,
+                               PP_FONTNAMESIZE,          // first PP to query
+                               0,                        // second PP to query
+                               NULL,                     // out: which one is returned
+                               (ULONG)sizeof(szPPFont),  // in: buffer size
+                               (PVOID)&szPPFont,         // out: PP value returned
+                               (fInherit)
+                                    ? 0
+                                    : QPF_NOINHERIT))
+       )
         // PP found:
-        pszFontFound = szPPFont;
+        pcszFontFound = szPPFont;
     else
-        pszFontFound = pszDefaultFont;
-
-    if (pszFontFound)
+        pcszFontFound = pcszDefaultFont;
+
+    if (pcszFontFound)
     {
-        PCHAR   pcDot = strchr(pszFontFound, '.');
+        const char *pcDot = strchr(pcszFontFound, '.');
         if (pcDot)
         {
             // _Pmpf(("Found font PP: %s", pszFontFound));
-            sscanf(pszFontFound, "%lu", &ulFontSize);
+            sscanf(pcszFontFound, "%lu", &ulFontSize);
             if (plSize)
                 *plSize = ulFontSize;