Changeset 679 for GPL/trunk/alsa-kernel/isa/gus/gusextreme.c

Timestamp:

Mar 18, 2021, 8:57:36 PM (4 years ago)

Author:

David Azarewicz

Message:

Merge changes from Paul's uniaud32next branch.

Location:

GPL/trunk

Files:

• . (modified) (1 prop)
• alsa-kernel/isa/gus/gusextreme.c (modified) (17 diffs)

GPL/trunk/alsa-kernel/isa/gus/gusextreme.c

@@ +1 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *  Driver for Gravis UltraSound Extreme soundcards
  *  Copyright (c) by Jaroslav Kysela <perex@perex.cz>
- *
- *
- *   This program is free software; you can redistribute it and/or modify
- *   it under the terms of the GNU General Public License as published by
- *   the Free Software Foundation; either version 2 of the License, or
- *   (at your option) any later version.
- *
- *   This program is distributed in the hope that it will be useful,
- *   but WITHOUT ANY WARRANTY; without even the implied warranty of
- *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *   GNU General Public License for more details.
- *
- *   You should have received a copy of the GNU General Public License
- *   along with this program; if not, write to the Free Software
- *   Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA
- *
  */
 
@@ -25 +10 @@
 #include <linux/delay.h>
 #include <linux/time.h>
-#include <linux/moduleparam.h>
+#include <linux/module.h>
 #include <asm/dma.h>
 #include <sound/core.h>
@@ -47 +32 @@
 static int index[SNDRV_CARDS] = SNDRV_DEFAULT_IDX;      /* Index 0-MAX */
 static char *id[SNDRV_CARDS] = SNDRV_DEFAULT_STR;       /* ID for this card */
-static int enable[SNDRV_CARDS] = SNDRV_DEFAULT_ENABLE;  /* Enable this card */
+static bool enable[SNDRV_CARDS] = SNDRV_DEFAULT_ENABLE; /* Enable this card */
 static long port[SNDRV_CARDS] = SNDRV_DEFAULT_PORT;     /* 0x220,0x240,0x260 */
 static long gf1_port[SNDRV_CARDS] = {[0 ... (SNDRV_CARDS) - 1] = -1}; /* 0x210,0x220,0x230,0x240,0x250,0x260,0x270 */
@@ -67 +52 @@
 module_param_array(enable, bool, NULL, 0444);
 MODULE_PARM_DESC(enable, "Enable " CRD_NAME " soundcard.");
-module_param_array(port, long, NULL, 0444);
+module_param_hw_array(port, long, ioport, NULL, 0444);
 MODULE_PARM_DESC(port, "Port # for " CRD_NAME " driver.");
-module_param_array(gf1_port, long, NULL, 0444);
+module_param_hw_array(gf1_port, long, ioport, NULL, 0444);
 MODULE_PARM_DESC(gf1_port, "GF1 port # for " CRD_NAME " driver (optional).");
-module_param_array(mpu_port, long, NULL, 0444);
+module_param_hw_array(mpu_port, long, ioport, NULL, 0444);
 MODULE_PARM_DESC(mpu_port, "MPU-401 port # for " CRD_NAME " driver.");
-module_param_array(irq, int, NULL, 0444);
+module_param_hw_array(irq, int, irq, NULL, 0444);
 MODULE_PARM_DESC(irq, "IRQ # for " CRD_NAME " driver.");
-module_param_array(mpu_irq, int, NULL, 0444);
+module_param_hw_array(mpu_irq, int, irq, NULL, 0444);
 MODULE_PARM_DESC(mpu_irq, "MPU-401 IRQ # for " CRD_NAME " driver.");
-module_param_array(gf1_irq, int, NULL, 0444);
+module_param_hw_array(gf1_irq, int, irq, NULL, 0444);
 MODULE_PARM_DESC(gf1_irq, "GF1 IRQ # for " CRD_NAME " driver.");
-module_param_array(dma8, int, NULL, 0444);
+module_param_hw_array(dma8, int, dma, NULL, 0444);
 MODULE_PARM_DESC(dma8, "8-bit DMA # for " CRD_NAME " driver.");
-module_param_array(dma1, int, NULL, 0444);
+module_param_hw_array(dma1, int, dma, NULL, 0444);
 MODULE_PARM_DESC(dma1, "GF1 DMA # for " CRD_NAME " driver.");
 module_param_array(joystick_dac, int, NULL, 0444);
@@ -90 +75 @@
 MODULE_PARM_DESC(pcm_channels, "Reserved PCM channels for " CRD_NAME " driver.");
 
-static int __devinit snd_gusextreme_match(struct device *dev, unsigned int n)
+static int snd_gusextreme_match(struct device *dev, unsigned int n)
 {
         return enable[n];
 }
 
-static int __devinit snd_gusextreme_es1688_create(struct snd_card *card,
-                struct snd_es1688 *chip, struct device *dev, unsigned int n)
-{
-        static long possible_ports[] = {0x220, 0x240, 0x260};
-        static int possible_irqs[] = {5, 9, 10, 7, -1};
-        static int possible_dmas[] = {1, 3, 0, -1};
+static int snd_gusextreme_es1688_create(struct snd_card *card,
+                                        struct snd_es1688 *chip,
+                                        struct device *dev, unsigned int n)
+{
+        static const long possible_ports[] = {0x220, 0x240, 0x260};
+        static const int possible_irqs[] = {5, 9, 10, 7, -1};
+        static const int possible_dmas[] = {1, 3, 0, -1};
 
         int i, error;
@@ -133 +119 @@
 }
 
-static int __devinit snd_gusextreme_gus_card_create(struct snd_card *card,
-                struct device *dev, unsigned int n, struct snd_gus_card **rgus)
-{
-        static int possible_irqs[] = {11, 12, 15, 9, 5, 7, 3, -1};
-        static int possible_dmas[] = {5, 6, 7, 3, 1, -1};
+static int snd_gusextreme_gus_card_create(struct snd_card *card,
+                                          struct device *dev, unsigned int n,
+                                          struct snd_gus_card **rgus)
+{
+        static const int possible_irqs[] = {11, 12, 15, 9, 5, 7, 3, -1};
+        static const int possible_dmas[] = {5, 6, 7, 3, 1, -1};
 
         if (gf1_irq[n] == SNDRV_AUTO_IRQ) {
@@ -157 +144 @@
 }
 
-static int __devinit snd_gusextreme_detect(struct snd_gus_card *gus,
-        struct snd_es1688 *es1688)
+static int snd_gusextreme_detect(struct snd_gus_card *gus,
+                                 struct snd_es1688 *es1688)
 {
         unsigned long flags;
@@ -207 +194 @@
 }
 
-static int __devinit snd_gusextreme_mixer(struct snd_card *card)
+static int snd_gusextreme_mixer(struct snd_card *card)
 {
         struct snd_ctl_elem_id id1, id2;
@@ -233 +220 @@
 }
 
-static int __devinit snd_gusextreme_probe(struct device *dev, unsigned int n)
+static int snd_gusextreme_probe(struct device *dev, unsigned int n)
 {
         struct snd_card *card;
@@ -241 +228 @@
         int error;
 
-        error = snd_card_create(index[n], id[n], THIS_MODULE,
-                                sizeof(struct snd_es1688), &card);
+        error = snd_card_new(dev, index[n], id[n], THIS_MODULE,
+                             sizeof(struct snd_es1688), &card);
         if (error < 0)
                 return error;
@@ -283 +270 @@
         gus->codec_flag = 1;
 
-        error = snd_es1688_pcm(card, es1688, 0, NULL);
+        error = snd_es1688_pcm(card, es1688, 0);
         if (error < 0)
                 goto out;
@@ -294 +281 @@
 
         if (pcm_channels[n] > 0) {
-                error = snd_gf1_pcm_new(gus, 1, 1, NULL);
+                error = snd_gf1_pcm_new(gus, 1, 1);
                 if (error < 0)
                         goto out;
@@ -318 +305 @@
         if (es1688->mpu_port >= 0x300) {
                 error = snd_mpu401_uart_new(card, 0, MPU401_HW_ES1688,
-                                es1688->mpu_port, 0,
-                                mpu_irq[n], IRQF_DISABLED, NULL);
+                                es1688->mpu_port, 0, mpu_irq[n], NULL);
                 if (error < 0)
                         goto out;
@@ -328 +314 @@
                 gus->gf1.irq, es1688->irq, gus->gf1.dma1, es1688->dma8);
 
-        snd_card_set_dev(card, dev);
-
         error = snd_card_register(card);
         if (error < 0)
@@ -341 +325 @@
 }
 
-static int __devexit snd_gusextreme_remove(struct device *dev, unsigned int n)
+static int snd_gusextreme_remove(struct device *dev, unsigned int n)
 {
         snd_card_free(dev_get_drvdata(dev));
-        dev_set_drvdata(dev, NULL);
         return 0;
 }
@@ -351 +334 @@
         .match          = snd_gusextreme_match,
         .probe          = snd_gusextreme_probe,
-        .remove         = __devexit_p(snd_gusextreme_remove),
+        .remove         = snd_gusextreme_remove,
 #if 0   /* FIXME */
         .suspend        = snd_gusextreme_suspend,
@@ -361 +344 @@
 };
 
-static int __init alsa_card_gusextreme_init(void)
-{
-        return isa_register_driver(&snd_gusextreme_driver, SNDRV_CARDS);
-}
-
-static void __exit alsa_card_gusextreme_exit(void)
-{
-        isa_unregister_driver(&snd_gusextreme_driver);
-}
-
-module_init(alsa_card_gusextreme_init);
-module_exit(alsa_card_gusextreme_exit);
+module_isa_driver(snd_gusextreme_driver, SNDRV_CARDS);