Changeset 639

Timestamp:

Jan 8, 2021, 12:31:24 AM (5 years ago)

Author:

David Azarewicz

Message:

Fixed more warnings.

Location:

GPL/branches/uniaud32-next

Files:

• alsa-kernel/core/init.c (modified) (2 diffs)
• alsa-kernel/core/seq/seq_clientmgr.c (modified) (16 diffs)
• include/asm/uaccess.h (modified) (1 diff)
• lib32/bitmap.c (modified) (1 diff)
• lib32/misc.c (modified) (1 diff)

GPL/branches/uniaud32-next/alsa-kernel/core/init.c

@@ -423 +423 @@
 
                 mfile->file->f_op = &snd_shutdown_f_ops;
-                fops_get(mfile->file->f_op);
+                //DAZ this does nothing. fops_get(mfile->file->f_op);
         }
         spin_unlock(&card->files_lock); 
@@ -908 +908 @@
  *  Return: Zero otherwise a negative error code.
  */
-  
+
 int snd_component_add(struct snd_card *card, const char *component)
 {

GPL/branches/uniaud32-next/alsa-kernel/core/seq/seq_clientmgr.c

@@ -29 +29 @@
 
  * this module handles the connections of userland and kernel clients
- * 
+ *
  */
 
@@ -411 +411 @@
                 return -ENXIO;
 
-        if (!access_ok(buf, count))
+        if (!access_ok(0, buf, count))
                 return -EFAULT;
 
@@ -526 +526 @@
  * encapsulated in SNDRV_SEQ_EVENT_BOUNCE as variable length event.  If
  * the original event is also variable length, the external data is
- * copied after the event record. 
+ * copied after the event record.
  * If the receiver client is a kernel client, the original event is
  * quoted in SNDRV_SEQ_EVENT_KERNEL_ERROR, since this requires no extra
@@ -713 +713 @@
 
 
-#ifdef SUPPORT_BROADCAST 
+#ifdef SUPPORT_BROADCAST
 /*
  * broadcast to all ports:
@@ -1037 +1037 @@
  repeat:
         handled = 0;
-        /* allocate the pool now if the pool is not allocated yet */ 
+        /* allocate the pool now if the pool is not allocated yet */
         mutex_lock(&client->ioctl_mutex);
         if (client->pool->size > 0 && !snd_seq_write_pool_allocated(client)) {
@@ -1289 +1289 @@
 
 
-/* 
- * CREATE PORT ioctl() 
+/*
+ * CREATE PORT ioctl()
  */
 static int snd_seq_ioctl_create_port(struct snd_seq_client *client, void *arg)
@@ -1336 +1336 @@
 }
 
-/* 
- * DELETE PORT ioctl() 
+/*
+ * DELETE PORT ioctl()
  */
 static int snd_seq_ioctl_delete_port(struct snd_seq_client *client, void *arg)
@@ -1355 +1355 @@
 
 
-/* 
- * GET_PORT_INFO ioctl() (on any client) 
+/*
+ * GET_PORT_INFO ioctl() (on any client)
  */
 static int snd_seq_ioctl_get_port_info(struct snd_seq_client *client, void *arg)
@@ -1383 +1383 @@
 
 
-/* 
- * SET_PORT_INFO ioctl() (only ports on this/own client) 
+/*
+ * SET_PORT_INFO ioctl() (only ports on this/own client)
  */
 static int snd_seq_ioctl_set_port_info(struct snd_seq_client *client, void *arg)
@@ -1457 +1457 @@
 
 
-/* 
- * add to port's subscription list IOCTL interface 
+/*
+ * add to port's subscription list IOCTL interface
  */
 static int snd_seq_ioctl_subscribe_port(struct snd_seq_client *client,
@@ -1499 +1499 @@
 
 
-/* 
- * remove from port's subscription list 
+/*
+ * remove from port's subscription list
  */
 static int snd_seq_ioctl_unsubscribe_port(struct snd_seq_client *client,
@@ -2035 +2035 @@
 }
 
-/* 
+/*
  * query next port
  */
@@ -2304 +2304 @@
 EXPORT_SYMBOL(snd_seq_kernel_client_enqueue);
 
-/* 
+/*
  * exported, called by kernel clients to dispatch events directly to other
  * clients, bypassing the queues.  Event time-stamp will be updated.
@@ -2456 +2456 @@
 
 /* exported to seq_info.c */
-void snd_seq_info_clients_read(struct snd_info_entry *entry, 
+void snd_seq_info_clients_read(struct snd_info_entry *entry,
                                struct snd_info_buffer *buffer)
 {
@@ -2522 +2522 @@
 static struct device seq_dev;
 
-/* 
- * register sequencer device 
+/*
+ * register sequencer device
  */
 int __init snd_sequencer_device_init(void)
@@ -2546 +2546 @@
 
 
-/* 
- * unregister sequencer device 
+/*
+ * unregister sequencer device
  */
 void snd_sequencer_device_done(void)

GPL/branches/uniaud32-next/include/asm/uaccess.h

@@ -44 +44 @@
 int is_access_ok(int type, void *addr, unsigned long size);
 
-#define access_ok(addr, size) __access_ok((unsigned long)(addr),(size))
+#define access_ok(type, addr, size) __access_ok((unsigned long)(addr),(size))
 
 /*

GPL/branches/uniaud32-next/lib32/bitmap.c

@@ -1173 +1173 @@
 EXPORT_SYMBOL(bitmap_allocate_region);
 
+#pragma disable_message (201)
 /**
  * bitmap_copy_le - copy a bitmap, putting the bits into little-endian order.

GPL/branches/uniaud32-next/lib32/misc.c

@@ -741 +741 @@
 {
         filp->f_mode &= ~(FMODE_LSEEK | FMODE_PREAD | FMODE_PWRITE | FMODE_ATOMIC_POS);
-        filp->f_mode |= FMODE_STREAM;
+        //DAZ f_mode is 16 bit so FMODE_STREAM doesn't fit, but we don't use this on OS/2.
+        //filp->f_mode |= FMODE_STREAM;
         return 0;
 }