Changeset 598 for GPL/trunk/alsa-kernel/pci/emu10k1/emuproc.c

Timestamp:

Apr 3, 2017, 4:51:56 PM (8 years ago)

Author:

David Azarewicz

Message:

Merged/reintegrated v2 branch into trunk. Trunk is now v2

Location:

GPL/trunk

Files:

• . (modified) (1 prop)
• alsa-kernel/pci/emu10k1/emuproc.c (modified) (4 diffs)

GPL/trunk/alsa-kernel/pci/emu10k1/emuproc.c

@@ -342 +342 @@
 #define A_TOTAL_SIZE_CODE       (0x400*8)
 
-static long snd_emu10k1_fx8010_read(struct snd_info_entry *entry,
-                                    void *file_private_data,
-                                    struct file *file, char __user *buf,
-                                    unsigned long count, unsigned long pos)
-{
-        long size;
+static ssize_t snd_emu10k1_fx8010_read(struct snd_info_entry *entry,
+                                       void *file_private_data,
+                                       struct file *file, char __user *buf,
+                                       size_t count, loff_t pos)
+{
         struct snd_emu10k1 *emu = entry->private_data;
         unsigned int offset;
         int tram_addr = 0;
+        unsigned int *tmp;
+        long res;
+        unsigned int idx;
         
         if (!strcmp(entry->name, "fx8010_tram_addr")) {
@@ -362 +364 @@
                 offset = emu->audigy ? A_FXGPREGBASE : FXGPREGBASE;
         }
-        size = count;
-        if (pos + size > entry->size)
-                size = (long)entry->size - pos;
-        if (size > 0) {
-                unsigned int *tmp;
-                long res;
-                unsigned int idx;
-                if ((tmp = kmalloc(size + 8, GFP_KERNEL)) == NULL)
-                        return -ENOMEM;
-                for (idx = 0; idx < ((pos & 3) + size + 3) >> 2; idx++)
-                        if (tram_addr && emu->audigy) {
-                                tmp[idx] = snd_emu10k1_ptr_read(emu, offset + idx + (pos >> 2), 0) >> 11;
-                                tmp[idx] |= snd_emu10k1_ptr_read(emu, 0x100 + idx + (pos >> 2), 0) << 20;
-                        } else 
-                                tmp[idx] = snd_emu10k1_ptr_read(emu, offset + idx + (pos >> 2), 0);
-                if (copy_to_user(buf, ((char *)tmp) + (pos & 3), size))
-                        res = -EFAULT;
-                else {
-                        res = size;
+
+        tmp = kmalloc(count + 8, GFP_KERNEL);
+        if (!tmp)
+                return -ENOMEM;
+        for (idx = 0; idx < ((pos & 3) + count + 3) >> 2; idx++) {
+                unsigned int val;
+                val = snd_emu10k1_ptr_read(emu, offset + idx + (pos >> 2), 0);
+                if (tram_addr && emu->audigy) {
+                        val >>= 11;
+                        val |= snd_emu10k1_ptr_read(emu, 0x100 + idx + (pos >> 2), 0) << 20;
                 }
-                kfree(tmp);
-                return res;
-        }
-        return 0;
+                tmp[idx] = val;
+        }
+        if (copy_to_user(buf, ((char *)tmp) + (pos & 3), count))
+                res = -EFAULT;
+        else
+                res = count;
+        kfree(tmp);
+        return res;
 }
 
@@ -452 +449 @@
                 if (sscanf(line, "%x %x", &reg, &val) != 2)
                         continue;
-                if ((reg < 0x40) && (reg >= 0) && (val <= 0xffffffff) ) {
+                if (reg < 0x40 && val <= 0xffffffff) {
                         spin_lock_irqsave(&emu->emu_lock, flags);
                         outl(val, emu->port + (reg & 0xfffffffc));
@@ -528 +525 @@
                 if (sscanf(line, "%x %x %x", &reg, &channel_id, &val) != 3)
                         continue;
-                if ((reg < 0xa0) && (reg >= 0) && (val <= 0xffffffff) && (channel_id >= 0) && (channel_id <= 3) )
+                if (reg < 0xa0 && val <= 0xffffffff && channel_id <= 3)
                         snd_ptr_write(emu, iobase, reg, channel_id, val);
         }