Changeset 988 for vendor/current/source4/kdc

Timestamp:

Nov 24, 2016, 1:14:11 PM (9 years ago)

Author:

Silvan Scherrer

Message:

Samba Server: update vendor to version 4.4.3

Location:

vendor/current/source4/kdc

Files:

• db-glue.c (modified) (86 diffs)
• db-glue.h (modified) (2 diffs)
• hdb-samba4-plugin.c (added)
• hdb-samba4.c (modified) (9 diffs)
• kdc-glue.c (added)
• kdc-glue.h (modified) (1 diff)
• kdc-policy.h (deleted)
• kdc.c (modified) (16 diffs)
• kpasswd_glue.c (added)
• kpasswd_glue.h (added)
• kpasswdd.c (modified) (9 diffs)
• mit_samba.c (modified) (7 diffs)
• pac-glue.c (modified) (11 diffs)
• pac-glue.h (modified) (1 diff)
• policy.c (deleted)
• proxy.c (modified) (1 diff)
• samba_kdc.h (modified) (3 diffs)
• sdb.c (added)
• sdb.h (added)
• sdb_to_hdb.c (added)
• wdc-samba4.c (modified) (12 diffs)
• wscript_build (modified) (2 diffs)

vendor/current/source4/kdc/db-glue.c

@@ -33 +33 @@
 #include "system/kerberos.h"
 #include "auth/kerberos/kerberos.h"
-#include <hdb.h>
+#include "kdc/sdb.h"
 #include "kdc/samba_kdc.h"
-#include "kdc/kdc-policy.h"
+#include "kdc/db-glue.h"
 
 #define SAMBA_KVNO_GET_KRBTGT(kvno) \
@@ -66 +66 @@
 };
 
-static KerberosTime ldb_msg_find_krb5time_ldap_time(struct ldb_message *msg, const char *attr, KerberosTime default_val)
+
+static time_t ldb_msg_find_krb5time_ldap_time(struct ldb_message *msg, const char *attr, time_t default_val)
 {
     const char *tmp;
@@ -84 +85 @@
 }
 
-static HDBFlags uf2HDBFlags(krb5_context context, uint32_t userAccountControl, enum samba_kdc_ent_type ent_type)
+static struct SDBFlags uf2SDBFlags(krb5_context context, uint32_t userAccountControl, enum samba_kdc_ent_type ent_type)
 {
-        HDBFlags flags = int2HDBFlags(0);
+        struct SDBFlags flags = int2SDBFlags(0);
 
         /* we don't allow kadmin deletes */
@@ -131 +132 @@
         }
         if (userAccountControl & UF_LOCKOUT) {
-                flags.invalid = 1;
+                flags.locked_out = 1;
         }
 /*
@@ -158 +159 @@
                 flags.ok_as_delegate = 1;
         }
+        if (userAccountControl & UF_TRUSTED_TO_AUTHENTICATE_FOR_DELEGATION) {
+                /*
+                 * this is confusing...
+                 *
+                 * UF_TRUSTED_FOR_DELEGATION
+                 * => ok_as_delegate
+                 *
+                 * and
+                 *
+                 * UF_TRUSTED_TO_AUTHENTICATE_FOR_DELEGATION
+                 * => trusted_for_delegation
+                 */
+                flags.trusted_for_delegation = 1;
+        }
         if (!(userAccountControl & UF_NOT_DELEGATED)) {
                 flags.forwardable = 1;
@@ -174 +189 @@
 static int samba_kdc_entry_destructor(struct samba_kdc_entry *p)
 {
-    hdb_entry_ex *entry_ex = p->entry_ex;
-    free_hdb_entry(&entry_ex->entry);
-    return 0;
-}
-
-static void samba_kdc_free_entry(krb5_context context, hdb_entry_ex *entry_ex)
-{
-        /* this function is called only from hdb_free_entry().
-         * Make sure we neutralize the destructor or we will
-         * get a double free later when hdb_free_entry() will
-         * try to call free_hdb_entry() */
-        talloc_set_destructor(entry_ex->ctx, NULL);
-
-        /* now proceed to free the talloc part */
-        talloc_free(entry_ex->ctx);
+        if (p->entry_ex != NULL) {
+                struct sdb_entry_ex *entry_ex = p->entry_ex;
+                free_sdb_entry(&entry_ex->entry);
+        }
+
+        return 0;
 }
 
@@ -199 +205 @@
                                                     uint32_t userAccountControl,
                                                     enum samba_kdc_ent_type ent_type,
-                                                    hdb_entry_ex *entry_ex)
+                                                    struct sdb_entry_ex *entry_ex)
 {
         krb5_error_code ret = 0;
@@ -359 +365 @@
                 if (kdc_db_ctx->rodc) {
                         /* We are on an RODC, but don't have keys for this account.  Signal this to the caller */
-                        return HDB_ERR_NOT_FOUND_HERE;
+                        /* TODO:  We need to call a generalised version of auth_sam_trigger_repl_secret from here */
+                        return SDB_ERR_NOT_FOUND_HERE;
                 }
 
@@ -370 +377 @@
         /* allocate space to decode into */
         entry_ex->entry.keys.len = 0;
-        entry_ex->entry.keys.val = calloc(allocated_keys, sizeof(Key));
+        entry_ex->entry.keys.val = calloc(allocated_keys, sizeof(struct sdb_key));
         if (entry_ex->entry.keys.val == NULL) {
                 ret = ENOMEM;
@@ -377 +384 @@
 
         if (hash && (supported_enctypes & ENC_RC4_HMAC_MD5)) {
-                Key key;
-
-                key.mkvno = 0;
-                key.salt = NULL; /* No salt for this enc type */
-
-                ret = krb5_keyblock_init(context,
-                                         ENCTYPE_ARCFOUR_HMAC,
-                                         hash->hash, sizeof(hash->hash),
-                                         &key.key);
+                struct sdb_key key = {};
+
+                ret = smb_krb5_keyblock_init_contents(context,
+                                                      ENCTYPE_ARCFOUR_HMAC,
+                                                      hash->hash,
+                                                      sizeof(hash->hash),
+                                                      &key.key);
                 if (ret) {
                         goto out;
@@ -396 +401 @@
         if (pkb4) {
                 for (i=0; i < pkb4->num_keys; i++) {
-                        Key key;
+                        struct sdb_key key = {};
 
                         if (!pkb4->keys[i].value) continue;
@@ -403 +408 @@
                                 continue;
                         }
-
-                        key.mkvno = 0;
-                        key.salt = NULL;
 
                         if (pkb4->salt.string) {
@@ -418 +420 @@
                                 }
 
-                                key.salt->type = hdb_pw_salt;
-
-                                ret = krb5_data_copy(&key.salt->salt, salt.data, salt.length);
+                                key.salt->type = KRB5_PW_SALT;
+
+                                ret = krb5_copy_data_contents(&key.salt->salt,
+                                                              salt.data,
+                                                              salt.length);
                                 if (ret) {
                                         free(key.salt);
@@ -430 +434 @@
                         /* TODO: maybe pass the iteration_count somehow... */
 
-                        ret = krb5_keyblock_init(context,
-                                                 pkb4->keys[i].keytype,
-                                                 pkb4->keys[i].value->data,
-                                                 pkb4->keys[i].value->length,
-                                                 &key.key);
+                        ret = smb_krb5_keyblock_init_contents(context,
+                                                              pkb4->keys[i].keytype,
+                                                              pkb4->keys[i].value->data,
+                                                              pkb4->keys[i].value->length,
+                                                              &key.key);
                         if (ret == KRB5_PROG_ETYPE_NOSUPP) {
                                 DEBUG(2,("Unsupported keytype ignored - type %u\n",
@@ -443 +447 @@
                         if (ret) {
                                 if (key.salt) {
-                                        free_Salt(key.salt);
+                                        kerberos_free_data_contents(context, &key.salt->salt);
                                         free(key.salt);
                                         key.salt = NULL;
@@ -455 +459 @@
         } else if (pkb3) {
                 for (i=0; i < pkb3->num_keys; i++) {
-                        Key key;
+                        struct sdb_key key = {};
 
                         if (!pkb3->keys[i].value) continue;
@@ -462 +466 @@
                                 continue;
                         }
-
-                        key.mkvno = 0;
-                        key.salt = NULL;
 
                         if (pkb3->salt.string) {
@@ -477 +478 @@
                                 }
 
-                                key.salt->type = hdb_pw_salt;
-
-                                ret = krb5_data_copy(&key.salt->salt, salt.data, salt.length);
+                                key.salt->type = KRB5_PW_SALT;
+
+                                ret = krb5_copy_data_contents(&key.salt->salt,
+                                                              salt.data,
+                                                              salt.length);
                                 if (ret) {
                                         free(key.salt);
@@ -487 +490 @@
                         }
 
-                        ret = krb5_keyblock_init(context,
-                                                 pkb3->keys[i].keytype,
-                                                 pkb3->keys[i].value->data,
-                                                 pkb3->keys[i].value->length,
-                                                 &key.key);
+                        ret = smb_krb5_keyblock_init_contents(context,
+                                                              pkb3->keys[i].keytype,
+                                                              pkb3->keys[i].value->data,
+                                                              pkb3->keys[i].value->length,
+                                                              &key.key);
                         if (ret) {
                                 if (key.salt) {
-                                        free_Salt(key.salt);
+                                        kerberos_free_data_contents(context, &key.salt->salt);
                                         free(key.salt);
                                         key.salt = NULL;
@@ -515 +518 @@
         }
         return ret;
+}
+
+static int principal_comp_strcmp_int(krb5_context context,
+                                     krb5_const_principal principal,
+                                     unsigned int component,
+                                     const char *string,
+                                     bool do_strcasecmp)
+{
+        const char *p;
+        size_t len;
+
+#if defined(HAVE_KRB5_PRINCIPAL_GET_COMP_STRING)
+        p = krb5_principal_get_comp_string(context, principal, component);
+        if (p == NULL) {
+                return -1;
+        }
+        len = strlen(p);
+#else
+        krb5_data *d;
+        if (component >= krb5_princ_size(context, principal)) {
+                return -1;
+        }
+
+        d = krb5_princ_component(context, principal, component);
+        if (d == NULL) {
+                return -1;
+        }
+
+        p = d->data;
+        len = d->length;
+#endif
+        if (do_strcasecmp) {
+                return strncasecmp(p, string, len);
+        } else {
+                return strncmp(p, string, len);
+        }
+}
+
+static int principal_comp_strcasecmp(krb5_context context,
+                                     krb5_const_principal principal,
+                                     unsigned int component,
+                                     const char *string)
+{
+        return principal_comp_strcmp_int(context, principal,
+                                         component, string, true);
+}
+
+static int principal_comp_strcmp(krb5_context context,
+                                 krb5_const_principal principal,
+                                 unsigned int component,
+                                 const char *string)
+{
+        return principal_comp_strcmp_int(context, principal,
+                                         component, string, false);
 }
 
@@ -522 +579 @@
 static krb5_error_code samba_kdc_message2entry(krb5_context context,
                                                struct samba_kdc_db_context *kdc_db_ctx,
-                                               TALLOC_CTX *mem_ctx, krb5_const_principal principal,
+                                               TALLOC_CTX *mem_ctx,
+                                               krb5_const_principal principal,
                                                enum samba_kdc_ent_type ent_type,
                                                unsigned flags,
                                                struct ldb_dn *realm_dn,
                                                struct ldb_message *msg,
-                                               hdb_entry_ex *entry_ex)
+                                               struct sdb_entry_ex *entry_ex)
 {
         struct loadparm_context *lp_ctx = kdc_db_ctx->lp_ctx;
         uint32_t userAccountControl;
+        uint32_t msDS_User_Account_Control_Computed;
         unsigned int i;
         krb5_error_code ret = 0;
@@ -563 +622 @@
         }
 
-        memset(entry_ex, 0, sizeof(*entry_ex));
-
-        p = talloc(mem_ctx, struct samba_kdc_entry);
+        ZERO_STRUCTP(entry_ex);
+
+        p = talloc_zero(mem_ctx, struct samba_kdc_entry);
         if (!p) {
                 ret = ENOMEM;
@@ -572 +631 @@
 
         p->kdc_db_ctx = kdc_db_ctx;
-        p->entry_ex = entry_ex;
         p->realm_dn = talloc_reference(p, realm_dn);
         if (!p->realm_dn) {
@@ -581 +639 @@
         talloc_set_destructor(p, samba_kdc_entry_destructor);
 
-        /* make sure we do not have bogus data in there */
-        memset(&entry_ex->entry, 0, sizeof(hdb_entry));
-
         entry_ex->ctx = p;
-        entry_ex->free_entry = samba_kdc_free_entry;
 
         userAccountControl = ldb_msg_find_attr_as_uint(msg, "userAccountControl", 0);
 
-
-        entry_ex->entry.principal = malloc(sizeof(*(entry_ex->entry.principal)));
-        if (ent_type == SAMBA_KDC_ENT_TYPE_ANY && principal == NULL) {
-                krb5_make_principal(context, &entry_ex->entry.principal, lpcfg_realm(lp_ctx), samAccountName, NULL);
+        msDS_User_Account_Control_Computed
+                = ldb_msg_find_attr_as_uint(msg,
+                                            "msDS-User-Account-Control-Computed",
+                                            UF_ACCOUNTDISABLE);
+
+        /*
+         * This brings in the lockout flag, block the account if not
+         * found.  We need the weird UF_ACCOUNTDISABLE check because
+         * we do not want to fail open if the value is not returned,
+         * but 0 is a valid value (all OK)
+         */
+        if (msDS_User_Account_Control_Computed == UF_ACCOUNTDISABLE) {
+                ret = EINVAL;
+                krb5_set_error_message(context, ret, "samba_kdc_message2entry: "
+                                "no msDS-User-Account-Control-Computed present");
+                goto out;
         } else {
-                ret = copy_Principal(principal, entry_ex->entry.principal);
+                userAccountControl |= msDS_User_Account_Control_Computed;
+        }
+
+        /* 
+         * If we are set to canonicalize, we get back the fixed UPPER
+         * case realm, and the real username (ie matching LDAP
+         * samAccountName) 
+         *
+         * Otherwise, if we are set to enterprise, we
+         * get back the whole principal as-sent 
+         *
+         * Finally, if we are not set to canonicalize, we get back the
+         * fixed UPPER case realm, but the as-sent username
+         */
+
+        if (ent_type == SAMBA_KDC_ENT_TYPE_KRBTGT) {
+                if (flags & (SDB_F_CANON)) {
+                        /*
+                         * When requested to do so, ensure that the
+                         * both realm values in the principal are set
+                         * to the upper case, canonical realm
+                         */
+                        ret = smb_krb5_make_principal(context, &entry_ex->entry.principal,
+                                                      lpcfg_realm(lp_ctx), "krbtgt",
+                                                      lpcfg_realm(lp_ctx), NULL);
+                        if (ret) {
+                                krb5_clear_error_message(context);
+                                goto out;
+                        }
+                        smb_krb5_principal_set_type(context, entry_ex->entry.principal, KRB5_NT_SRV_INST);
+                } else {
+                        ret = krb5_copy_principal(context, principal, &entry_ex->entry.principal);
+                        if (ret) {
+                                krb5_clear_error_message(context);
+                                goto out;
+                        }
+                        /*
+                         * this appears to be required regardless of
+                         * the canonicalize flag from the client
+                         */
+                        ret = smb_krb5_principal_set_realm(context, entry_ex->entry.principal, lpcfg_realm(lp_ctx));
+                        if (ret) {
+                                krb5_clear_error_message(context);
+                                goto out;
+                        }
+                }
+
+        } else if (ent_type == SAMBA_KDC_ENT_TYPE_ANY && principal == NULL) {
+                ret = smb_krb5_make_principal(context, &entry_ex->entry.principal, lpcfg_realm(lp_ctx), samAccountName, NULL);
                 if (ret) {
                         krb5_clear_error_message(context);
                         goto out;
                 }
-
-                /* While we have copied the client principal, tests
-                 * show that Win2k3 returns the 'corrected' realm, not
-                 * the client-specified realm.  This code attempts to
-                 * replace the client principal's realm with the one
-                 * we determine from our records */
-
-                /* this has to be with malloc() */
-                krb5_principal_set_realm(context, entry_ex->entry.principal, lpcfg_realm(lp_ctx));
+        } else if (flags & SDB_F_CANON && flags & SDB_F_FOR_AS_REQ) {
+                /*
+                 * SDB_F_CANON maps from the canonicalize flag in the
+                 * packet, and has a different meaning between AS-REQ
+                 * and TGS-REQ.  We only change the principal in the AS-REQ case
+                 */
+                ret = smb_krb5_make_principal(context, &entry_ex->entry.principal, lpcfg_realm(lp_ctx), samAccountName, NULL);
+                if (ret) {
+                        krb5_clear_error_message(context);
+                        goto out;
+                }
+        } else {
+                ret = krb5_copy_principal(context, principal, &entry_ex->entry.principal);
+                if (ret) {
+                        krb5_clear_error_message(context);
+                        goto out;
+                }
+
+                if (smb_krb5_principal_get_type(context, principal) != KRB5_NT_ENTERPRISE_PRINCIPAL) {
+                        /* While we have copied the client principal, tests
+                         * show that Win2k3 returns the 'corrected' realm, not
+                         * the client-specified realm.  This code attempts to
+                         * replace the client principal's realm with the one
+                         * we determine from our records */
+                        
+                        /* this has to be with malloc() */
+                        ret = smb_krb5_principal_set_realm(context, entry_ex->entry.principal, lpcfg_realm(lp_ctx));
+                        if (ret) {
+                                krb5_clear_error_message(context);
+                                goto out;
+                        }
+                }
         }
 
         /* First try and figure out the flags based on the userAccountControl */
-        entry_ex->entry.flags = uf2HDBFlags(context, userAccountControl, ent_type);
+        entry_ex->entry.flags = uf2SDBFlags(context, userAccountControl, ent_type);
 
         /* Windows 2008 seems to enforce this (very sensible) rule by
@@ -624 +761 @@
                 }
         }
-
-        if (flags & HDB_F_ADMIN_DATA) {
+        /*
+         * To give the correct type of error to the client, we must
+         * not just return the entry without .server set, we must
+         * pretend the principal does not exist.  Otherwise we may
+         * return ERR_POLICY instead of
+         * KRB5KDC_ERR_S_PRINCIPAL_UNKNOWN
+         */
+        if (ent_type == SAMBA_KDC_ENT_TYPE_SERVER && entry_ex->entry.flags.server == 0) {
+                ret = SDB_ERR_NOENTRY;
+                krb5_set_error_message(context, ret, "samba_kdc_message2entry: no servicePrincipalName present for this server, refusing with no-such-entry");
+                goto out;
+        }
+        if (flags & SDB_F_ADMIN_DATA) {
                 /* These (created_by, modified_by) parts of the entry are not relevant for Samba4's use
                  * of the Heimdal KDC.  They are stored in a the traditional
@@ -634 +782 @@
                 entry_ex->entry.created_by.time = ldb_msg_find_krb5time_ldap_time(msg, "whenCreated", 0);
                 /* use 'kadmin' for now (needed by mit_samba) */
-                krb5_make_principal(context,
-                                    &entry_ex->entry.created_by.principal,
-                                    lpcfg_realm(lp_ctx), "kadmin", NULL);
-
-                entry_ex->entry.modified_by = (Event *) malloc(sizeof(Event));
+
+                ret = smb_krb5_make_principal(context,
+                                              &entry_ex->entry.created_by.principal,
+                                              lpcfg_realm(lp_ctx), "kadmin", NULL);
+                if (ret) {
+                        krb5_clear_error_message(context);
+                        goto out;
+                }
+
+                entry_ex->entry.modified_by = (struct sdb_event *) malloc(sizeof(struct sdb_event));
                 if (entry_ex->entry.modified_by == NULL) {
                         ret = ENOMEM;
@@ -648 +801 @@
                 entry_ex->entry.modified_by->time = ldb_msg_find_krb5time_ldap_time(msg, "whenChanged", 0);
                 /* use 'kadmin' for now (needed by mit_samba) */
-                krb5_make_principal(context,
-                                    &entry_ex->entry.modified_by->principal,
-                                    lpcfg_realm(lp_ctx), "kadmin", NULL);
+                ret = smb_krb5_make_principal(context,
+                                              &entry_ex->entry.modified_by->principal,
+                                              lpcfg_realm(lp_ctx), "kadmin", NULL);
+                if (ret) {
+                        krb5_clear_error_message(context);
+                        goto out;
+                }
         }
 
@@ -664 +821 @@
 
         if (rid == DOMAIN_RID_KRBTGT) {
+                char *realm = NULL;
+
                 entry_ex->entry.valid_end = NULL;
                 entry_ex->entry.pw_end = NULL;
@@ -669 +828 @@
                 entry_ex->entry.flags.invalid = 0;
                 entry_ex->entry.flags.server = 1;
+
+                realm = smb_krb5_principal_get_realm(context, principal);
+                if (realm == NULL) {
+                        ret = ENOMEM;
+                        goto out;
+                }
 
                 /* Don't mark all requests for the krbtgt/realm as
@@ -675 +840 @@
                  * Instead, only do it when request is for the kpasswd service */
                 if (ent_type == SAMBA_KDC_ENT_TYPE_SERVER
-                    && principal->name.name_string.len == 2
-                    && (strcmp(principal->name.name_string.val[0], "kadmin") == 0)
-                    && (strcmp(principal->name.name_string.val[1], "changepw") == 0)
-                    && lpcfg_is_my_domain_or_realm(lp_ctx, principal->realm)) {
+                    && krb5_princ_size(context, principal) == 2
+                    && (principal_comp_strcmp(context, principal, 0, "kadmin") == 0)
+                    && (principal_comp_strcmp(context, principal, 1, "changepw") == 0)
+                    && lpcfg_is_my_domain_or_realm(lp_ctx, realm)) {
                         entry_ex->entry.flags.change_pw = 1;
                 }
+
+                SAFE_FREE(realm);
+
                 entry_ex->entry.flags.client = 0;
                 entry_ex->entry.flags.forwardable = 1;
@@ -748 +916 @@
 
         if (ent_type == SAMBA_KDC_ENT_TYPE_SERVER) {
-                *entry_ex->entry.max_life = nt_time_to_unix(kdc_db_ctx->policy.service_tkt_lifetime);
+                *entry_ex->entry.max_life = kdc_db_ctx->policy.svc_tkt_lifetime;
         } else if (ent_type == SAMBA_KDC_ENT_TYPE_KRBTGT || ent_type == SAMBA_KDC_ENT_TYPE_CLIENT) {
-                *entry_ex->entry.max_life = nt_time_to_unix(kdc_db_ctx->policy.user_tkt_lifetime);
+                *entry_ex->entry.max_life = kdc_db_ctx->policy.usr_tkt_lifetime;
         } else {
-                *entry_ex->entry.max_life = MIN(nt_time_to_unix(kdc_db_ctx->policy.service_tkt_lifetime),
-                                               nt_time_to_unix(kdc_db_ctx->policy.user_tkt_lifetime));
+                *entry_ex->entry.max_life = MIN(kdc_db_ctx->policy.svc_tkt_lifetime,
+                                                kdc_db_ctx->policy.usr_tkt_lifetime);
         }
 
@@ -762 +930 @@
         }
 
-        *entry_ex->entry.max_renew = nt_time_to_unix(kdc_db_ctx->policy.user_tkt_renewaltime);
-
-        entry_ex->entry.generation = NULL;
+        *entry_ex->entry.max_renew = kdc_db_ctx->policy.renewal_lifetime;
 
         /* Get keys from the db */
@@ -771 +937 @@
                                            ent_type, entry_ex);
         if (ret) {
-                /* Could be bougus data in the entry, or out of memory */
+                /* Could be bogus data in the entry, or out of memory */
                 goto out;
         }
@@ -789 +955 @@
         }
         for (i=0; i < entry_ex->entry.etypes->len; i++) {
-                entry_ex->entry.etypes->val[i] = entry_ex->entry.keys.val[i].key.keytype;
+                entry_ex->entry.etypes->val[i] = KRB5_KEY_TYPE(&entry_ex->entry.keys.val[i].key);
         }
 
@@ -798 +964 @@
         if (ret != 0) {
                 /* This doesn't free ent itself, that is for the eventual caller to do */
-                hdb_free_entry(context, entry_ex);
+                sdb_free_entry(entry_ex);
+                ZERO_STRUCTP(entry_ex);
         } else {
                 talloc_steal(kdc_db_ctx, entry_ex->ctx);
@@ -808 +975 @@
 /*
  * Construct an hdb_entry from a directory entry.
+ * The kvno is what the remote client asked for
  */
 static krb5_error_code samba_kdc_trust_message2entry(krb5_context context,
@@ -814 +982 @@
                                                enum trust_direction direction,
                                                struct ldb_dn *realm_dn,
+                                               unsigned flags,
+                                               uint32_t kvno,
                                                struct ldb_message *msg,
-                                               hdb_entry_ex *entry_ex)
+                                               struct sdb_entry_ex *entry_ex)
 {
         struct loadparm_context *lp_ctx = kdc_db_ctx->lp_ctx;
-        const char *dnsdomain;
-        const char *realm = lpcfg_realm(lp_ctx);
-        DATA_BLOB password_utf16;
-        struct samr_Password password_hash;
+        const char *our_realm = lpcfg_realm(lp_ctx);
+        const char *dnsdomain = NULL;
+        char *partner_realm = NULL;
+        const char *realm = NULL;
+        const char *krbtgt_realm = NULL;
+        DATA_BLOB password_utf16 = data_blob_null;
+        DATA_BLOB password_utf8 = data_blob_null;
+        struct samr_Password _password_hash;
+        const struct samr_Password *password_hash = NULL;
         const struct ldb_val *password_val;
         struct trustAuthInOutBlob password_blob;
         struct samba_kdc_entry *p;
-
+        bool use_previous = false;
+        uint32_t current_kvno;
+        uint32_t previous_kvno;
+        uint32_t num_keys = 0;
         enum ndr_err_code ndr_err;
         int ret, trust_direction_flags;
         unsigned int i;
+        struct AuthenticationInformationArray *auth_array;
+        struct timeval tv;
+        NTTIME an_hour_ago;
+        uint32_t *auth_kvno;
+        bool preferr_current = false;
+        uint32_t supported_enctypes = ENC_RC4_HMAC_MD5;
+
+        if (dsdb_functional_level(kdc_db_ctx->samdb) >= DS_DOMAIN_FUNCTION_2008) {
+                supported_enctypes = ldb_msg_find_attr_as_uint(msg,
+                                        "msDS-SupportedEncryptionTypes",
+                                        supported_enctypes);
+        }
+
+        trust_direction_flags = ldb_msg_find_attr_as_int(msg, "trustDirection", 0);
+        if (!(trust_direction_flags & direction)) {
+                krb5_clear_error_message(context);
+                ret = SDB_ERR_NOENTRY;
+                goto out;
+        }
+
+        dnsdomain = ldb_msg_find_attr_as_string(msg, "trustPartner", NULL);
+        if (dnsdomain == NULL) {
+                krb5_clear_error_message(context);
+                ret = SDB_ERR_NOENTRY;
+                goto out;
+        }
+        partner_realm = strupper_talloc(mem_ctx, dnsdomain);
+        if (partner_realm == NULL) {
+                krb5_clear_error_message(context);
+                ret = ENOMEM;
+                goto out;
+        }
+
+        if (direction == INBOUND) {
+                realm = our_realm;
+                krbtgt_realm = partner_realm;
+
+                password_val = ldb_msg_find_ldb_val(msg, "trustAuthIncoming");
+        } else { /* OUTBOUND */
+                realm = partner_realm;
+                krbtgt_realm = our_realm;
+
+                password_val = ldb_msg_find_ldb_val(msg, "trustAuthOutgoing");
+        }
+
+        if (password_val == NULL) {
+                krb5_clear_error_message(context);
+                ret = SDB_ERR_NOENTRY;
+                goto out;
+        }
+
+        ndr_err = ndr_pull_struct_blob(password_val, mem_ctx, &password_blob,
+                                       (ndr_pull_flags_fn_t)ndr_pull_trustAuthInOutBlob);
+        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+                krb5_clear_error_message(context);
+                ret = EINVAL;
+                goto out;
+        }
 
         p = talloc(mem_ctx, struct samba_kdc_entry);
@@ -837 +1073 @@
 
         p->kdc_db_ctx = kdc_db_ctx;
-        p->entry_ex = entry_ex;
         p->realm_dn = realm_dn;
 
@@ -843 +1078 @@
 
         /* make sure we do not have bogus data in there */
-        memset(&entry_ex->entry, 0, sizeof(hdb_entry));
+        memset(&entry_ex->entry, 0, sizeof(struct sdb_entry));
 
         entry_ex->ctx = p;
-        entry_ex->free_entry = samba_kdc_free_entry;
 
         /* use 'whenCreated' */
         entry_ex->entry.created_by.time = ldb_msg_find_krb5time_ldap_time(msg, "whenCreated", 0);
         /* use 'kadmin' for now (needed by mit_samba) */
-        krb5_make_principal(context,
-                            &entry_ex->entry.created_by.principal,
-                            realm, "kadmin", NULL);
-
-        entry_ex->entry.valid_start = NULL;
-
-        trust_direction_flags = ldb_msg_find_attr_as_int(msg, "trustDirection", 0);
-
-        if (direction == INBOUND) {
-                password_val = ldb_msg_find_ldb_val(msg, "trustAuthIncoming");
-
-        } else { /* OUTBOUND */
-                dnsdomain = ldb_msg_find_attr_as_string(msg, "trustPartner", NULL);
-                /* replace realm */
-                realm = strupper_talloc(mem_ctx, dnsdomain);
-                password_val = ldb_msg_find_ldb_val(msg, "trustAuthOutgoing");
-        }
-
-        if (!password_val || !(trust_direction_flags & direction)) {
-                ret = ENOENT;
-                goto out;
-        }
-
-        ndr_err = ndr_pull_struct_blob(password_val, mem_ctx, &password_blob,
-                                           (ndr_pull_flags_fn_t)ndr_pull_trustAuthInOutBlob);
-        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
-                ret = EINVAL;
-                goto out;
-        }
-
-        entry_ex->entry.kvno = -1;
-        for (i=0; i < password_blob.count; i++) {
-                if (password_blob.current.array[i].AuthType == TRUST_AUTH_TYPE_VERSION) {
-                        entry_ex->entry.kvno = password_blob.current.array[i].AuthInfo.version.version;
-                }
-        }
-
-        for (i=0; i < password_blob.count; i++) {
-                if (password_blob.current.array[i].AuthType == TRUST_AUTH_TYPE_CLEAR) {
-                        password_utf16 = data_blob_const(password_blob.current.array[i].AuthInfo.clear.password,
-                                                         password_blob.current.array[i].AuthInfo.clear.size);
-                        /* In the future, generate all sorts of
-                         * hashes, but for now we can't safely convert
-                         * the random strings windows uses into
-                         * utf8 */
-
-                        /* but as it is utf16 already, we can get the NT password/arcfour-hmac-md5 key */
-                        mdfour(password_hash.hash, password_utf16.data, password_utf16.length);
-                        break;
-                } else if (password_blob.current.array[i].AuthType == TRUST_AUTH_TYPE_NT4OWF) {
-                        password_hash = password_blob.current.array[i].AuthInfo.nt4owf.password;
-                        break;
-                }
-        }
-
-        if (i < password_blob.count) {
-                Key key;
-                /* Must have found a cleartext or MD4 password */
-                entry_ex->entry.keys.val = calloc(1, sizeof(Key));
-
-                key.mkvno = 0;
-                key.salt = NULL; /* No salt for this enc type */
-
-                if (entry_ex->entry.keys.val == NULL) {
-                        ret = ENOMEM;
-                        goto out;
-                }
-
-                ret = krb5_keyblock_init(context,
-                                         ENCTYPE_ARCFOUR_HMAC,
-                                         password_hash.hash, sizeof(password_hash.hash),
-                                         &key.key);
-
-                entry_ex->entry.keys.val[entry_ex->entry.keys.len] = key;
-                entry_ex->entry.keys.len++;
-        }
-
-        entry_ex->entry.principal = malloc(sizeof(*(entry_ex->entry.principal)));
-
-        ret = copy_Principal(principal, entry_ex->entry.principal);
+        ret = smb_krb5_make_principal(context,
+                                      &entry_ex->entry.created_by.principal,
+                                      realm, "kadmin", NULL);
         if (ret) {
                 krb5_clear_error_message(context);
@@ -936 +1093 @@
         }
 
-        /* While we have copied the client principal, tests
-         * show that Win2k3 returns the 'corrected' realm, not
-         * the client-specified realm.  This code attempts to
-         * replace the client principal's realm with the one
-         * we determine from our records */
-
-        krb5_principal_set_realm(context, entry_ex->entry.principal, realm);
-        entry_ex->entry.flags = int2HDBFlags(0);
+        /*
+         * We always need to generate the canonicalized principal
+         * with the values of our database.
+         */
+        ret = smb_krb5_make_principal(context, &entry_ex->entry.principal, realm,
+                                      "krbtgt", krbtgt_realm, NULL);
+        if (ret) {
+                krb5_clear_error_message(context);
+                goto out;
+        }
+        smb_krb5_principal_set_type(context, entry_ex->entry.principal,
+                                    KRB5_NT_SRV_INST);
+
+        entry_ex->entry.valid_start = NULL;
+
+        /* we need to work out if we are going to use the current or
+         * the previous password hash.
+         * We base this on the kvno the client passes in. If the kvno
+         * passed in is equal to the current kvno in our database then
+         * we use the current structure. If it is the current kvno-1,
+         * then we use the previous substrucure.
+         */
+
+        /*
+         * Windows preferrs the previous key for one hour.
+         */
+        tv = timeval_current();
+        if (tv.tv_sec > 3600) {
+                tv.tv_sec -= 3600;
+        }
+        an_hour_ago = timeval_to_nttime(&tv);
+
+        /* first work out the current kvno */
+        current_kvno = 0;
+        for (i=0; i < password_blob.count; i++) {
+                struct AuthenticationInformation *a =
+                        &password_blob.current.array[i];
+
+                if (a->LastUpdateTime <= an_hour_ago) {
+                        preferr_current = true;
+                }
+
+                if (a->AuthType == TRUST_AUTH_TYPE_VERSION) {
+                        current_kvno = a->AuthInfo.version.version;
+                }
+        }
+        if (current_kvno == 0) {
+                previous_kvno = 255;
+        } else {
+                previous_kvno = current_kvno - 1;
+        }
+        for (i=0; i < password_blob.count; i++) {
+                struct AuthenticationInformation *a =
+                        &password_blob.previous.array[i];
+
+                if (a->AuthType == TRUST_AUTH_TYPE_VERSION) {
+                        previous_kvno = a->AuthInfo.version.version;
+                }
+        }
+
+        /* work out whether we will use the previous or current
+           password */
+        if (password_blob.previous.count == 0) {
+                /* there is no previous password */
+                use_previous = false;
+        } else if (!(flags & SDB_F_KVNO_SPECIFIED)) {
+                /*
+                 * If not specified we use the lowest kvno
+                 * for the first hour after an update.
+                 */
+                if (preferr_current) {
+                        use_previous = false;
+                } else if (previous_kvno < current_kvno) {
+                        use_previous = true;
+                } else {
+                        use_previous = false;
+                }
+        } else if (kvno == current_kvno) {
+                /*
+                 * Exact match ...
+                 */
+                use_previous = false;
+        } else if (kvno == previous_kvno) {
+                /*
+                 * Exact match ...
+                 */
+                use_previous = true;
+        } else {
+                /*
+                 * Fallback to the current one for anything else
+                 */
+                use_previous = false;
+        }
+
+        if (use_previous) {
+                auth_array = &password_blob.previous;
+                auth_kvno = &previous_kvno;
+        } else {
+                auth_array = &password_blob.current;
+                auth_kvno = &current_kvno;
+        }
+
+        /* use the kvno the client specified, if available */
+        if (flags & SDB_F_KVNO_SPECIFIED) {
+                entry_ex->entry.kvno = kvno;
+        } else {
+                entry_ex->entry.kvno = *auth_kvno;
+        }
+
+        for (i=0; i < auth_array->count; i++) {
+                if (auth_array->array[i].AuthType == TRUST_AUTH_TYPE_CLEAR) {
+                        bool ok;
+
+                        password_utf16 = data_blob_const(auth_array->array[i].AuthInfo.clear.password,
+                                                         auth_array->array[i].AuthInfo.clear.size);
+                        if (password_utf16.length == 0) {
+                                break;
+                        }
+
+                        if (supported_enctypes & ENC_RC4_HMAC_MD5) {
+                                mdfour(_password_hash.hash, password_utf16.data, password_utf16.length);
+                                if (password_hash == NULL) {
+                                        num_keys += 1;
+                                }
+                                password_hash = &_password_hash;
+                        }
+
+                        if (!(supported_enctypes & (ENC_HMAC_SHA1_96_AES128|ENC_HMAC_SHA1_96_AES256))) {
+                                break;
+                        }
+
+                        ok = convert_string_talloc(mem_ctx,
+                                                   CH_UTF16MUNGED, CH_UTF8,
+                                                   password_utf16.data,
+                                                   password_utf16.length,
+                                                   (void *)&password_utf8.data,
+                                                   &password_utf8.length);
+                        if (!ok) {
+                                krb5_clear_error_message(context);
+                                ret = ENOMEM;
+                                goto out;
+                        }
+
+                        if (supported_enctypes & ENC_HMAC_SHA1_96_AES128) {
+                                num_keys += 1;
+                        }
+                        if (supported_enctypes & ENC_HMAC_SHA1_96_AES256) {
+                                num_keys += 1;
+                        }
+                        break;
+                } else if (auth_array->array[i].AuthType == TRUST_AUTH_TYPE_NT4OWF) {
+                        if (supported_enctypes & ENC_RC4_HMAC_MD5) {
+                                password_hash = &auth_array->array[i].AuthInfo.nt4owf.password;
+                                num_keys += 1;
+                        }
+                }
+        }
+
+        /* Must have found a cleartext or MD4 password */
+        if (num_keys == 0) {
+                DEBUG(1,(__location__ ": no usable key found\n"));
+                krb5_clear_error_message(context);
+                ret = SDB_ERR_NOENTRY;
+                goto out;
+        }
+
+        entry_ex->entry.keys.val = calloc(num_keys, sizeof(struct sdb_key));
+        if (entry_ex->entry.keys.val == NULL) {
+                krb5_clear_error_message(context);
+                ret = ENOMEM;
+                goto out;
+        }
+
+        if (password_utf8.length != 0) {
+                struct sdb_key key = {};
+                krb5_const_principal salt_principal = entry_ex->entry.principal;
+                krb5_data salt;
+                krb5_data cleartext_data;
+
+                cleartext_data.data = discard_const_p(char, password_utf8.data);
+                cleartext_data.length = password_utf8.length;
+
+                ret = smb_krb5_get_pw_salt(context,
+                                           salt_principal,
+                                           &salt);
+                if (ret != 0) {
+                        goto out;
+                }
+
+                if (supported_enctypes & ENC_HMAC_SHA1_96_AES256) {
+                        ret = smb_krb5_create_key_from_string(context,
+                                                              salt_principal,
+                                                              &salt,
+                                                              &cleartext_data,
+                                                              ENCTYPE_AES256_CTS_HMAC_SHA1_96,
+                                                              &key.key);
+                        if (ret != 0) {
+                                kerberos_free_data_contents(context, &salt);
+                                goto out;
+                        }
+
+                        entry_ex->entry.keys.val[entry_ex->entry.keys.len] = key;
+                        entry_ex->entry.keys.len++;
+                }
+
+                if (supported_enctypes & ENC_HMAC_SHA1_96_AES128) {
+                        ret = smb_krb5_create_key_from_string(context,
+                                                              salt_principal,
+                                                              &salt,
+                                                              &cleartext_data,
+                                                              ENCTYPE_AES128_CTS_HMAC_SHA1_96,
+                                                              &key.key);
+                        if (ret != 0) {
+                                kerberos_free_data_contents(context, &salt);
+                                goto out;
+                        }
+
+                        entry_ex->entry.keys.val[entry_ex->entry.keys.len] = key;
+                        entry_ex->entry.keys.len++;
+                }
+
+                kerberos_free_data_contents(context, &salt);
+        }
+
+        if (password_hash != NULL) {
+                struct sdb_key key = {};
+
+                ret = smb_krb5_keyblock_init_contents(context,
+                                                      ENCTYPE_ARCFOUR_HMAC,
+                                                      password_hash->hash,
+                                                      sizeof(password_hash->hash),
+                                                      &key.key);
+                if (ret != 0) {
+                        goto out;
+                }
+
+                entry_ex->entry.keys.val[entry_ex->entry.keys.len] = key;
+                entry_ex->entry.keys.len++;
+        }
+
+        entry_ex->entry.flags = int2SDBFlags(0);
         entry_ex->entry.flags.immutable = 1;
         entry_ex->entry.flags.invalid = 0;
@@ -954 +1344 @@
 
         entry_ex->entry.max_renew = NULL;
-
-        entry_ex->entry.generation = NULL;
 
         entry_ex->entry.etypes = malloc(sizeof(*(entry_ex->entry.etypes)));
@@ -971 +1359 @@
         }
         for (i=0; i < entry_ex->entry.etypes->len; i++) {
-                entry_ex->entry.etypes->val[i] = entry_ex->entry.keys.val[i].key.keytype;
-        }
-
+                entry_ex->entry.etypes->val[i] = KRB5_KEY_TYPE(&entry_ex->entry.keys.val[i].key);
+        }
 
         p->msg = talloc_steal(p, msg);
 
 out:
+        TALLOC_FREE(partner_realm);
+
         if (ret != 0) {
                 /* This doesn't free ent itself, that is for the eventual caller to do */
-                hdb_free_entry(context, entry_ex);
+                sdb_free_entry(entry_ex);
         } else {
                 talloc_steal(kdc_db_ctx, entry_ex->ctx);
@@ -995 +1384 @@
                                         struct ldb_message **pmsg)
 {
-        int lret;
-        krb5_error_code ret;
-        char *filter = NULL;
+        NTSTATUS status;
         const char * const *attrs = trust_attrs;
 
-        struct ldb_result *res = NULL;
-        filter = talloc_asprintf(mem_ctx, "(&(objectClass=trustedDomain)(|(flatname=%s)(trustPartner=%s)))", realm, realm);
-
-        if (!filter) {
-                ret = ENOMEM;
-                krb5_set_error_message(context, ret, "talloc_asprintf: out of memory");
+        status = dsdb_trust_search_tdo(ldb_ctx, realm, realm,
+                                       attrs, mem_ctx, pmsg);
+        if (NT_STATUS_IS_OK(status)) {
+                return 0;
+        } else if (NT_STATUS_EQUAL(status, NT_STATUS_OBJECT_NAME_NOT_FOUND)) {
+                return SDB_ERR_NOENTRY;
+        } else if (NT_STATUS_EQUAL(status, NT_STATUS_NO_MEMORY)) {
+                int ret = ENOMEM;
+                krb5_set_error_message(context, ret, "get_sam_result_trust: out of memory");
                 return ret;
-        }
-
-        lret = ldb_search(ldb_ctx, mem_ctx, &res,
-                          ldb_get_default_basedn(ldb_ctx),
-                          LDB_SCOPE_SUBTREE, attrs, "%s", filter);
-        if (lret != LDB_SUCCESS) {
-                DEBUG(3, ("Failed to search for %s: %s\n", filter, ldb_errstring(ldb_ctx)));
-                return HDB_ERR_NOENTRY;
-        } else if (res->count == 0 || res->count > 1) {
-                DEBUG(3, ("Failed find a single entry for %s: got %d\n", filter, res->count));
-                talloc_free(res);
-                return HDB_ERR_NOENTRY;
-        }
-        talloc_steal(mem_ctx, res->msgs);
-        *pmsg = res->msgs[0];
-        talloc_free(res);
-        return 0;
+        } else {
+                int ret = EINVAL;
+                krb5_set_error_message(context, ret, "get_sam_result_trust: %s", nt_errstr(status));
+                return ret;
+        }
 }
 
@@ -1032 +1410 @@
                                                 const char **attrs,
                                                 struct ldb_dn **realm_dn,
-                                                struct ldb_message **msg) {
+                                                struct ldb_message **msg)
+{
         NTSTATUS nt_status;
-        char *principal_string;
-        krb5_error_code ret;
-
-        ret = krb5_unparse_name(context, principal, &principal_string);
-
-        if (ret != 0) {
-                return ret;
+        char *principal_string = NULL;
+
+        if (smb_krb5_principal_get_type(context, principal) == KRB5_NT_ENTERPRISE_PRINCIPAL) {
+                principal_string = smb_krb5_principal_get_comp_string(mem_ctx, context,
+                                                                      principal, 0);
+                if (principal_string == NULL) {
+                        return ENOMEM;
+                }
+        } else {
+                char *principal_string_m = NULL;
+                krb5_error_code ret;
+
+                ret = krb5_unparse_name(context, principal, &principal_string_m);
+                if (ret != 0) {
+                        return ret;
+                }
+
+                principal_string = talloc_strdup(mem_ctx, principal_string_m);
+                SAFE_FREE(principal_string_m);
+                if (principal_string == NULL) {
+                        return ENOMEM;
+                }
         }
 
@@ -1046 +1440 @@
                                               mem_ctx, principal_string, attrs,
                                               realm_dn, msg);
-        free(principal_string);
         if (NT_STATUS_EQUAL(nt_status, NT_STATUS_NO_SUCH_USER)) {
-                return HDB_ERR_NOENTRY;
+                krb5_principal fallback_principal = NULL;
+                unsigned int num_comp;
+                char *fallback_realm = NULL;
+                char *fallback_account = NULL;
+                krb5_error_code ret;
+
+                ret = krb5_parse_name(context, principal_string,
+                                      &fallback_principal);
+                TALLOC_FREE(principal_string);
+                if (ret != 0) {
+                        return ret;
+                }
+
+                num_comp = krb5_princ_size(context, fallback_principal);
+                fallback_realm = smb_krb5_principal_get_realm(context,
+                                                              fallback_principal);
+                if (fallback_realm == NULL) {
+                        krb5_free_principal(context, fallback_principal);
+                        return ENOMEM;
+                }
+
+                if (num_comp == 1) {
+                        size_t len;
+
+                        fallback_account = smb_krb5_principal_get_comp_string(mem_ctx,
+                                                context, fallback_principal, 0);
+                        if (fallback_account == NULL) {
+                                krb5_free_principal(context, fallback_principal);
+                                SAFE_FREE(fallback_realm);
+                                return ENOMEM;
+                        }
+
+                        len = strlen(fallback_account);
+                        if (len >= 2 && fallback_account[len - 1] == '$') {
+                                TALLOC_FREE(fallback_account);
+                        }
+                }
+                krb5_free_principal(context, fallback_principal);
+                fallback_principal = NULL;
+
+                if (fallback_account != NULL) {
+                        char *with_dollar;
+
+                        with_dollar = talloc_asprintf(mem_ctx, "%s$",
+                                                     fallback_account);
+                        if (with_dollar == NULL) {
+                                SAFE_FREE(fallback_realm);
+                                return ENOMEM;
+                        }
+                        TALLOC_FREE(fallback_account);
+
+                        ret = smb_krb5_make_principal(context,
+                                                      &fallback_principal,
+                                                      fallback_realm,
+                                                      with_dollar, NULL);
+                        TALLOC_FREE(with_dollar);
+                        if (ret != 0) {
+                                SAFE_FREE(fallback_realm);
+                                return ret;
+                        }
+                }
+                SAFE_FREE(fallback_realm);
+
+                if (fallback_principal != NULL) {
+                        char *fallback_string = NULL;
+
+                        ret = krb5_unparse_name(context,
+                                                fallback_principal,
+                                                &fallback_string);
+                        if (ret != 0) {
+                                krb5_free_principal(context, fallback_principal);
+                                return ret;
+                        }
+
+                        nt_status = sam_get_results_principal(kdc_db_ctx->samdb,
+                                                              mem_ctx,
+                                                              fallback_string,
+                                                              attrs,
+                                                              realm_dn, msg);
+                        SAFE_FREE(fallback_string);
+                }
+                krb5_free_principal(context, fallback_principal);
+                fallback_principal = NULL;
+        }
+        TALLOC_FREE(principal_string);
+
+        if (NT_STATUS_EQUAL(nt_status, NT_STATUS_NO_SUCH_USER)) {
+                return SDB_ERR_NOENTRY;
         } else if (NT_STATUS_EQUAL(nt_status, NT_STATUS_NO_MEMORY)) {
                 return ENOMEM;
@@ -1055 +1535 @@
         }
 
-        return ret;
+        return 0;
 }
 
@@ -1063 +1543 @@
                                                krb5_const_principal principal,
                                                unsigned flags,
-                                               hdb_entry_ex *entry_ex) {
+                                               struct sdb_entry_ex *entry_ex) {
         struct ldb_dn *realm_dn;
         krb5_error_code ret;
@@ -1069 +1549 @@
 
         ret = samba_kdc_lookup_client(context, kdc_db_ctx,
-                                       mem_ctx, principal, user_attrs,
-                                       &realm_dn, &msg);
+                                      mem_ctx, principal, user_attrs,
+                                      &realm_dn, &msg);
         if (ret != 0) {
                 return ret;
@@ -1087 +1567 @@
                                               krb5_const_principal principal,
                                               unsigned flags,
-                                              uint32_t krbtgt_number,
-                                              hdb_entry_ex *entry_ex)
+                                              uint32_t kvno,
+                                              struct sdb_entry_ex *entry_ex)
 {
         struct loadparm_context *lp_ctx = kdc_db_ctx->lp_ctx;
@@ -1094 +1574 @@
         struct ldb_message *msg = NULL;
         struct ldb_dn *realm_dn = ldb_get_default_basedn(kdc_db_ctx->samdb);
-
-        krb5_principal alloc_principal = NULL;
-        if (principal->name.name_string.len != 2
-            || (strcmp(principal->name.name_string.val[0], KRB5_TGS_NAME) != 0)) {
+        char *realm_from_princ, *realm_from_princ_malloc;
+        char *realm_princ_comp = smb_krb5_principal_get_comp_string(mem_ctx, context, principal, 1);
+
+        realm_from_princ_malloc = smb_krb5_principal_get_realm(context, principal);
+        if (realm_from_princ_malloc == NULL) {
+                /* can't happen */
+                return SDB_ERR_NOENTRY;
+        }
+        realm_from_princ = talloc_strdup(mem_ctx, realm_from_princ_malloc);
+        free(realm_from_princ_malloc);
+        if (realm_from_princ == NULL) {
+                return SDB_ERR_NOENTRY;
+        }
+
+        if (krb5_princ_size(context, principal) != 2
+            || (principal_comp_strcmp(context, principal, 0, KRB5_TGS_NAME) != 0)) {
                 /* Not a krbtgt */
-                return HDB_ERR_NOENTRY;
+                return SDB_ERR_NOENTRY;
         }
 
         /* krbtgt case.  Either us or a trusted realm */
 
-        if (lpcfg_is_my_domain_or_realm(lp_ctx, principal->realm)
-            && lpcfg_is_my_domain_or_realm(lp_ctx, principal->name.name_string.val[1])) {
+        if (lpcfg_is_my_domain_or_realm(lp_ctx, realm_from_princ)
+            && lpcfg_is_my_domain_or_realm(lp_ctx, realm_princ_comp)) {
                 /* us, or someone quite like us */
                 /* Cludge, cludge cludge.  If the realm part of krbtgt/realm,
@@ -1112 +1604 @@
 
                 int lret;
+                unsigned int krbtgt_number;
+                /* w2k8r2 sometimes gives us a kvno of 255 for inter-domain
+                   trust tickets. We don't yet know what this means, but we do
+                   seem to need to treat it as unspecified */
+                if (flags & SDB_F_KVNO_SPECIFIED) {
+                        krbtgt_number = SAMBA_KVNO_GET_KRBTGT(kvno);
+                        if (kdc_db_ctx->rodc) {
+                                if (krbtgt_number != kdc_db_ctx->my_krbtgt_number) {
+                                        return SDB_ERR_NOT_FOUND_HERE;
+                                }
+                        }
+                } else {
+                        krbtgt_number = kdc_db_ctx->my_krbtgt_number;
+                }
 
                 if (krbtgt_number == kdc_db_ctx->my_krbtgt_number) {
                         lret = dsdb_search_one(kdc_db_ctx->samdb, mem_ctx,
                                                &msg, kdc_db_ctx->krbtgt_dn, LDB_SCOPE_BASE,
-                                               krbtgt_attrs, 0,
+                                               krbtgt_attrs, DSDB_SEARCH_NO_GLOBAL_CATALOG,
                                                "(objectClass=user)");
                 } else {
@@ -1125 +1631 @@
                                                &msg, realm_dn, LDB_SCOPE_SUBTREE,
                                                krbtgt_attrs,
-                                               DSDB_SEARCH_SHOW_EXTENDED_DN,
+                                               DSDB_SEARCH_SHOW_EXTENDED_DN | DSDB_SEARCH_NO_GLOBAL_CATALOG,
                                                "(&(objectClass=user)(msDS-SecondaryKrbTgtNumber=%u))", (unsigned)(krbtgt_number));
                 }
@@ -1132 +1638 @@
                         krb5_warnx(context, "samba_kdc_fetch: could not find KRBTGT number %u in DB!",
                                    (unsigned)(krbtgt_number));
-                        krb5_set_error_message(context, HDB_ERR_NOENTRY,
+                        krb5_set_error_message(context, SDB_ERR_NOENTRY,
                                                "samba_kdc_fetch: could not find KRBTGT number %u in DB!",
                                                (unsigned)(krbtgt_number));
-                        return HDB_ERR_NOENTRY;
+                        return SDB_ERR_NOENTRY;
                 } else if (lret != LDB_SUCCESS) {
                         krb5_warnx(context, "samba_kdc_fetch: could not find KRBTGT number %u in DB!",
                                    (unsigned)(krbtgt_number));
-                        krb5_set_error_message(context, HDB_ERR_NOENTRY,
+                        krb5_set_error_message(context, SDB_ERR_NOENTRY,
                                                "samba_kdc_fetch: could not find KRBTGT number %u in DB!",
                                                (unsigned)(krbtgt_number));
-                        return HDB_ERR_NOENTRY;
-                }
-
-                if (flags & HDB_F_CANON) {
-                        ret = krb5_copy_principal(context, principal, &alloc_principal);
-                        if (ret) {
-                                return ret;
-                        }
-
-                        /* When requested to do so, ensure that the
-                         * both realm values in the principal are set
-                         * to the upper case, canonical realm */
-                        free(alloc_principal->name.name_string.val[1]);
-                        alloc_principal->name.name_string.val[1] = strdup(lpcfg_realm(lp_ctx));
-                        if (!alloc_principal->name.name_string.val[1]) {
-                                ret = ENOMEM;
-                                krb5_set_error_message(context, ret, "samba_kdc_fetch: strdup() failed!");
-                                return ret;
-                        }
-                        principal = alloc_principal;
+                        return SDB_ERR_NOENTRY;
                 }
 
@@ -1167 +1654 @@
                                               principal, SAMBA_KDC_ENT_TYPE_KRBTGT,
                                               flags, realm_dn, msg, entry_ex);
-                if (flags & HDB_F_CANON) {
-                        /* This is again copied in the message2entry call */
-                        krb5_free_principal(context, alloc_principal);
-                }
                 if (ret != 0) {
                         krb5_warnx(context, "samba_kdc_fetch: self krbtgt message2entry failed");
@@ -1182 +1665 @@
                 /* Either an inbound or outbound trust */
 
-                if (strcasecmp(lpcfg_realm(lp_ctx), principal->realm) == 0) {
+                if (strcasecmp(lpcfg_realm(lp_ctx), realm_from_princ) == 0) {
                         /* look for inbound trust */
                         direction = INBOUND;
-                        realm = principal->name.name_string.val[1];
-                } else if (strcasecmp(lpcfg_realm(lp_ctx), principal->name.name_string.val[1]) == 0) {
+                        realm = realm_princ_comp;
+                } else if (principal_comp_strcasecmp(context, principal, 1, lpcfg_realm(lp_ctx)) == 0) {
                         /* look for outbound trust */
                         direction = OUTBOUND;
-                        realm = principal->realm;
+                        realm = realm_from_princ;
                 } else {
                         krb5_warnx(context, "samba_kdc_fetch: not our realm for trusts ('%s', '%s')",
-                                   principal->realm, principal->name.name_string.val[1]);
-                        krb5_set_error_message(context, HDB_ERR_NOENTRY, "samba_kdc_fetch: not our realm for trusts ('%s', '%s')",
-                                               principal->realm, principal->name.name_string.val[1]);
-                        return HDB_ERR_NOENTRY;
+                                   realm_from_princ,
+                                   realm_princ_comp);
+                        krb5_set_error_message(context, SDB_ERR_NOENTRY, "samba_kdc_fetch: not our realm for trusts ('%s', '%s')",
+                                               realm_from_princ,
+                                               realm_princ_comp);
+                        return SDB_ERR_NOENTRY;
                 }
 
@@ -1211 +1696 @@
 
                 ret = samba_kdc_trust_message2entry(context, kdc_db_ctx, mem_ctx,
-                                              principal, direction,
-                                              realm_dn, msg, entry_ex);
+                                                    principal, direction,
+                                                    realm_dn, flags, kvno, msg, entry_ex);
                 if (ret != 0) {
-                        krb5_warnx(context, "samba_kdc_fetch: trust_message2entry failed");
+                        krb5_warnx(context, "samba_kdc_fetch: trust_message2entry failed for %s",
+                                   ldb_dn_get_linearized(msg->dn));
+                        krb5_set_error_message(context, ret, "samba_kdc_fetch: "
+                                               "trust_message2entry failed for %s",
+                                               ldb_dn_get_linearized(msg->dn));
                 }
                 return ret;
@@ -1222 +1711 @@
 
 static krb5_error_code samba_kdc_lookup_server(krb5_context context,
-                                                struct samba_kdc_db_context *kdc_db_ctx,
-                                                TALLOC_CTX *mem_ctx,
-                                                krb5_const_principal principal,
-                                                const char **attrs,
-                                                struct ldb_dn **realm_dn,
-                                                struct ldb_message **msg)
+                                               struct samba_kdc_db_context *kdc_db_ctx,
+                                               TALLOC_CTX *mem_ctx,
+                                               krb5_const_principal principal,
+                                               unsigned flags,
+                                               const char **attrs,
+                                               struct ldb_dn **realm_dn,
+                                               struct ldb_message **msg)
 {
         krb5_error_code ret;
-        if (principal->name.name_string.len >= 2) {
+        if ((smb_krb5_principal_get_type(context, principal) != KRB5_NT_ENTERPRISE_PRINCIPAL)
+            && krb5_princ_size(context, principal) >= 2) {
                 /* 'normal server' case */
                 int ldb_ret;
@@ -1253 +1744 @@
 
                 if (!NT_STATUS_IS_OK(nt_status)) {
-                        return HDB_ERR_NOENTRY;
+                        return SDB_ERR_NOENTRY;
                 }
 
@@ -1259 +1750 @@
                                           mem_ctx,
                                           msg, user_dn, LDB_SCOPE_BASE,
-                                          attrs, DSDB_SEARCH_SHOW_EXTENDED_DN, "(objectClass=*)");
+                                          attrs,
+                                          DSDB_SEARCH_SHOW_EXTENDED_DN | DSDB_SEARCH_NO_GLOBAL_CATALOG,
+                                          "(objectClass=*)");
                 if (ldb_ret != LDB_SUCCESS) {
-                        return HDB_ERR_NOENTRY;
-                }
-
+                        return SDB_ERR_NOENTRY;
+                }
+                return 0;
+        } else if (!(flags & SDB_F_FOR_AS_REQ)
+                   && smb_krb5_principal_get_type(context, principal) == KRB5_NT_ENTERPRISE_PRINCIPAL) {
+                /*
+                 * The behaviour of accepting an
+                 * KRB5_NT_ENTERPRISE_PRINCIPAL server principal
+                 * containing a UPN only applies to TGS-REQ packets,
+                 * not AS-REQ packets.
+                 */
+                return samba_kdc_lookup_client(context, kdc_db_ctx,
+                                               mem_ctx, principal, attrs,
+                                               realm_dn, msg);
         } else {
+                /*
+                 * This case is for:
+                 *  - the AS-REQ, where we only accept
+                 *    samAccountName based lookups for the server, no
+                 *    matter if the name is an
+                 *    KRB5_NT_ENTERPRISE_PRINCIPAL or not
+                 *  - for the TGS-REQ when we are not given an
+                 *    KRB5_NT_ENTERPRISE_PRINCIPAL, which also must
+                 *    only lookup samAccountName based names.
+                 */
                 int lret;
+                char *short_princ;
+                krb5_principal enterprise_principal = NULL;
+                krb5_const_principal used_principal = NULL;
+                char *name1 = NULL;
+                size_t len1 = 0;
                 char *filter = NULL;
-                char *short_princ;
-                const char *realm;
+
+                if (smb_krb5_principal_get_type(context, principal) == KRB5_NT_ENTERPRISE_PRINCIPAL) {
+                        char *str = NULL;
+                        /* Need to reparse the enterprise principal to find the real target */
+                        if (krb5_princ_size(context, principal) != 1) {
+                                ret = KRB5_PARSE_MALFORMED;
+                                krb5_set_error_message(context, ret, "samba_kdc_lookup_server: request for an "
+                                                       "enterprise principal with wrong (%d) number of components",
+                                                       krb5_princ_size(context, principal));
+                                return ret;
+                        }
+                        str = smb_krb5_principal_get_comp_string(mem_ctx, context, principal, 0);
+                        if (str == NULL) {
+                                return KRB5_PARSE_MALFORMED;
+                        }
+                        ret = krb5_parse_name(context, str,
+                                              &enterprise_principal);
+                        talloc_free(str);
+                        if (ret) {
+                                return ret;
+                        }
+                        used_principal = enterprise_principal;
+                } else {
+                        used_principal = principal;
+                }
+
                 /* server as client principal case, but we must not lookup userPrincipalNames */
                 *realm_dn = ldb_get_default_basedn(kdc_db_ctx->samdb);
-                realm = krb5_principal_get_realm(context, principal);
-
-                /* TODO: Check if it is our realm, otherwise give referall */
-
-                ret = krb5_unparse_name_flags(context, principal,  KRB5_PRINCIPAL_UNPARSE_NO_REALM, &short_princ);
+
+                /* TODO: Check if it is our realm, otherwise give referral */
+
+                ret = krb5_unparse_name_flags(context, used_principal,
+                                              KRB5_PRINCIPAL_UNPARSE_NO_REALM |
+                                              KRB5_PRINCIPAL_UNPARSE_DISPLAY,
+                                              &short_princ);
+                used_principal = NULL;
+                krb5_free_principal(context, enterprise_principal);
+                enterprise_principal = NULL;
 
                 if (ret != 0) {
@@ -1283 +1831 @@
                 }
 
+                name1 = ldb_binary_encode_string(mem_ctx, short_princ);
+                SAFE_FREE(short_princ);
+                if (name1 == NULL) {
+                        return ENOMEM;
+                }
+                len1 = strlen(name1);
+                if (len1 >= 1 && name1[len1 - 1] != '$') {
+                        filter = talloc_asprintf(mem_ctx,
+                                        "(&(objectClass=user)(|(samAccountName=%s)(samAccountName=%s$)))",
+                                        name1, name1);
+                        if (filter == NULL) {
+                                return ENOMEM;
+                        }
+                } else {
+                        filter = talloc_asprintf(mem_ctx,
+                                        "(&(objectClass=user)(samAccountName=%s))",
+                                        name1);
+                        if (filter == NULL) {
+                                return ENOMEM;
+                        }
+                }
+
                 lret = dsdb_search_one(kdc_db_ctx->samdb, mem_ctx, msg,
                                        *realm_dn, LDB_SCOPE_SUBTREE,
                                        attrs,
-                                       DSDB_SEARCH_SHOW_EXTENDED_DN,
-                                       "(&(objectClass=user)(samAccountName=%s))",
-                                       ldb_binary_encode_string(mem_ctx, short_princ));
-                free(short_princ);
+                                       DSDB_SEARCH_SHOW_EXTENDED_DN | DSDB_SEARCH_NO_GLOBAL_CATALOG,
+                                       "%s", filter);
                 if (lret == LDB_ERR_NO_SUCH_OBJECT) {
-                        DEBUG(3, ("Failed find a entry for %s\n", filter));
-                        return HDB_ERR_NOENTRY;
+                        DEBUG(10, ("Failed to find an entry for %s filter:%s\n",
+                                  name1, filter));
+                        return SDB_ERR_NOENTRY;
+                }
+                if (lret == LDB_ERR_CONSTRAINT_VIOLATION) {
+                        DEBUG(10, ("Failed to find unique entry for %s filter:%s\n",
+                                  name1, filter));
+                        return SDB_ERR_NOENTRY;
                 }
                 if (lret != LDB_SUCCESS) {
-                        DEBUG(3, ("Failed single search for for %s - %s\n",
-                                  filter, ldb_errstring(kdc_db_ctx->samdb)));
-                        return HDB_ERR_NOENTRY;
-                }
-        }
-
-        return 0;
+                        DEBUG(0, ("Failed single search for %s - %s\n",
+                                  name1, ldb_errstring(kdc_db_ctx->samdb)));
+                        return SDB_ERR_NOENTRY;
+                }
+                return 0;
+        }
+        return SDB_ERR_NOENTRY;
 }
+
+
 
 static krb5_error_code samba_kdc_fetch_server(krb5_context context,
@@ -1309 +1885 @@
                                               krb5_const_principal principal,
                                               unsigned flags,
-                                              hdb_entry_ex *entry_ex)
+                                              struct sdb_entry_ex *entry_ex)
 {
         krb5_error_code ret;
@@ -1316 +1892 @@
 
         ret = samba_kdc_lookup_server(context, kdc_db_ctx, mem_ctx, principal,
-                                       server_attrs, &realm_dn, &msg);
+                                      flags, server_attrs, &realm_dn, &msg);
         if (ret != 0) {
                 return ret;
@@ -1332 +1908 @@
 }
 
+static krb5_error_code samba_kdc_lookup_realm(krb5_context context,
+                                              struct samba_kdc_db_context *kdc_db_ctx,
+                                              TALLOC_CTX *mem_ctx,
+                                              krb5_const_principal principal,
+                                              unsigned flags,
+                                              struct sdb_entry_ex *entry_ex)
+{
+        TALLOC_CTX *frame = talloc_stackframe();
+        NTSTATUS status;
+        krb5_error_code ret;
+        char *_realm = NULL;
+        bool check_realm = false;
+        const char *realm = NULL;
+        struct dsdb_trust_routing_table *trt = NULL;
+        const struct lsa_TrustDomainInfoInfoEx *tdo = NULL;
+        unsigned int num_comp;
+        bool ok;
+        char *upper = NULL;
+
+        num_comp = krb5_princ_size(context, principal);
+
+        if (flags & SDB_F_GET_CLIENT) {
+                if (flags & SDB_F_FOR_AS_REQ) {
+                        check_realm = true;
+                }
+        }
+        if (flags & SDB_F_GET_SERVER) {
+                if (flags & SDB_F_FOR_TGS_REQ) {
+                        check_realm = true;
+                }
+        }
+
+        if (!check_realm) {
+                TALLOC_FREE(frame);
+                return 0;
+        }
+
+        _realm = smb_krb5_principal_get_realm(context, principal);
+        if (_realm == NULL) {
+                TALLOC_FREE(frame);
+                return ENOMEM;
+        }
+
+        /*
+         * The requested realm needs to be our own
+         */
+        ok = lpcfg_is_my_domain_or_realm(kdc_db_ctx->lp_ctx, _realm);
+        if (!ok) {
+                /*
+                 * The request is not for us...
+                 */
+                SAFE_FREE(_realm);
+                TALLOC_FREE(frame);
+                return SDB_ERR_NOENTRY;
+        }
+
+        realm = talloc_strdup(frame, _realm);
+        SAFE_FREE(_realm);
+        if (realm == NULL) {
+                TALLOC_FREE(frame);
+                return ENOMEM;
+        }
+
+        if (smb_krb5_principal_get_type(context, principal) == KRB5_NT_ENTERPRISE_PRINCIPAL) {
+                char *principal_string = NULL;
+                krb5_principal enterprise_principal = NULL;
+                char *enterprise_realm = NULL;
+
+                if (num_comp != 1) {
+                        TALLOC_FREE(frame);
+                        return SDB_ERR_NOENTRY;
+                }
+
+                principal_string = smb_krb5_principal_get_comp_string(frame, context,
+                                                                      principal, 0);
+                if (principal_string == NULL) {
+                        TALLOC_FREE(frame);
+                        return ENOMEM;
+                }
+
+                ret = krb5_parse_name(context, principal_string,
+                                      &enterprise_principal);
+                TALLOC_FREE(principal_string);
+                if (ret) {
+                        TALLOC_FREE(frame);
+                        return ret;
+                }
+
+                enterprise_realm = smb_krb5_principal_get_realm(context,
+                                                        enterprise_principal);
+                krb5_free_principal(context, enterprise_principal);
+                if (enterprise_realm != NULL) {
+                        realm = talloc_strdup(frame, enterprise_realm);
+                        SAFE_FREE(enterprise_realm);
+                        if (realm == NULL) {
+                                TALLOC_FREE(frame);
+                                return ENOMEM;
+                        }
+                }
+        }
+
+        if (flags & SDB_F_GET_SERVER) {
+                char *service_realm = NULL;
+
+                ret = principal_comp_strcmp(context, principal, 0, KRB5_TGS_NAME);
+                if (ret == 0) {
+                        /*
+                         * we need to search krbtgt/ locally
+                         */
+                        TALLOC_FREE(frame);
+                        return 0;
+                }
+
+                /*
+                 * We need to check the last component against the routing table.
+                 *
+                 * Note this works only with 2 or 3 component principals, e.g:
+                 *
+                 * servicePrincipalName: ldap/W2K8R2-219.bla.base
+                 * servicePrincipalName: ldap/W2K8R2-219.bla.base/bla.base
+                 * servicePrincipalName: ldap/W2K8R2-219.bla.base/ForestDnsZones.bla.base
+                 * servicePrincipalName: ldap/W2K8R2-219.bla.base/DomainDnsZones.bla.base
+                 */
+
+                if (num_comp == 2 || num_comp == 3) {
+                        service_realm = smb_krb5_principal_get_comp_string(frame,
+                                                                           context,
+                                                                           principal,
+                                                                           num_comp - 1);
+                }
+
+                if (service_realm != NULL) {
+                        realm = service_realm;
+                }
+        }
+
+        ok = lpcfg_is_my_domain_or_realm(kdc_db_ctx->lp_ctx, realm);
+        if (ok) {
+                /*
+                 * skip the expensive routing lookup
+                 */
+                TALLOC_FREE(frame);
+                return 0;
+        }
+
+        status = dsdb_trust_routing_table_load(kdc_db_ctx->samdb,
+                                               frame, &trt);
+        if (!NT_STATUS_IS_OK(status)) {
+                TALLOC_FREE(frame);
+                return EINVAL;
+        }
+
+        tdo = dsdb_trust_routing_by_name(trt, realm);
+        if (tdo == NULL) {
+                /*
+                 * This principal has to be local
+                 */
+                TALLOC_FREE(frame);
+                return 0;
+        }
+
+        if (tdo->trust_attributes & LSA_TRUST_ATTRIBUTE_WITHIN_FOREST) {
+                /*
+                 * TODO: handle the routing within the forest
+                 *
+                 * This should likely be handled in
+                 * samba_kdc_message2entry() in case we're
+                 * a global catalog. We'd need to check
+                 * if realm_dn is our own domain and derive
+                 * the dns domain name from realm_dn and check that
+                 * against the routing table or fallback to
+                 * the tdo we found here.
+                 *
+                 * But for now we don't support multiple domains
+                 * in our forest correctly anyway.
+                 *
+                 * Just search in our local database.
+                 */
+                TALLOC_FREE(frame);
+                return 0;
+        }
+
+        ZERO_STRUCT(entry_ex->entry);
+
+        ret = krb5_copy_principal(context, principal,
+                                  &entry_ex->entry.principal);
+        if (ret) {
+                TALLOC_FREE(frame);
+                return ret;
+        }
+
+        upper = strupper_talloc(frame, tdo->domain_name.string);
+        if (upper == NULL) {
+                TALLOC_FREE(frame);
+                return ENOMEM;
+        }
+
+        ret = smb_krb5_principal_set_realm(context,
+                                           entry_ex->entry.principal,
+                                           upper);
+        if (ret) {
+                TALLOC_FREE(frame);
+                return ret;
+        }
+
+        TALLOC_FREE(frame);
+        return SDB_ERR_WRONG_REALM;
+}
+
 krb5_error_code samba_kdc_fetch(krb5_context context,
                                 struct samba_kdc_db_context *kdc_db_ctx,
@@ -1337 +2122 @@
                                 unsigned flags,
                                 krb5_kvno kvno,
-                                hdb_entry_ex *entry_ex)
+                                struct sdb_entry_ex *entry_ex)
 {
-        krb5_error_code ret = HDB_ERR_NOENTRY;
+        krb5_error_code ret = SDB_ERR_NOENTRY;
         TALLOC_CTX *mem_ctx;
-        unsigned int krbtgt_number;
-        if (flags & HDB_F_KVNO_SPECIFIED) {
-                krbtgt_number = SAMBA_KVNO_GET_KRBTGT(kvno);
-                if (kdc_db_ctx->rodc) {
-                        if (krbtgt_number != kdc_db_ctx->my_krbtgt_number) {
-                                return HDB_ERR_NOT_FOUND_HERE;
-                        }
-                }
-        } else {
-                krbtgt_number = kdc_db_ctx->my_krbtgt_number;
-        }
 
         mem_ctx = talloc_named(kdc_db_ctx, 0, "samba_kdc_fetch context");
@@ -1360 +2134 @@
         }
 
-        if (flags & HDB_F_GET_CLIENT) {
+        ret = samba_kdc_lookup_realm(context, kdc_db_ctx, mem_ctx,
+                                     principal, flags, entry_ex);
+        if (ret != 0) {
+                goto done;
+        }
+
+        ret = SDB_ERR_NOENTRY;
+
+        if (flags & SDB_F_GET_CLIENT) {
                 ret = samba_kdc_fetch_client(context, kdc_db_ctx, mem_ctx, principal, flags, entry_ex);
-                if (ret != HDB_ERR_NOENTRY) goto done;
-        }
-        if (flags & HDB_F_GET_SERVER) {
+                if (ret != SDB_ERR_NOENTRY) goto done;
+        }
+        if (flags & SDB_F_GET_SERVER) {
                 /* krbtgt fits into this situation for trusted realms, and for resolving different versions of our own realm name */
-                ret = samba_kdc_fetch_krbtgt(context, kdc_db_ctx, mem_ctx, principal, flags, krbtgt_number, entry_ex);
-                if (ret != HDB_ERR_NOENTRY) goto done;
+                ret = samba_kdc_fetch_krbtgt(context, kdc_db_ctx, mem_ctx, principal, flags, kvno, entry_ex);
+                if (ret != SDB_ERR_NOENTRY) goto done;
 
                 /* We return 'no entry' if it does not start with krbtgt/, so move to the common case quickly */
                 ret = samba_kdc_fetch_server(context, kdc_db_ctx, mem_ctx, principal, flags, entry_ex);
-                if (ret != HDB_ERR_NOENTRY) goto done;
-        }
-        if (flags & HDB_F_GET_KRBTGT) {
-                ret = samba_kdc_fetch_krbtgt(context, kdc_db_ctx, mem_ctx, principal, flags, krbtgt_number, entry_ex);
-                if (ret != HDB_ERR_NOENTRY) goto done;
+                if (ret != SDB_ERR_NOENTRY) goto done;
+        }
+        if (flags & SDB_F_GET_KRBTGT) {
+                ret = samba_kdc_fetch_krbtgt(context, kdc_db_ctx, mem_ctx, principal, flags, kvno, entry_ex);
+                if (ret != SDB_ERR_NOENTRY) goto done;
         }
 
@@ -1392 +2174 @@
 static krb5_error_code samba_kdc_seq(krb5_context context,
                                      struct samba_kdc_db_context *kdc_db_ctx,
-                                     hdb_entry_ex *entry)
+                                     struct sdb_entry_ex *entry)
 {
         krb5_error_code ret;
         struct samba_kdc_seq *priv = kdc_db_ctx->seq_ctx;
+        const char *realm = lpcfg_realm(kdc_db_ctx->lp_ctx);
+        struct ldb_message *msg = NULL;
+        const char *sAMAccountName = NULL;
+        krb5_principal principal = NULL;
         TALLOC_CTX *mem_ctx;
-        hdb_entry_ex entry_ex;
-        memset(&entry_ex, '\0', sizeof(entry_ex));
 
         if (!priv) {
-                return HDB_ERR_NOENTRY;
+                return SDB_ERR_NOENTRY;
         }
 
@@ -1412 +2196 @@
         }
 
-        if (priv->index < priv->count) {
-                ret = samba_kdc_message2entry(context, kdc_db_ctx, mem_ctx,
-                                              NULL, SAMBA_KDC_ENT_TYPE_ANY,
-                                              HDB_F_ADMIN_DATA|HDB_F_GET_ANY,
-                                              priv->realm_dn, priv->msgs[priv->index++], entry);
-        } else {
-                ret = HDB_ERR_NOENTRY;
+        while (priv->index < priv->count) {
+                msg = priv->msgs[priv->index++];
+
+                sAMAccountName = ldb_msg_find_attr_as_string(msg, "sAMAccountName", NULL);
+                if (sAMAccountName != NULL) {
+                        break;
+                }
+        }
+
+        if (sAMAccountName == NULL) {
+                ret = SDB_ERR_NOENTRY;
+                goto out;
+        }
+
+        ret = smb_krb5_make_principal(context, &principal,
+                                      realm, sAMAccountName, NULL);
+        if (ret != 0) {
+                goto out;
+        }
+
+        ret = samba_kdc_message2entry(context, kdc_db_ctx, mem_ctx,
+                                      principal, SAMBA_KDC_ENT_TYPE_ANY,
+                                      SDB_F_ADMIN_DATA|SDB_F_GET_ANY,
+                                      priv->realm_dn, msg, entry);
+
+out:
+        if (principal != NULL) {
+                krb5_free_principal(context, principal);
         }
 
@@ -1433 +2238 @@
 krb5_error_code samba_kdc_firstkey(krb5_context context,
                                    struct samba_kdc_db_context *kdc_db_ctx,
-                                   hdb_entry_ex *entry)
+                                   struct sdb_entry_ex *entry)
 {
         struct ldb_context *ldb_ctx = kdc_db_ctx->samdb;
@@ -1473 +2278 @@
                 return ret;
         }
-
-        lret = ldb_search(ldb_ctx, priv, &res,
-                          priv->realm_dn, LDB_SCOPE_SUBTREE, user_attrs,
-                          "(objectClass=user)");
+        krb5_free_default_realm(context, realm);
+
+        lret = dsdb_search(ldb_ctx, priv, &res,
+                           priv->realm_dn, LDB_SCOPE_SUBTREE, user_attrs,
+                           DSDB_SEARCH_NO_GLOBAL_CATALOG,
+                           "(objectClass=user)");
 
         if (lret != LDB_SUCCESS) {
                 TALLOC_FREE(priv);
-                return HDB_ERR_NOENTRY;
+                return SDB_ERR_NOENTRY;
         }
 
@@ -1502 +2309 @@
 krb5_error_code samba_kdc_nextkey(krb5_context context,
                                   struct samba_kdc_db_context *kdc_db_ctx,
-                                  hdb_entry_ex *entry)
+                                  struct sdb_entry_ex *entry)
 {
         return samba_kdc_seq(context, kdc_db_ctx, entry);
@@ -1510 +2317 @@
  *
  * This is currently a very nasty hack - allowing only delegation to itself.
- *
- * This is shared between the constrained delegation and S4U2Self code.
  */
 krb5_error_code
-samba_kdc_check_identical_client_and_server(krb5_context context,
-                                            struct samba_kdc_db_context *kdc_db_ctx,
-                                            hdb_entry_ex *entry,
-                                            krb5_const_principal target_principal)
+samba_kdc_check_s4u2self(krb5_context context,
+                         struct samba_kdc_db_context *kdc_db_ctx,
+                         struct samba_kdc_entry *skdc_entry,
+                         krb5_const_principal target_principal)
 {
         krb5_error_code ret;
-        krb5_principal enterprise_prinicpal = NULL;
         struct ldb_dn *realm_dn;
         struct ldb_message *msg;
         struct dom_sid *orig_sid;
         struct dom_sid *target_sid;
-        struct samba_kdc_entry *p = talloc_get_type(entry->ctx, struct samba_kdc_entry);
         const char *delegation_check_attrs[] = {
                 "objectSid", NULL
         };
 
-        TALLOC_CTX *mem_ctx = talloc_named(kdc_db_ctx, 0, "samba_kdc_check_constrained_delegation");
+        TALLOC_CTX *mem_ctx = talloc_named(kdc_db_ctx, 0, "samba_kdc_check_s4u2self");
 
         if (!mem_ctx) {
                 ret = ENOMEM;
-                krb5_set_error_message(context, ret, "samba_kdc_fetch: talloc_named() failed!");
+                krb5_set_error_message(context, ret, "samba_kdc_check_s4u2self: talloc_named() failed!");
                 return ret;
         }
 
-        if (target_principal->name.name_type == KRB5_NT_ENTERPRISE_PRINCIPAL) {
-                /* Need to reparse the enterprise principal to find the real target */
-                if (target_principal->name.name_string.len != 1) {
-                        ret = KRB5_PARSE_MALFORMED;
-                        krb5_set_error_message(context, ret, "samba_kdc_check_constrained_delegation: request for delegation to enterprise principal with wrong (%d) number of components",
-                                               target_principal->name.name_string.len);
-                        talloc_free(mem_ctx);
-                        return ret;
-                }
-                ret = krb5_parse_name(context, target_principal->name.name_string.val[0],
-                                      &enterprise_prinicpal);
-                if (ret) {
-                        talloc_free(mem_ctx);
-                        return ret;
-                }
-                target_principal = enterprise_prinicpal;
-        }
-
         ret = samba_kdc_lookup_server(context, kdc_db_ctx, mem_ctx, target_principal,
-                                       delegation_check_attrs, &realm_dn, &msg);
-
-        krb5_free_principal(context, enterprise_prinicpal);
+                                      SDB_F_GET_CLIENT|SDB_F_GET_SERVER,
+                                      delegation_check_attrs, &realm_dn, &msg);
 
         if (ret != 0) {
@@ -1566 +2350 @@
         }
 
-        orig_sid = samdb_result_dom_sid(mem_ctx, p->msg, "objectSid");
+        orig_sid = samdb_result_dom_sid(mem_ctx, skdc_entry->msg, "objectSid");
         target_sid = samdb_result_dom_sid(mem_ctx, msg, "objectSid");
 
@@ -1589 +2373 @@
 samba_kdc_check_pkinit_ms_upn_match(krb5_context context,
                                     struct samba_kdc_db_context *kdc_db_ctx,
-                                     hdb_entry_ex *entry,
+                                    struct samba_kdc_entry *skdc_entry,
                                      krb5_const_principal certificate_principal)
 {
@@ -1597 +2381 @@
         struct dom_sid *orig_sid;
         struct dom_sid *target_sid;
-        struct samba_kdc_entry *p = talloc_get_type(entry->ctx, struct samba_kdc_entry);
         const char *ms_upn_check_attrs[] = {
                 "objectSid", NULL
@@ -1611 +2394 @@
 
         ret = samba_kdc_lookup_client(context, kdc_db_ctx,
-                                       mem_ctx, certificate_principal,
-                                       ms_upn_check_attrs, &realm_dn, &msg);
+                                      mem_ctx, certificate_principal,
+                                      ms_upn_check_attrs, &realm_dn, &msg);
 
         if (ret != 0) {
@@ -1619 +2402 @@
         }
 
-        orig_sid = samdb_result_dom_sid(mem_ctx, p->msg, "objectSid");
+        orig_sid = samdb_result_dom_sid(mem_ctx, skdc_entry->msg, "objectSid");
         target_sid = samdb_result_dom_sid(mem_ctx, msg, "objectSid");
 
@@ -1627 +2410 @@
         if (!(orig_sid && target_sid && dom_sid_equal(orig_sid, target_sid))) {
                 talloc_free(mem_ctx);
+#ifdef KRB5_KDC_ERR_CLIENT_NAME_MISMATCH /* Heimdal */
                 return KRB5_KDC_ERR_CLIENT_NAME_MISMATCH;
+#elif defined(KRB5KDC_ERR_CLIENT_NAME_MISMATCH) /* MIT */
+                return KRB5KDC_ERR_CLIENT_NAME_MISMATCH;
+#endif
         }
 
         talloc_free(mem_ctx);
         return ret;
+}
+
+/*
+ * Check if a given entry may delegate to this target principal
+ * with S4U2Proxy.
+ */
+krb5_error_code
+samba_kdc_check_s4u2proxy(krb5_context context,
+                          struct samba_kdc_db_context *kdc_db_ctx,
+                          struct samba_kdc_entry *skdc_entry,
+                          krb5_const_principal target_principal)
+{
+        krb5_error_code ret;
+        char *tmp = NULL;
+        const char *client_dn = NULL;
+        const char *target_principal_name = NULL;
+        struct ldb_message_element *el;
+        struct ldb_val val;
+        unsigned int i;
+        bool found = false;
+
+        TALLOC_CTX *mem_ctx = talloc_named(kdc_db_ctx, 0, "samba_kdc_check_s4u2proxy");
+
+        if (!mem_ctx) {
+                ret = ENOMEM;
+                krb5_set_error_message(context, ret,
+                                       "samba_kdc_check_s4u2proxy:"
+                                       " talloc_named() failed!");
+                return ret;
+        }
+
+        client_dn = ldb_dn_get_linearized(skdc_entry->msg->dn);
+        if (!client_dn) {
+                if (errno == 0) {
+                        errno = ENOMEM;
+                }
+                ret = errno;
+                krb5_set_error_message(context, ret,
+                                       "samba_kdc_check_s4u2proxy:"
+                                       " ldb_dn_get_linearized() failed!");
+                return ret;
+        }
+
+        /*
+         * The main heimdal code already checked that the target_principal
+         * belongs to the same realm as the client.
+         *
+         * So we just need the principal without the realm,
+         * as that is what is configured in the "msDS-AllowedToDelegateTo"
+         * attribute.
+         */
+        ret = krb5_unparse_name_flags(context, target_principal,
+                                      KRB5_PRINCIPAL_UNPARSE_NO_REALM, &tmp);
+        if (ret) {
+                talloc_free(mem_ctx);
+                krb5_set_error_message(context, ret,
+                                       "samba_kdc_check_s4u2proxy:"
+                                       " krb5_unparse_name() failed!");
+                return ret;
+        }
+        DEBUG(10,("samba_kdc_check_s4u2proxy: client[%s] for target[%s]\n",
+                 client_dn, tmp));
+
+        target_principal_name = talloc_strdup(mem_ctx, tmp);
+        SAFE_FREE(tmp);
+        if (target_principal_name == NULL) {
+                ret = ENOMEM;
+                krb5_set_error_message(context, ret,
+                                       "samba_kdc_check_s4u2proxy:"
+                                       " talloc_strdup() failed!");
+                return ret;
+        }
+
+        el = ldb_msg_find_element(skdc_entry->msg, "msDS-AllowedToDelegateTo");
+        if (el == NULL) {
+                goto bad_option;
+        }
+
+        val = data_blob_string_const(target_principal_name);
+
+        for (i=0; i<el->num_values; i++) {
+                struct ldb_val *val1 = &val;
+                struct ldb_val *val2 = &el->values[i];
+                int cmp;
+
+                if (val1->length != val2->length) {
+                        continue;
+                }
+
+                cmp = strncasecmp((const char *)val1->data,
+                                  (const char *)val2->data,
+                                  val1->length);
+                if (cmp != 0) {
+                        continue;
+                }
+
+                found = true;
+                break;
+        }
+
+        if (!found) {
+                goto bad_option;
+        }
+
+        DEBUG(10,("samba_kdc_check_s4u2proxy: client[%s] allowed target[%s]\n",
+                 client_dn, tmp));
+        talloc_free(mem_ctx);
+        return 0;
+
+bad_option:
+        krb5_set_error_message(context, ret,
+                               "samba_kdc_check_s4u2proxy: client[%s] "
+                               "not allowed for delegation to target[%s]",
+                               client_dn,
+                               target_principal_name);
+        talloc_free(mem_ctx);
+        return KRB5KDC_ERR_BADOPTION;
 }
 
@@ -1656 +2560 @@
         kdc_db_ctx->lp_ctx = base_ctx->lp_ctx;
 
-        kdc_get_policy(base_ctx->lp_ctx, NULL, &kdc_db_ctx->policy);
+        /* get default kdc policy */
+        lpcfg_default_kdc_policy(base_ctx->lp_ctx,
+                                 &kdc_db_ctx->policy.svc_tkt_lifetime,
+                                 &kdc_db_ctx->policy.usr_tkt_lifetime,
+                                 &kdc_db_ctx->policy.renewal_lifetime);
 
         session_info = system_session(kdc_db_ctx->lp_ctx);
@@ -1667 +2575 @@
                                           base_ctx->lp_ctx, session_info, 0);
         if (kdc_db_ctx->samdb == NULL) {
-                DEBUG(1, ("hdb_samba4_create: Cannot open samdb for KDC backend!"));
+                DEBUG(1, ("samba_kdc_setup_db_ctx: Cannot open samdb for KDC backend!"));
                 talloc_free(kdc_db_ctx);
                 return NT_STATUS_CANT_ACCESS_DOMAIN_INFO;
@@ -1675 +2583 @@
         ldb_ret = samdb_rodc(kdc_db_ctx->samdb, &kdc_db_ctx->rodc);
         if (ldb_ret != LDB_SUCCESS) {
-                DEBUG(1, ("hdb_samba4_create: Cannot determine if we are an RODC in KDC backend: %s\n",
+                DEBUG(1, ("samba_kdc_setup_db_ctx: Cannot determine if we are an RODC in KDC backend: %s\n",
                           ldb_errstring(kdc_db_ctx->samdb)));
                 talloc_free(kdc_db_ctx);
@@ -1686 +2594 @@
                 struct ldb_dn *server_dn = samdb_server_dn(kdc_db_ctx->samdb, kdc_db_ctx);
                 if (!server_dn) {
-                        DEBUG(1, ("hdb_samba4_create: Cannot determine server DN in KDC backend: %s\n",
+                        DEBUG(1, ("samba_kdc_setup_db_ctx: Cannot determine server DN in KDC backend: %s\n",
                                   ldb_errstring(kdc_db_ctx->samdb)));
                         talloc_free(kdc_db_ctx);
@@ -1695 +2603 @@
                                              "serverReference", &account_dn);
                 if (ldb_ret != LDB_SUCCESS) {
-                        DEBUG(1, ("hdb_samba4_create: Cannot determine server account in KDC backend: %s\n",
+                        DEBUG(1, ("samba_kdc_setup_db_ctx: Cannot determine server account in KDC backend: %s\n",
                                   ldb_errstring(kdc_db_ctx->samdb)));
                         talloc_free(kdc_db_ctx);
@@ -1705 +2613 @@
                 talloc_free(account_dn);
                 if (ldb_ret != LDB_SUCCESS) {
-                        DEBUG(1, ("hdb_samba4_create: Cannot determine RODC krbtgt account in KDC backend: %s\n",
+                        DEBUG(1, ("samba_kdc_setup_db_ctx: Cannot determine RODC krbtgt account in KDC backend: %s\n",
                                   ldb_errstring(kdc_db_ctx->samdb)));
                         talloc_free(kdc_db_ctx);
@@ -1714 +2622 @@
                                           &msg, kdc_db_ctx->krbtgt_dn, LDB_SCOPE_BASE,
                                           secondary_keytab,
-                                          0,
+                                          DSDB_SEARCH_NO_GLOBAL_CATALOG,
                                           "(&(objectClass=user)(msDS-SecondaryKrbTgtNumber=*))");
                 if (ldb_ret != LDB_SUCCESS) {
-                        DEBUG(1, ("hdb_samba4_create: Cannot read krbtgt account %s in KDC backend to get msDS-SecondaryKrbTgtNumber: %s: %s\n",
+                        DEBUG(1, ("samba_kdc_setup_db_ctx: Cannot read krbtgt account %s in KDC backend to get msDS-SecondaryKrbTgtNumber: %s: %s\n",
                                   ldb_dn_get_linearized(kdc_db_ctx->krbtgt_dn),
                                   ldb_errstring(kdc_db_ctx->samdb),
@@ -1726 +2634 @@
                 my_krbtgt_number = ldb_msg_find_attr_as_int(msg, "msDS-SecondaryKrbTgtNumber", -1);
                 if (my_krbtgt_number == -1) {
-                        DEBUG(1, ("hdb_samba4_create: Cannot read msDS-SecondaryKrbTgtNumber from krbtgt account %s in KDC backend: got %d\n",
+                        DEBUG(1, ("samba_kdc_setup_db_ctx: Cannot read msDS-SecondaryKrbTgtNumber from krbtgt account %s in KDC backend: got %d\n",
                                   ldb_dn_get_linearized(kdc_db_ctx->krbtgt_dn),
                                   my_krbtgt_number));
@@ -1737 +2645 @@
                 kdc_db_ctx->my_krbtgt_number = 0;
                 ldb_ret = dsdb_search_one(kdc_db_ctx->samdb, kdc_db_ctx,
-                                          &msg, NULL, LDB_SCOPE_SUBTREE,
+                                          &msg,
+                                          ldb_get_default_basedn(kdc_db_ctx->samdb),
+                                          LDB_SCOPE_SUBTREE,
                                           krbtgt_attrs,
-                                          0,
+                                          DSDB_SEARCH_NO_GLOBAL_CATALOG,
                                           "(&(objectClass=user)(samAccountName=krbtgt))");
 

vendor/current/source4/kdc/db-glue.h

@@ -22 +22 @@
 */
 
+struct sdb_entry_ex;
+
 krb5_error_code samba_kdc_fetch(krb5_context context,
                                 struct samba_kdc_db_context *kdc_db_ctx,
@@ -27 +29 @@
                                 unsigned flags,
                                 krb5_kvno kvno,
-                                hdb_entry_ex *entry_ex);
+                                struct sdb_entry_ex *entry_ex);
 
 krb5_error_code samba_kdc_firstkey(krb5_context context,
                                    struct samba_kdc_db_context *kdc_db_ctx,
-                                   hdb_entry_ex *entry);
+                                   struct sdb_entry_ex *entry);
 
 krb5_error_code samba_kdc_nextkey(krb5_context context,
                                   struct samba_kdc_db_context *kdc_db_ctx,
-                                  hdb_entry_ex *entry);
+                                  struct sdb_entry_ex *entry);
 
 krb5_error_code
-samba_kdc_check_identical_client_and_server(krb5_context context,
-                                            struct samba_kdc_db_context *kdc_db_ctx,
-                                            hdb_entry_ex *entry,
-                                            krb5_const_principal target_principal);
+samba_kdc_check_s4u2self(krb5_context context,
+                         struct samba_kdc_db_context *kdc_db_ctx,
+                         struct samba_kdc_entry *skdc_entry,
+                         krb5_const_principal target_principal);
 
 krb5_error_code
 samba_kdc_check_pkinit_ms_upn_match(krb5_context context,
                                     struct samba_kdc_db_context *kdc_db_ctx,
-                                    hdb_entry_ex *entry,
+                                    struct samba_kdc_entry *skdc_entry,
                                     krb5_const_principal certificate_principal);
+
+krb5_error_code
+samba_kdc_check_s4u2proxy(krb5_context context,
+                          struct samba_kdc_db_context *kdc_db_ctx,
+                          struct samba_kdc_entry *skdc_entry,
+                          krb5_const_principal target_principal);
 
 NTSTATUS samba_kdc_setup_db_ctx(TALLOC_CTX *mem_ctx, struct samba_kdc_base_context *base_ctx,

vendor/current/source4/kdc/hdb-samba4.c

@@ -36 +36 @@
 #include "kdc/kdc-glue.h"
 #include "kdc/db-glue.h"
+#include "auth/auth_sam.h"
+#include <ldb.h>
+#include "sdb.h"
+#include "sdb_hdb.h"
 
 static krb5_error_code hdb_samba4_open(krb5_context context, HDB *db, int flags, mode_t mode)
@@ -86 +90 @@
 {
         struct samba_kdc_db_context *kdc_db_ctx;
-
-        kdc_db_ctx = talloc_get_type_abort(db->hdb_db,
-                                           struct samba_kdc_db_context);
-
-        return samba_kdc_fetch(context, kdc_db_ctx, principal, flags, kvno, entry_ex);
+        struct sdb_entry_ex sdb_entry_ex = {};
+        krb5_error_code code, ret;
+
+        kdc_db_ctx = talloc_get_type_abort(db->hdb_db,
+                                           struct samba_kdc_db_context);
+
+        ret = samba_kdc_fetch(context,
+                              kdc_db_ctx,
+                              principal,
+                              flags,
+                              kvno,
+                              &sdb_entry_ex);
+        switch (ret) {
+        case 0:
+                code = 0;
+                break;
+        case SDB_ERR_WRONG_REALM:
+                /*
+                 * If SDB_ERR_WRONG_REALM is returned we need to process the
+                 * sdb_entry to fill the principal in the HDB entry.
+                 */
+                code = HDB_ERR_WRONG_REALM;
+                break;
+        case SDB_ERR_NOENTRY:
+                return HDB_ERR_NOENTRY;
+        default:
+                return HDB_ERR_NOT_FOUND_HERE;
+        }
+
+        ret = sdb_entry_ex_to_hdb_entry_ex(context, &sdb_entry_ex, entry_ex);
+        sdb_free_entry(&sdb_entry_ex);
+
+        if (code != 0 && ret != 0) {
+                code = ret;
+        }
+
+        return code;
 }
 
@@ -97 +133 @@
 {
         struct samba_kdc_db_context *kdc_db_ctx;
-
-        kdc_db_ctx = talloc_get_type_abort(db->hdb_db,
-                                           struct samba_kdc_db_context);
-
-        return samba_kdc_firstkey(context, kdc_db_ctx, entry);
+        struct sdb_entry_ex sdb_entry_ex = {};
+        krb5_error_code ret;
+
+        kdc_db_ctx = talloc_get_type_abort(db->hdb_db,
+                                           struct samba_kdc_db_context);
+
+        ret = samba_kdc_firstkey(context, kdc_db_ctx, &sdb_entry_ex);
+        switch (ret) {
+        case 0:
+                break;
+        case SDB_ERR_WRONG_REALM:
+                return HDB_ERR_WRONG_REALM;
+        case SDB_ERR_NOENTRY:
+                return HDB_ERR_NOENTRY;
+        default:
+                return HDB_ERR_NOT_FOUND_HERE;
+        }
+
+        ret = sdb_entry_ex_to_hdb_entry_ex(context, &sdb_entry_ex, entry);
+        sdb_free_entry(&sdb_entry_ex);
+        return ret;
 }
 
@@ -108 +160 @@
 {
         struct samba_kdc_db_context *kdc_db_ctx;
-
-        kdc_db_ctx = talloc_get_type_abort(db->hdb_db,
-                                           struct samba_kdc_db_context);
-
-        return samba_kdc_nextkey(context, kdc_db_ctx, entry);
+        struct sdb_entry_ex sdb_entry_ex = {};
+        krb5_error_code ret;
+
+        kdc_db_ctx = talloc_get_type_abort(db->hdb_db,
+                                           struct samba_kdc_db_context);
+
+        ret = samba_kdc_nextkey(context, kdc_db_ctx, &sdb_entry_ex);
+        switch (ret) {
+        case 0:
+                break;
+        case SDB_ERR_WRONG_REALM:
+                return HDB_ERR_WRONG_REALM;
+        case SDB_ERR_NOENTRY:
+                return HDB_ERR_NOENTRY;
+        default:
+                return HDB_ERR_NOT_FOUND_HERE;
+        }
+
+        ret = sdb_entry_ex_to_hdb_entry_ex(context, &sdb_entry_ex, entry);
+        sdb_free_entry(&sdb_entry_ex);
+        return ret;
 }
 
@@ -122 +190 @@
 
 static krb5_error_code
-hdb_samba4_check_identical_client_and_server(krb5_context context, HDB *db,
+hdb_samba4_check_constrained_delegation(krb5_context context, HDB *db,
                                         hdb_entry_ex *entry,
                                         krb5_const_principal target_principal)
 {
         struct samba_kdc_db_context *kdc_db_ctx;
-
-        kdc_db_ctx = talloc_get_type_abort(db->hdb_db,
-                                           struct samba_kdc_db_context);
-
-        return samba_kdc_check_identical_client_and_server(context, kdc_db_ctx,
-                                                           entry,
-                                                           target_principal);
+        struct samba_kdc_entry *skdc_entry;
+        krb5_error_code ret;
+
+        kdc_db_ctx = talloc_get_type_abort(db->hdb_db,
+                                           struct samba_kdc_db_context);
+        skdc_entry = talloc_get_type_abort(entry->ctx,
+                                           struct samba_kdc_entry);
+
+        ret = samba_kdc_check_s4u2proxy(context, kdc_db_ctx,
+                                        skdc_entry,
+                                        target_principal);
+        switch (ret) {
+        case 0:
+                break;
+        case SDB_ERR_WRONG_REALM:
+                ret = HDB_ERR_WRONG_REALM;
+                break;
+        case SDB_ERR_NOENTRY:
+                ret = HDB_ERR_NOENTRY;
+                break;
+        default:
+                ret = HDB_ERR_NOT_FOUND_HERE;
+                break;
+        }
+
+        return ret;
 }
 
@@ -142 +229 @@
 {
         struct samba_kdc_db_context *kdc_db_ctx;
-
-        kdc_db_ctx = talloc_get_type_abort(db->hdb_db,
-                                           struct samba_kdc_db_context);
-
-        return samba_kdc_check_pkinit_ms_upn_match(context, kdc_db_ctx,
-                                                   entry,
-                                                   certificate_principal);
+        struct samba_kdc_entry *skdc_entry;
+        krb5_error_code ret;
+
+        kdc_db_ctx = talloc_get_type_abort(db->hdb_db,
+                                           struct samba_kdc_db_context);
+        skdc_entry = talloc_get_type_abort(entry->ctx,
+                                           struct samba_kdc_entry);
+
+        ret = samba_kdc_check_pkinit_ms_upn_match(context, kdc_db_ctx,
+                                                  skdc_entry,
+                                                  certificate_principal);
+        switch (ret) {
+        case 0:
+                break;
+        case SDB_ERR_WRONG_REALM:
+                ret = HDB_ERR_WRONG_REALM;
+                break;
+        case SDB_ERR_NOENTRY:
+                ret = HDB_ERR_NOENTRY;
+                break;
+        default:
+                ret = HDB_ERR_NOT_FOUND_HERE;
+                break;
+        }
+
+        return ret;
+}
+
+static krb5_error_code
+hdb_samba4_check_s4u2self(krb5_context context, HDB *db,
+                          hdb_entry_ex *entry,
+                          krb5_const_principal target_principal)
+{
+        struct samba_kdc_db_context *kdc_db_ctx;
+        struct samba_kdc_entry *skdc_entry;
+        krb5_error_code ret;
+
+        kdc_db_ctx = talloc_get_type_abort(db->hdb_db,
+                                           struct samba_kdc_db_context);
+        skdc_entry = talloc_get_type_abort(entry->ctx,
+                                           struct samba_kdc_entry);
+
+        ret = samba_kdc_check_s4u2self(context, kdc_db_ctx,
+                                       skdc_entry,
+                                       target_principal);
+        switch (ret) {
+        case 0:
+                break;
+        case SDB_ERR_WRONG_REALM:
+                ret = HDB_ERR_WRONG_REALM;
+                break;
+        case SDB_ERR_NOENTRY:
+                ret = HDB_ERR_NOENTRY;
+                break;
+        default:
+                ret = HDB_ERR_NOT_FOUND_HERE;
+                break;
+        }
+
+        return ret;
+}
+
+static krb5_error_code hdb_samba4_auth_status(krb5_context context, HDB *db,
+                                              hdb_entry_ex *entry,
+                                              int hdb_auth_status)
+{
+        struct samba_kdc_db_context *kdc_db_ctx = talloc_get_type_abort(db->hdb_db,
+                                                                        struct samba_kdc_db_context);
+        struct samba_kdc_entry *p = talloc_get_type(entry->ctx, struct samba_kdc_entry);
+
+        struct ldb_dn *domain_dn = ldb_get_default_basedn(kdc_db_ctx->samdb);
+
+        if (hdb_auth_status == HDB_AUTH_WRONG_PASSWORD) {
+                authsam_update_bad_pwd_count(kdc_db_ctx->samdb, p->msg, domain_dn);
+        } else if (hdb_auth_status == HDB_AUTH_SUCCESS) {
+                authsam_logon_success_accounting(kdc_db_ctx->samdb, p->msg,
+                                                 domain_dn, true);
+        }
+        return 0;
 }
 
@@ -162 +321 @@
         NTSTATUS nt_status;
 
+        if (hdb_interface_version != HDB_INTERFACE_VERSION) {
+                krb5_set_error_message(context, EINVAL, "Heimdal HDB interface version mismatch between build-time and run-time libraries!");
+                return NT_STATUS_ERROR_DS_INCOMPATIBLE_VERSION;
+        }
+
         *db = talloc(base_ctx, HDB);
         if (!*db) {
@@ -170 +334 @@
         (*db)->hdb_master_key_set = 0;
         (*db)->hdb_db = NULL;
-        (*db)->hdb_capability_flags = 0;
+        (*db)->hdb_capability_flags = HDB_CAP_F_HANDLE_ENTERPRISE_PRINCIPAL;
 
         nt_status = samba_kdc_setup_db_ctx(*db, base_ctx, &kdc_db_ctx);
@@ -197 +361 @@
         (*db)->hdb_destroy = hdb_samba4_destroy;
 
-        (*db)->hdb_auth_status = NULL;
-        (*db)->hdb_check_constrained_delegation = hdb_samba4_check_identical_client_and_server;
+        (*db)->hdb_auth_status = hdb_samba4_auth_status;
+        (*db)->hdb_check_constrained_delegation = hdb_samba4_check_constrained_delegation;
         (*db)->hdb_check_pkinit_ms_upn_match = hdb_samba4_check_pkinit_ms_upn_match;
-        (*db)->hdb_check_s4u2self = hdb_samba4_check_identical_client_and_server;
+        (*db)->hdb_check_s4u2self = hdb_samba4_check_s4u2self;
 
         return NT_STATUS_OK;
 }
-
-static krb5_error_code hdb_samba4_create(krb5_context context, struct HDB **db, const char *arg)
-{
-        NTSTATUS nt_status;
-        void *ptr;
-        struct samba_kdc_base_context *base_ctx;
-
-        if (sscanf(arg, "&%p", &ptr) != 1) {
-                return EINVAL;
-        }
-        base_ctx = talloc_get_type_abort(ptr, struct samba_kdc_base_context);
-        /* The global kdc_mem_ctx and kdc_lp_ctx, Disgusting, ugly hack, but it means one less private hook */
-        nt_status = hdb_samba4_create_kdc(base_ctx, context, db);
-
-        if (NT_STATUS_IS_OK(nt_status)) {
-                return 0;
-        }
-        return EINVAL;
-}
-
-/* Only used in the hdb-backed keytab code
- * for a keytab of 'samba4&<address>', to find
- * kpasswd's key in the main DB, and to
- * copy all the keys into a file (libnet_keytab_export)
- *
- * The <address> is the string form of a pointer to a talloced struct hdb_samba_context
- */
-struct hdb_method hdb_samba4 = {
-        .interface_version = HDB_INTERFACE_VERSION,
-        .prefix = "samba4",
-        .create = hdb_samba4_create
-};

vendor/current/source4/kdc/kdc-glue.h

@@ -82 +82 @@
                             DATA_BLOB *out);
 
+/* from kdc-glue.c */
+int kdc_check_pac(krb5_context krb5_context,
+                  DATA_BLOB server_sig,
+                  struct PAC_SIGNATURE_DATA *kdc_sig,
+                  hdb_entry_ex *ent);
 #endif

vendor/current/source4/kdc/kdc.c

@@ -33 +33 @@
 #include "param/param.h"
 #include "kdc/kdc-glue.h"
+#include "kdc/pac-glue.h"
 #include "dsdb/samdb/samdb.h"
 #include "auth/session.h"
+#include "libds/common/roles.h"
+
+NTSTATUS server_service_kdc_init(void);
 
 extern struct krb5plugin_windc_ftable windc_plugin_table;
-extern struct hdb_method hdb_samba4;
 
 static NTSTATUS kdc_proxy_unavailable_error(struct kdc_server *kdc,
@@ -616 +619 @@
         struct kdc_udp_call *call = tevent_req_callback_data(subreq,
                                        struct kdc_udp_call);
-        ssize_t ret;
         int sys_errno;
 
-        ret = tdgram_sendto_queue_recv(subreq, &sys_errno);
+        tdgram_sendto_queue_recv(subreq, &sys_errno);
 
         /* We don't care about errors */
@@ -653 +655 @@
                                                 &kdc_socket->local_address);
         if (ret != 0) {
-                status = map_nt_error_from_unix(errno);
+                status = map_nt_error_from_unix_common(errno);
                 return status;
         }
@@ -684 +686 @@
                                      &kdc_udp_socket->dgram);
         if (ret != 0) {
-                status = map_nt_error_from_unix(errno);
+                status = map_nt_error_from_unix_common(errno);
                 DEBUG(0,("Failed to bind to %s:%u UDP - %s\n",
                          address, port, nt_errstr(status)));
@@ -728 +730 @@
         }
 
-        num_interfaces = iface_count(ifaces);
+        num_interfaces = iface_list_count(ifaces);
 
         /* if we are allowing incoming packets from any address, then
            we need to bind to the wildcard address */
         if (!lpcfg_bind_interfaces_only(lp_ctx)) {
-                if (kdc_port) {
-                        status = kdc_add_socket(kdc, model_ops,
-                                                "kdc", "0.0.0.0", kdc_port,
-                                                kdc_process, false);
-                        NT_STATUS_NOT_OK_RETURN(status);
-                }
-
-                if (kpasswd_port) {
-                        status = kdc_add_socket(kdc, model_ops,
-                                                "kpasswd", "0.0.0.0", kpasswd_port,
-                                                kpasswdd_process, false);
-                        NT_STATUS_NOT_OK_RETURN(status);
+                int num_binds = 0;
+                char **wcard = iface_list_wildcard(kdc);
+                NT_STATUS_HAVE_NO_MEMORY(wcard);
+                for (i=0; wcard[i]; i++) {
+                        if (kdc_port) {
+                                status = kdc_add_socket(kdc, model_ops,
+                                                        "kdc", wcard[i], kdc_port,
+                                                        kdc_process, false);
+                                if (NT_STATUS_IS_OK(status)) {
+                                        num_binds++;
+                                }
+                        }
+
+                        if (kpasswd_port) {
+                                status = kdc_add_socket(kdc, model_ops,
+                                                        "kpasswd", wcard[i], kpasswd_port,
+                                                        kpasswdd_process, false);
+                                if (NT_STATUS_IS_OK(status)) {
+                                        num_binds++;
+                                }
+                        }
+                }
+                talloc_free(wcard);
+                if (num_binds == 0) {
+                        return NT_STATUS_INVALID_PARAMETER_MIX;
                 }
                 done_wildcard = true;
@@ -750 +765 @@
 
         for (i=0; i<num_interfaces; i++) {
-                const char *address = talloc_strdup(tmp_ctx, iface_n_ip(ifaces, i));
+                const char *address = talloc_strdup(tmp_ctx, iface_list_n_ip(ifaces, i));
 
                 if (kdc_port) {
@@ -772 +787 @@
 }
 
-
 static NTSTATUS kdc_check_generic_kerberos(struct irpc_message *msg,
                                  struct kdc_check_generic_kerberos *r)
@@ -781 +795 @@
         struct kdc_server *kdc = talloc_get_type(msg->private_data, struct kdc_server);
         enum ndr_err_code ndr_err;
-        krb5_enctype etype;
         int ret;
         hdb_entry_ex ent;
         krb5_principal principal;
-        krb5_keyblock keyblock;
-        Key *key;
 
         /* There is no reply to this request */
@@ -797 +808 @@
         }
 
-        if (pac_validate.MessageType != 3) {
+        if (pac_validate.MessageType != NETLOGON_GENERIC_KRB5_PAC_VALIDATE) {
                 /* We don't implement any other message types - such as certificate validation - yet */
                 return NT_STATUS_INVALID_PARAMETER;
@@ -810 +821 @@
         srv_sig = data_blob_const(pac_validate.ChecksumAndSignature.data,
                                   pac_validate.ChecksumLength);
-
-        if (pac_validate.SignatureType == CKSUMTYPE_HMAC_MD5) {
-                etype = ETYPE_ARCFOUR_HMAC_MD5;
-        } else {
-                ret = krb5_cksumtype_to_enctype(kdc->smb_krb5_context->krb5_context, pac_validate.SignatureType,
-                                                &etype);
-                if (ret != 0) {
-                        return NT_STATUS_LOGON_FAILURE;
-                }
-        }
 
         ret = krb5_make_principal(kdc->smb_krb5_context->krb5_context, &principal,
@@ -844 +845 @@
         }
 
-        ret = hdb_enctype2key(kdc->smb_krb5_context->krb5_context, &ent.entry, etype, &key);
-
-        if (ret != 0) {
-                hdb_free_entry(kdc->smb_krb5_context->krb5_context, &ent);
-                krb5_free_principal(kdc->smb_krb5_context->krb5_context, principal);
-                return NT_STATUS_LOGON_FAILURE;
-        }
-
-        keyblock = key->key;
-
         kdc_sig.type = pac_validate.SignatureType;
         kdc_sig.signature = data_blob_const(&pac_validate.ChecksumAndSignature.data[pac_validate.ChecksumLength],
                                             pac_validate.SignatureLength);
-        ret = check_pac_checksum(msg, srv_sig, &kdc_sig,
-                           kdc->smb_krb5_context->krb5_context, &keyblock);
+
+        ret = kdc_check_pac(kdc->smb_krb5_context->krb5_context, srv_sig, &kdc_sig, &ent);
 
         hdb_free_entry(kdc->smb_krb5_context->krb5_context, &ent);
@@ -889 +880 @@
                 task_server_terminate(task, "kdc: no KDC required in member server configuration", false);
                 return;
-        case ROLE_DOMAIN_CONTROLLER:
+        case ROLE_DOMAIN_PDC:
+        case ROLE_DOMAIN_BDC:
+                task_server_terminate(task, "Cannot start KDC as a 'classic Samba' DC", true);
+                return;
+        case ROLE_ACTIVE_DIRECTORY_DC:
                 /* Yes, we want a KDC */
                 break;
         }
 
-        load_interfaces(task, lpcfg_interfaces(task->lp_ctx), &ifaces);
-
-        if (iface_count(ifaces) == 0) {
+        load_interface_list(task, task->lp_ctx, &ifaces);
+
+        if (iface_list_count(ifaces) == 0) {
                 task_server_terminate(task, "kdc: no network interfaces configured", false);
                 return;
@@ -933 +928 @@
         initialize_krb5_error_table();
 
-        ret = smb_krb5_init_context(kdc, task->event_ctx, task->lp_ctx, &kdc->smb_krb5_context);
+        ret = smb_krb5_init_context(kdc, task->lp_ctx, &kdc->smb_krb5_context);
         if (ret) {
                 DEBUG(1,("kdc_task_init: krb5_init_context failed (%s)\n",
@@ -950 +945 @@
         }
 
-        kdc->config->logf = kdc->smb_krb5_context->logf;
+        kdc->config->logf = (krb5_log_facility *)kdc->smb_krb5_context->pvt_log_data;
         kdc->config->db = talloc(kdc, struct HDB *);
         if (!kdc->config->db) {
@@ -957 +952 @@
         }
         kdc->config->num_db = 1;
+
+        /*
+         * This restores the behavior before
+         * commit 255e3e18e00f717d99f3bc57c8a8895ff624f3c3
+         * s4:heimdal: import lorikeet-heimdal-201107150856
+         * (commit 48936803fae4a2fb362c79365d31f420c917b85b)
+         *
+         * as_use_strongest_session_key,preauth_use_strongest_session_key
+         * and tgs_use_strongest_session_key are input to the
+         * _kdc_find_etype() function. The old bahavior is in
+         * the use_strongest_session_key=FALSE code path.
+         * (The only remaining difference in _kdc_find_etype()
+         *  is the is_preauth parameter.)
+         *
+         * The old behavior in the _kdc_get_preferred_key()
+         * function is use_strongest_server_key=TRUE.
+         */
+        kdc->config->as_use_strongest_session_key = false;
+        kdc->config->preauth_use_strongest_session_key = false;
+        kdc->config->tgs_use_strongest_session_key = false;
+        kdc->config->use_strongest_server_key = true;
 
         /* Register hdb-samba4 hooks for use as a keytab */
@@ -979 +995 @@
         ret = krb5_plugin_register(kdc->smb_krb5_context->krb5_context,
                                    PLUGIN_TYPE_DATA, "hdb",
-                                   &hdb_samba4);
+                                   &hdb_samba4_interface);
         if(ret) {
                 task_server_terminate(task, "kdc: failed to register hdb plugin", true);

vendor/current/source4/kdc/kpasswdd.c

@@ -31 +31 @@
 #include "param/param.h"
 #include "kdc/kdc-glue.h"
+#include "dsdb/common/util.h"
+#include "kdc/kpasswd_glue.h"
 
 /* Return true if there is a valid error packet formed in the error_blob */
@@ -112 +114 @@
                 switch (reject_reason) {
                 case SAM_PWD_CHANGE_PASSWORD_TOO_SHORT:
-                        reject_string = talloc_asprintf(mem_ctx, "Password too short, password must be at least %d characters long",
+                        reject_string = talloc_asprintf(mem_ctx, "Password too short, password must be at least %d characters long.",
                                                         dominfo->min_password_length);
                         break;
@@ -119 +121 @@
                         break;
                 case SAM_PWD_CHANGE_PWD_IN_HISTORY:
-                        reject_string = "Password is already in password history";
+                        reject_string = talloc_asprintf(mem_ctx, "Password is already in password history.  New password must not match any of your %d previous passwords.",
+                                                        dominfo->password_history_length);
                         break;
                 default:
-                        reject_string = talloc_asprintf(mem_ctx, "Password must be at least %d characters long, and cannot match any of your %d previous passwords",
-                                                        dominfo->min_password_length, dominfo->password_history_length);
+                        reject_string = "Password change rejected, password changes may not be permitted on this account, or the minimum password age may not have elapsed.";
                         break;
                 }
@@ -156 +158 @@
 {
         NTSTATUS status;
+        NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
         enum samPwdChangeReason reject_reason;
         struct samr_DomInfo1 *dominfo;
-        struct samr_Password *oldLmHash, *oldNtHash;
-        struct ldb_context *samdb;
-        const char * const attrs[] = { "dBCSPwd", "unicodePwd", NULL };
-        struct ldb_message **res;
-        int ret;
-
-        /* Fetch the old hashes to get the old password in order to perform
-         * the password change operation. Naturally it would be much better to
-         * have a password hash from an authentication around but this doesn't
-         * seem to be the case here. */
-        ret = gendb_search(kdc->samdb, mem_ctx, NULL, &res, attrs,
-                           "(&(objectClass=user)(sAMAccountName=%s))",
-                           session_info->info->account_name);
-        if (ret != 1) {
-                return kpasswdd_make_error_reply(kdc, mem_ctx,
-                                                KRB5_KPASSWD_ACCESSDENIED,
-                                                "No such user when changing password",
-                                                reply);
-        }
-
-        status = samdb_result_passwords(mem_ctx, kdc->task->lp_ctx, res[0],
-                                        &oldLmHash, &oldNtHash);
+        const char *error_string;
+
+        status = samdb_kpasswd_change_password(mem_ctx,
+                                               kdc->task->lp_ctx,
+                                               kdc->task->event_ctx,
+                                               kdc->samdb,
+                                               session_info,
+                                               password,
+                                               &reject_reason,
+                                               &dominfo,
+                                               &error_string,
+                                               &result);
         if (!NT_STATUS_IS_OK(status)) {
-                return kpasswdd_make_error_reply(kdc, mem_ctx,
-                                                KRB5_KPASSWD_ACCESSDENIED,
-                                                "Not permitted to change password",
-                                                reply);
-        }
-
-        /* Start a SAM with user privileges for the password change */
-        samdb = samdb_connect(mem_ctx, kdc->task->event_ctx, kdc->task->lp_ctx,
-                              session_info, 0);
-        if (!samdb) {
-                return kpasswdd_make_error_reply(kdc, mem_ctx,
-                                                KRB5_KPASSWD_HARDERROR,
-                                                "Failed to open samdb",
-                                                reply);
-        }
-
-        DEBUG(3, ("Changing password of %s\\%s (%s)\n",
-                  session_info->info->domain_name,
-                  session_info->info->account_name,
-                  dom_sid_string(mem_ctx, &session_info->security_token->sids[PRIMARY_USER_SID_INDEX])));
-
-        /* Performs the password change */
-        status = samdb_set_password_sid(samdb, mem_ctx,
-                                        &session_info->security_token->sids[PRIMARY_USER_SID_INDEX],
-                                        password, NULL, NULL,
-                                        oldLmHash, oldNtHash, /* this is a user password change */
-                                        &reject_reason,
-                                        &dominfo);
-        return kpasswd_make_pwchange_reply(kdc, mem_ctx,
-                                           status,
+                return kpasswdd_make_error_reply(kdc,
+                                                 mem_ctx,
+                                                 KRB5_KPASSWD_ACCESSDENIED,
+                                                 error_string,
+                                                 reply);
+        }
+
+        return kpasswd_make_pwchange_reply(kdc,
+                                           mem_ctx,
+                                           result,
                                            reject_reason,
                                            dominfo,
                                            reply);
-
 }
 
@@ -228 +200 @@
 
         if (!NT_STATUS_IS_OK(gensec_session_info(gensec_security,
+                                                 mem_ctx,
                                                  &session_info))) {
                 return kpasswdd_make_error_reply(kdc, mem_ctx,
@@ -239 +212 @@
         {
                 DATA_BLOB password;
-                if (!convert_string_talloc_convenience(mem_ctx, lpcfg_iconv_convenience(kdc->task->lp_ctx),
+                if (!convert_string_talloc_handle(mem_ctx, lpcfg_iconv_handle(kdc->task->lp_ctx),
                                                CH_UTF8, CH_UTF16,
                                                (const char *)input->data,
                                                input->length,
-                                               (void **)&password.data, &pw_len, false)) {
+                                               (void **)&password.data, &pw_len)) {
                         return false;
                 }
@@ -279 +252 @@
                 }
 
-                if (!convert_string_talloc_convenience(mem_ctx, lpcfg_iconv_convenience(kdc->task->lp_ctx),
+                if (!convert_string_talloc_handle(mem_ctx, lpcfg_iconv_handle(kdc->task->lp_ctx),
                                                CH_UTF8, CH_UTF16,
                                                (const char *)chpw.newpasswd.data,
                                                chpw.newpasswd.length,
-                                               (void **)&password.data, &pw_len, false)) {
+                                               (void **)&password.data, &pw_len)) {
                         free_ChangePasswdDataMS(&chpw);
                         return false;
@@ -544 +517 @@
          * complex code */
 
-        nt_status = gensec_set_local_address(gensec_security, peer_addr);
+        nt_status = gensec_set_remote_address(gensec_security, peer_addr);
         if (!NT_STATUS_IS_OK(nt_status)) {
                 talloc_free(tmp_ctx);
@@ -567 +540 @@
 
         /* Accept the AP-REQ and generate teh AP-REP we need for the reply */
-        nt_status = gensec_update(gensec_security, tmp_ctx, ap_req, &ap_rep);
+        nt_status = gensec_update_ev(gensec_security, tmp_ctx, kdc->task->event_ctx, ap_req, &ap_rep);
         if (!NT_STATUS_IS_OK(nt_status) && !NT_STATUS_EQUAL(nt_status, NT_STATUS_MORE_PROCESSING_REQUIRED)) {
 

vendor/current/source4/kdc/mit_samba.c

@@ -196 +196 @@
         DATA_BLOB *pac_blob;
         NTSTATUS nt_status;
+        struct samba_kdc_entry *skdc_entry;
+
+        skdc_entry = talloc_get_type_abort(client->ctx,
+                                           struct samba_kdc_entry);
 
         tmp_ctx = talloc_named(ctx, 0, "mit_samba_get_pac_data context");
@@ -202 +206 @@
         }
 
-        nt_status = samba_kdc_get_pac_blob(tmp_ctx, client, &pac_blob);
+        nt_status = samba_kdc_get_pac_blob(tmp_ctx, skdc_entry, &pac_blob);
         if (!NT_STATUS_IS_OK(nt_status)) {
                 talloc_free(tmp_ctx);
@@ -231 +235 @@
         krb5_pac pac = NULL;
         int ret;
+        struct samba_kdc_entry *skdc_entry = NULL;
+
+        if (client) {
+                skdc_entry = talloc_get_type_abort(client->ctx,
+                                                   struct samba_kdc_entry);
+        }
 
         /* The user account may be set not to want the PAC */
-        if (client && !samba_princ_needs_pac(client)) {
+        if (client && !samba_princ_needs_pac(skdc_entry)) {
                 return EINVAL;
         }
@@ -255 +265 @@
         }
 
+        /* TODO: An implementation-specific decision will need to be
+         * made as to when to check the KDC pac signature, and how to
+         * untrust untrusted RODCs */
         nt_status = samba_kdc_update_pac_blob(tmp_ctx, ctx->context,
-                                              &pac, logon_blob);
+                                              pac, logon_blob, NULL, NULL);
         if (!NT_STATUS_IS_OK(nt_status)) {
                 DEBUG(0, ("Building PAC failed: %s\n",
@@ -278 +291 @@
         talloc_free(tmp_ctx);
         return ret;
+}
+
+/* provide header, function is exported but there are no public headers */
+
+krb5_error_code encode_krb5_padata_sequence(krb5_pa_data *const *rep, krb5_data **code);
+
+/* this function allocates 'data' using malloc.
+ * The caller is responsible for freeing it */
+static void samba_kdc_build_edata_reply(NTSTATUS nt_status, DATA_BLOB *e_data)
+{
+        krb5_error_code ret = 0;
+        krb5_pa_data pa, *ppa = NULL;
+        krb5_data *d = NULL;
+
+        if (!e_data)
+                return;
+
+        e_data->data   = NULL;
+        e_data->length = 0;
+
+        pa.magic                = KV5M_PA_DATA;
+        pa.pa_type              = KRB5_PADATA_PW_SALT;
+        pa.length               = 12;
+        pa.contents             = malloc(pa.length);
+        if (!pa.contents) {
+                return;
+        }
+
+        SIVAL(pa.contents, 0, NT_STATUS_V(nt_status));
+        SIVAL(pa.contents, 4, 0);
+        SIVAL(pa.contents, 8, 1);
+
+        ppa = &pa;
+
+        ret = encode_krb5_padata_sequence(&ppa, &d);
+        free(pa.contents);
+        if (ret) {
+                return;
+        }
+
+        e_data->data   = (uint8_t *)d->data;
+        e_data->length = d->length;
+
+        /* free d, not d->data - gd */
+        free(d);
+
+        return;
 }
 
@@ -317 +377 @@
                                      bool is_nt_enterprise_name)
 {
+#if 1
+        /*
+         * This is disabled because mit_samba_update_pac_data() does not handle
+         * S4U_DELEGATION_INFO
+         */
+
+        return KRB5KDC_ERR_BADOPTION;
+#else
         krb5_principal target_principal;
         int flags = 0;
@@ -331 +399 @@
         }
 
-        ret = samba_kdc_check_identical_client_and_server(ctx->context,
-                                                          ctx->db_ctx,
-                                                          entry,
-                                                          target_principal);
+        ret = samba_kdc_check_s4u2proxy(ctx->context,
+                                        ctx->db_ctx,
+                                        skdc_entry,
+                                        target_principal);
 
         krb5_free_principal(ctx->context, target_principal);
 
         return ret;
+#endif
 }
 

vendor/current/source4/kdc/pac-glue.c

@@ -27 +27 @@
 #include "auth/auth.h"
 #include "auth/auth_sam_reply.h"
-#include "kdc/kdc-glue.h"
+#include "system/kerberos.h"
+#include "auth/kerberos/kerberos.h"
+#include "kdc/samba_kdc.h"
+#include "kdc/pac-glue.h"
 #include "param/param.h"
 #include "librpc/gen_ndr/ndr_krb5pac.h"
+#include "libcli/security/security.h"
+#include "dsdb/samdb/samdb.h"
+#include "auth/kerberos/pac_utils.h"
 
 static
@@ -51 +57 @@
 
         pac_info.logon_info.info = talloc_zero(mem_ctx, struct PAC_LOGON_INFO);
-        if (!mem_ctx) {
+        if (!pac_info.logon_info.info) {
                 return NT_STATUS_NO_MEMORY;
         }
@@ -72 +78 @@
 krb5_error_code samba_make_krb5_pac(krb5_context context,
                                     DATA_BLOB *pac_blob,
+                                    DATA_BLOB *deleg_blob,
                                     krb5_pac *pac)
 {
         krb5_data pac_data;
+        krb5_data deleg_data;
         krb5_error_code ret;
 
@@ -82 +90 @@
         }
 
-        ret = krb5_data_copy(&pac_data, pac_blob->data, pac_blob->length);
+        ret = krb5_copy_data_contents(&pac_data,
+                                      pac_blob->data,
+                                      pac_blob->length);
         if (ret != 0) {
                 return ret;
         }
 
+        ZERO_STRUCT(deleg_data);
+        if (deleg_blob) {
+                ret = krb5_copy_data_contents(&deleg_data,
+                                              deleg_blob->data,
+                                              deleg_blob->length);
+                if (ret != 0) {
+                        kerberos_free_data_contents(context, &pac_data);
+                        return ret;
+                }
+        }
+
         ret = krb5_pac_init(context, pac);
         if (ret != 0) {
-                krb5_data_free(&pac_data);
+                kerberos_free_data_contents(context, &pac_data);
+                kerberos_free_data_contents(context, &deleg_data);
                 return ret;
         }
 
         ret = krb5_pac_add_buffer(context, *pac, PAC_TYPE_LOGON_INFO, &pac_data);
-        krb5_data_free(&pac_data);
+        kerberos_free_data_contents(context, &pac_data);
         if (ret != 0) {
+                kerberos_free_data_contents(context, &deleg_data);
                 return ret;
         }
 
+        if (deleg_blob) {
+                ret = krb5_pac_add_buffer(context, *pac,
+                                          PAC_TYPE_CONSTRAINED_DELEGATION,
+                                          &deleg_data);
+                kerberos_free_data_contents(context, &deleg_data);
+                if (ret != 0) {
+                        return ret;
+                }
+        }
+
         return ret;
 }
 
-bool samba_princ_needs_pac(struct hdb_entry_ex *princ)
-{
-
-        struct samba_kdc_entry *p = talloc_get_type(princ->ctx, struct samba_kdc_entry);
+bool samba_princ_needs_pac(struct samba_kdc_entry *skdc_entry)
+{
+
         uint32_t userAccountControl;
 
-
         /* The service account may be set not to want the PAC */
-        userAccountControl = ldb_msg_find_attr_as_uint(p->msg, "userAccountControl", 0);
+        userAccountControl = ldb_msg_find_attr_as_uint(skdc_entry->msg, "userAccountControl", 0);
         if (userAccountControl & UF_NO_AUTH_DATA_REQUIRED) {
                 return false;
@@ -118 +149 @@
 }
 
-/* Was the krbtgt an RODC (and we are not) */
-bool samba_krbtgt_was_untrusted_rodc(struct hdb_entry_ex *princ)
-{
-
-        struct samba_kdc_entry *p = talloc_get_type(princ->ctx, struct samba_kdc_entry);
-        int rodc_krbtgt_number;
-
-        /* Determine if this was printed by an RODC */
+/* Was the krbtgt in this DB (ie, should we check the incoming signature) and was it an RODC */
+int samba_krbtgt_is_in_db(struct samba_kdc_entry *p,
+                          bool *is_in_db,
+                          bool *is_untrusted)
+{
+        NTSTATUS status;
+        int rodc_krbtgt_number, trust_direction;
+        uint32_t rid;
+
+        TALLOC_CTX *mem_ctx = talloc_new(NULL);
+        if (!mem_ctx) {
+                return ENOMEM;
+        }
+        
+        trust_direction = ldb_msg_find_attr_as_int(p->msg, "trustDirection", 0);
+
+        if (trust_direction != 0) {
+                /* Domain trust - we cannot check the sig, but we trust it for a correct PAC
+                   
+                   This is exactly where we should flag for SID
+                   validation when we do inter-foreest trusts
+                 */
+                talloc_free(mem_ctx);
+                *is_untrusted = false;
+                *is_in_db = false;
+                return 0;
+        }
+
+        /* The lack of password controls etc applies to krbtgt by
+         * virtue of being that particular RID */
+        status = dom_sid_split_rid(NULL, samdb_result_dom_sid(mem_ctx, p->msg, "objectSid"), NULL, &rid);
+
+        if (!NT_STATUS_IS_OK(status)) {
+                talloc_free(mem_ctx);
+                return EINVAL;
+        }
+
         rodc_krbtgt_number = ldb_msg_find_attr_as_int(p->msg, "msDS-SecondaryKrbTgtNumber", -1);
-        if (rodc_krbtgt_number == -1) {
-                return false;
-        } else if (rodc_krbtgt_number != p->kdc_db_ctx->my_krbtgt_number) {
-                return true;
-        }
-
-        return false;
+
+        if (p->kdc_db_ctx->my_krbtgt_number == 0) {
+                if (rid == DOMAIN_RID_KRBTGT) {
+                        *is_untrusted = false;
+                        *is_in_db = true;
+                        talloc_free(mem_ctx);
+                        return 0;
+                } else if (rodc_krbtgt_number != -1) {
+                        *is_in_db = true;
+                        *is_untrusted = true;
+                        talloc_free(mem_ctx);
+                        return 0;
+                }
+        } else if ((rid != DOMAIN_RID_KRBTGT) && (rodc_krbtgt_number == p->kdc_db_ctx->my_krbtgt_number)) {
+                talloc_free(mem_ctx);
+                *is_untrusted = false;
+                *is_in_db = true;
+                return 0;
+        } else if (rid == DOMAIN_RID_KRBTGT) {
+                /* krbtgt viewed from an RODC */
+                talloc_free(mem_ctx);
+                *is_untrusted = false;
+                *is_in_db = false;
+                return 0;
+        }
+
+        /* Another RODC */
+        talloc_free(mem_ctx);
+        *is_untrusted = true;
+        *is_in_db = false;
+        return 0;
 }
 
 NTSTATUS samba_kdc_get_pac_blob(TALLOC_CTX *mem_ctx,
-                                struct hdb_entry_ex *client,
+                                struct samba_kdc_entry *p,
                                 DATA_BLOB **_pac_blob)
 {
-        struct samba_kdc_entry *p = talloc_get_type(client->ctx, struct samba_kdc_entry);
         struct auth_user_info_dc *user_info_dc;
         DATA_BLOB *pac_blob;
@@ -146 +229 @@
 
         /* The user account may be set not to want the PAC */
-        if ( ! samba_princ_needs_pac(client)) {
+        if ( ! samba_princ_needs_pac(p)) {
                 *_pac_blob = NULL;
                 return NT_STATUS_OK;
@@ -183 +266 @@
 NTSTATUS samba_kdc_update_pac_blob(TALLOC_CTX *mem_ctx,
                                    krb5_context context,
-                                   krb5_pac *pac, DATA_BLOB *pac_blob)
+                                   const krb5_pac pac, DATA_BLOB *pac_blob,
+                                   struct PAC_SIGNATURE_DATA *pac_srv_sig,
+                                   struct PAC_SIGNATURE_DATA *pac_kdc_sig)
 {
         struct auth_user_info_dc *user_info_dc;
@@ -189 +274 @@
         NTSTATUS nt_status;
 
-        ret = kerberos_pac_to_user_info_dc(mem_ctx, *pac,
-                                           context, &user_info_dc, NULL, NULL);
+        ret = kerberos_pac_to_user_info_dc(mem_ctx, pac,
+                                           context, &user_info_dc, pac_srv_sig, pac_kdc_sig);
         if (ret) {
                 return NT_STATUS_UNSUCCESSFUL;
@@ -201 +286 @@
 }
 
-/* this function allocates 'data' using malloc.
- * The caller is responsible for freeing it */
-void samba_kdc_build_edata_reply(NTSTATUS nt_status, DATA_BLOB *e_data)
-{
-        PA_DATA pa;
-        unsigned char *buf;
-        size_t len;
-        krb5_error_code ret = 0;
-
-        if (!e_data)
-                return;
-
-        pa.padata_type          = KRB5_PADATA_PW_SALT;
-        pa.padata_value.length  = 12;
-        pa.padata_value.data    = malloc(pa.padata_value.length);
-        if (!pa.padata_value.data) {
-                e_data->length = 0;
-                e_data->data = NULL;
-                return;
-        }
-
-        SIVAL(pa.padata_value.data, 0, NT_STATUS_V(nt_status));
-        SIVAL(pa.padata_value.data, 4, 0);
-        SIVAL(pa.padata_value.data, 8, 1);
-
-        ASN1_MALLOC_ENCODE(PA_DATA, buf, len, &pa, &len, ret);
-        free(pa.padata_value.data);
-
-        e_data->data   = buf;
-        e_data->length = len;
-
-        return;
+NTSTATUS samba_kdc_update_delegation_info_blob(TALLOC_CTX *mem_ctx,
+                                krb5_context context,
+                                const krb5_pac pac,
+                                const krb5_principal server_principal,
+                                const krb5_principal proxy_principal,
+                                DATA_BLOB *new_blob)
+{
+        krb5_data old_data;
+        DATA_BLOB old_blob;
+        krb5_error_code ret;
+        NTSTATUS nt_status;
+        enum ndr_err_code ndr_err;
+        union PAC_INFO info;
+        struct PAC_CONSTRAINED_DELEGATION _d;
+        struct PAC_CONSTRAINED_DELEGATION *d = NULL;
+        char *server = NULL;
+        char *proxy = NULL;
+        uint32_t i;
+        TALLOC_CTX *tmp_ctx = talloc_new(mem_ctx);
+
+        if (tmp_ctx == NULL) {
+                return NT_STATUS_NO_MEMORY;
+        }
+
+        ret = krb5_pac_get_buffer(context, pac, PAC_TYPE_CONSTRAINED_DELEGATION, &old_data);
+        if (ret == ENOENT) {
+                ZERO_STRUCT(old_data);
+        } else if (ret) {
+                talloc_free(tmp_ctx);
+                return NT_STATUS_UNSUCCESSFUL;
+        }
+
+        old_blob.length = old_data.length;
+        old_blob.data = (uint8_t *)old_data.data;
+
+        ZERO_STRUCT(info);
+        if (old_blob.length > 0) {
+                ndr_err = ndr_pull_union_blob(&old_blob, mem_ctx,
+                                &info, PAC_TYPE_CONSTRAINED_DELEGATION,
+                                (ndr_pull_flags_fn_t)ndr_pull_PAC_INFO);
+                if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+                        kerberos_free_data_contents(context, &old_data);
+                        nt_status = ndr_map_error2ntstatus(ndr_err);
+                        DEBUG(0,("can't parse the PAC LOGON_INFO: %s\n", nt_errstr(nt_status)));
+                        talloc_free(tmp_ctx);
+                        return nt_status;
+                }
+        } else {
+                ZERO_STRUCT(_d);
+                info.constrained_delegation.info = &_d;
+        }
+        kerberos_free_data_contents(context, &old_data);
+
+        ret = krb5_unparse_name(context, server_principal, &server);
+        if (ret) {
+                talloc_free(tmp_ctx);
+                return NT_STATUS_INTERNAL_ERROR;
+        }
+
+        ret = krb5_unparse_name_flags(context, proxy_principal,
+                                      KRB5_PRINCIPAL_UNPARSE_NO_REALM, &proxy);
+        if (ret) {
+                SAFE_FREE(server);
+                talloc_free(tmp_ctx);
+                return NT_STATUS_INTERNAL_ERROR;
+        }
+
+        d = info.constrained_delegation.info;
+        i = d->num_transited_services;
+        d->proxy_target.string = server;
+        d->transited_services = talloc_realloc(mem_ctx, d->transited_services,
+                                               struct lsa_String, i + 1);
+        d->transited_services[i].string = proxy;
+        d->num_transited_services = i + 1;
+
+        ndr_err = ndr_push_union_blob(new_blob, mem_ctx,
+                                &info, PAC_TYPE_CONSTRAINED_DELEGATION,
+                                (ndr_push_flags_fn_t)ndr_push_PAC_INFO);
+        SAFE_FREE(server);
+        SAFE_FREE(proxy);
+        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+                kerberos_free_data_contents(context, &old_data);
+                nt_status = ndr_map_error2ntstatus(ndr_err);
+                DEBUG(0,("can't parse the PAC LOGON_INFO: %s\n", nt_errstr(nt_status)));
+                talloc_free(tmp_ctx);
+                return nt_status;
+        }
+
+        talloc_free(tmp_ctx);
+        return NT_STATUS_OK;
 }
 
@@ -241 +384 @@
 
         if (NT_STATUS_EQUAL(nt_status, NT_STATUS_PASSWORD_MUST_CHANGE))
-                ret = KRB5KDC_ERR_KEY_EXPIRED;
+                ret = KRB5KDC_ERR_KEY_EXP;
         else if (NT_STATUS_EQUAL(nt_status, NT_STATUS_PASSWORD_EXPIRED))
-                ret = KRB5KDC_ERR_KEY_EXPIRED;
+                ret = KRB5KDC_ERR_KEY_EXP;
         else if (NT_STATUS_EQUAL(nt_status, NT_STATUS_ACCOUNT_EXPIRED))
                 ret = KRB5KDC_ERR_CLIENT_REVOKED;
@@ -287 +430 @@
         return nt_status;
 }
-

vendor/current/source4/kdc/pac-glue.h

@@ -24 +24 @@
 krb5_error_code samba_make_krb5_pac(krb5_context context,
                                     DATA_BLOB *pac_blob,
+                                    DATA_BLOB *deleg_blob,
                                     krb5_pac *pac);
 
-bool samba_princ_needs_pac(struct hdb_entry_ex *princ);
+bool samba_princ_needs_pac(struct samba_kdc_entry *skdc_entry);
 
-bool samba_krbtgt_was_untrusted_rodc(struct hdb_entry_ex *princ);
+int samba_krbtgt_is_in_db(struct samba_kdc_entry *skdc_entry,
+                          bool *is_in_db,
+                          bool *is_untrusted);
 
 NTSTATUS samba_kdc_get_pac_blob(TALLOC_CTX *mem_ctx,
-                                struct hdb_entry_ex *client,
+                                struct samba_kdc_entry *skdc_entry,
                                 DATA_BLOB **_pac_blob);
 
 NTSTATUS samba_kdc_update_pac_blob(TALLOC_CTX *mem_ctx,
                                    krb5_context context,
-                                   krb5_pac *pac, DATA_BLOB *pac_blob);
+                                   const krb5_pac pac, DATA_BLOB *pac_blob,
+                                   struct PAC_SIGNATURE_DATA *pac_srv_sig,
+                                   struct PAC_SIGNATURE_DATA *pac_kdc_sig);
 
-void samba_kdc_build_edata_reply(NTSTATUS nt_status, DATA_BLOB *e_data);
+NTSTATUS samba_kdc_update_delegation_info_blob(TALLOC_CTX *mem_ctx,
+                                krb5_context context,
+                                const krb5_pac pac,
+                                const krb5_principal server_principal,
+                                const krb5_principal proxy_principal,
+                                DATA_BLOB *pac_blob);
 
 krb5_error_code samba_kdc_map_policy_err(NTSTATUS nt_status);

vendor/current/source4/kdc/proxy.c

@@ -557 +557 @@
         state->out = data_blob_talloc(state, raw.data + 4, raw.length - 4);
         if (state->out.length != raw.length - 4) {
-                tevent_req_nomem(NULL, req);
+                tevent_req_oom(req);
                 return;
         }

vendor/current/source4/kdc/samba_kdc.h

@@ -22 +22 @@
 */
 
+#ifndef _SAMBA_KDC_H_
+#define _SAMBA_KDC_H_
+
+struct samba_kdc_policy {
+        time_t svc_tkt_lifetime;
+        time_t usr_tkt_lifetime;
+        time_t renewal_lifetime;
+};
+
 struct samba_kdc_base_context {
         struct tevent_context *ev_ctx;
@@ -37 +46 @@
         unsigned int my_krbtgt_number;
         struct ldb_dn *krbtgt_dn;
-        struct lsa_DomainInfoKerberos policy;
+        struct samba_kdc_policy policy;
 };
 
@@ -44 +53 @@
         struct ldb_message *msg;
         struct ldb_dn *realm_dn;
-        hdb_entry_ex *entry_ex;
+        void *entry_ex;
 };
+
+extern struct hdb_method hdb_samba4_interface;
+
+#endif /* _SAMBA_KDC_H_ */

vendor/current/source4/kdc/wdc-samba4.c

@@ -35 +35 @@
         krb5_error_code ret;
         NTSTATUS nt_status;
+        struct samba_kdc_entry *skdc_entry =
+                talloc_get_type_abort(client->ctx,
+                struct samba_kdc_entry);
 
         mem_ctx = talloc_named(client->ctx, 0, "samba_get_pac context");
@@ -41 +44 @@
         }
 
-        nt_status = samba_kdc_get_pac_blob(mem_ctx, client, &pac_blob);
+        nt_status = samba_kdc_get_pac_blob(mem_ctx, skdc_entry, &pac_blob);
         if (!NT_STATUS_IS_OK(nt_status)) {
                 talloc_free(mem_ctx);
@@ -47 +50 @@
         }
 
-        ret = samba_make_krb5_pac(context, pac_blob, pac);
+        ret = samba_make_krb5_pac(context, pac_blob, NULL, pac);
 
         talloc_free(mem_ctx);
@@ -57 +60 @@
 static krb5_error_code samba_wdc_reget_pac(void *priv, krb5_context context,
                                            const krb5_principal client_principal,
+                                           const krb5_principal delegated_proxy_principal,
                                            struct hdb_entry_ex *client,
                                            struct hdb_entry_ex *server,
@@ -62 +66 @@
                                            krb5_pac *pac)
 {
-        struct samba_kdc_entry *p = talloc_get_type(server->ctx, struct samba_kdc_entry);
+        struct samba_kdc_entry *p =
+                talloc_get_type_abort(server->ctx,
+                struct samba_kdc_entry);
+        struct samba_kdc_entry *krbtgt_skdc_entry =
+                talloc_get_type_abort(krbtgt->ctx,
+                struct samba_kdc_entry);
         TALLOC_CTX *mem_ctx = talloc_named(p, 0, "samba_kdc_reget_pac context");
         DATA_BLOB *pac_blob;
+        DATA_BLOB *deleg_blob = NULL;
         krb5_error_code ret;
         NTSTATUS nt_status;
+        struct PAC_SIGNATURE_DATA *pac_srv_sig;
+        struct PAC_SIGNATURE_DATA *pac_kdc_sig;
+        bool is_in_db, is_untrusted;
 
         if (!mem_ctx) {
@@ -73 +86 @@
 
         /* The user account may be set not to want the PAC */
-        if (!samba_princ_needs_pac(server)) {
+        if (!samba_princ_needs_pac(p)) {
                 talloc_free(mem_ctx);
                 return EINVAL;
@@ -81 +94 @@
          * RODC, then we need to regenerate the PAC - we can't trust
          * it */
-        if (samba_krbtgt_was_untrusted_rodc(krbtgt)) {
+        ret = samba_krbtgt_is_in_db(krbtgt_skdc_entry, &is_in_db, &is_untrusted);
+        if (ret != 0) {
+                talloc_free(mem_ctx);
+                return ret;
+        }
+
+        if (is_untrusted) {
+                struct samba_kdc_entry *client_skdc_entry = NULL;
+
                 if (client == NULL) {
                         return KRB5KDC_ERR_C_PRINCIPAL_UNKNOWN;
                 }
-                nt_status = samba_kdc_get_pac_blob(mem_ctx, client, &pac_blob);
+
+                client_skdc_entry = talloc_get_type_abort(client->ctx,
+                                                          struct samba_kdc_entry);
+
+                nt_status = samba_kdc_get_pac_blob(mem_ctx, client_skdc_entry, &pac_blob);
                 if (!NT_STATUS_IS_OK(nt_status)) {
                         talloc_free(mem_ctx);
@@ -97 +122 @@
                 }
 
+                pac_srv_sig = talloc_zero(mem_ctx, struct PAC_SIGNATURE_DATA);
+                if (!pac_srv_sig) {
+                        talloc_free(mem_ctx);
+                        return ENOMEM;
+                }
+
+                pac_kdc_sig = talloc_zero(mem_ctx, struct PAC_SIGNATURE_DATA);
+                if (!pac_kdc_sig) {
+                        talloc_free(mem_ctx);
+                        return ENOMEM;
+                }
+
                 nt_status = samba_kdc_update_pac_blob(mem_ctx, context,
-                                                      pac, pac_blob);
+                                                      *pac, pac_blob,
+                                                      pac_srv_sig, pac_kdc_sig);
                 if (!NT_STATUS_IS_OK(nt_status)) {
                         DEBUG(0, ("Building PAC failed: %s\n",
@@ -105 +143 @@
                         return EINVAL;
                 }
-        }
+                
+                if (is_in_db) {
+                        /* Now check the KDC signature, fetching the correct key based on the enc type */
+                        ret = kdc_check_pac(context, pac_srv_sig->signature, pac_kdc_sig, krbtgt);
+                        if (ret != 0) {
+                                DEBUG(1, ("PAC KDC signature failed to verify\n"));
+                                talloc_free(mem_ctx);
+                                return ret;
+                        }
+                }
+        }
+
+        if (delegated_proxy_principal) {
+                deleg_blob = talloc_zero(mem_ctx, DATA_BLOB);
+                if (!deleg_blob) {
+                        talloc_free(mem_ctx);
+                        return ENOMEM;
+                }
+
+                nt_status = samba_kdc_update_delegation_info_blob(mem_ctx,
+                                        context, *pac,
+                                        server->entry.principal,
+                                        delegated_proxy_principal,
+                                        deleg_blob);
+                if (!NT_STATUS_IS_OK(nt_status)) {
+                        DEBUG(0, ("Building PAC failed: %s\n",
+                                  nt_errstr(nt_status)));
+                        talloc_free(mem_ctx);
+                        return EINVAL;
+                }
+        }
+
         /* We now completely regenerate this pac */
         krb5_pac_free(context, *pac);
 
-        ret = samba_make_krb5_pac(context, pac_blob, pac);
+        ret = samba_make_krb5_pac(context, pac_blob, deleg_blob, pac);
 
         talloc_free(mem_ctx);
@@ -133 +202 @@
         }
 
-        if (nb_name == NULL) {
+        if ((nb_name == NULL) || (nb_name[0] == '\0')) {
                 return NULL;
         }
 
         /* Strip space padding */
-        i = strlen(nb_name) - 1;
-        while (i > 0 && nb_name[i] == ' ') {
-                nb_name[i] = '\0';
+        for (len = strlen(nb_name) - 1;
+             (len > 0) && (nb_name[len] == ' ');
+             --len) {
+                nb_name[len] = '\0';
         }
 
@@ -155 +225 @@
         return kdata;
 }
+
+/* this function allocates 'data' using malloc.
+ * The caller is responsible for freeing it */
+static void samba_kdc_build_edata_reply(NTSTATUS nt_status, DATA_BLOB *e_data)
+{
+        krb5_error_code ret = 0;
+        PA_DATA pa;
+        unsigned char *buf;
+        size_t len;
+
+        if (!e_data)
+                return;
+
+        e_data->data   = NULL;
+        e_data->length = 0;
+
+        pa.padata_type          = KRB5_PADATA_PW_SALT;
+        pa.padata_value.length  = 12;
+        pa.padata_value.data    = malloc(pa.padata_value.length);
+        if (!pa.padata_value.data) {
+                e_data->length = 0;
+                e_data->data = NULL;
+                return;
+        }
+
+        SIVAL(pa.padata_value.data, 0, NT_STATUS_V(nt_status));
+        SIVAL(pa.padata_value.data, 4, 0);
+        SIVAL(pa.padata_value.data, 8, 1);
+
+        ASN1_MALLOC_ENCODE(PA_DATA, buf, len, &pa, &len, ret);
+        free(pa.padata_value.data);
+        if (ret) {
+                return;
+        }
+
+        e_data->data   = buf;
+        e_data->length = len;
+
+        return;
+}
+
 
 static krb5_error_code samba_wdc_check_client_access(void *priv,
@@ -213 +324 @@
 
 struct krb5plugin_windc_ftable windc_plugin_table = {
-        .minor_version = KRB5_WINDC_PLUGING_MINOR,
+        .minor_version = KRB5_WINDC_PLUGIN_MINOR,
         .init = samba_wdc_plugin_init,
         .fini = samba_wdc_plugin_fini,

vendor/current/source4/kdc/wscript_build

@@ -1 +1 @@
 #!/usr/bin/env python
 
+# We do this because we do not want to depend on the KDC, only find and use it's header files.  We do not want 
+if not bld.CONFIG_SET("USING_SYSTEM_KDC"):
+    kdc_include = "../heimdal/kdc"
+else:
+    kdc_include = getattr(bld.env, "CPPPATH_KDC")
+
 bld.SAMBA_MODULE('service_kdc',
-        source='kdc.c kpasswdd.c proxy.c',
-        subsystem='service',
-        init_function='server_service_kdc_init',
-        deps='kdc HDB_SAMBA4 WDC_SAMBA4 samba-hostconfig LIBTSOCKET LIBSAMBA_TSOCKET com_err samba_server_gensec',
-        internal_module=False,
+                 source='kdc.c kpasswdd.c proxy.c',
+                 subsystem='service',
+                 init_function='server_service_kdc_init',
+                 deps='''
+                      kdc
+                      HDB_SAMBA4
+                      WDC_SAMBA4
+                      samba-hostconfig
+                      LIBTSOCKET
+                      LIBSAMBA_TSOCKET
+                      com_err
+                      samba_server_gensec
+                      PAC_GLUE
+                      KDC-GLUE
+                      KPASSWD_GLUE
+                 ''',
+                 internal_module=False)
+
+bld.SAMBA_LIBRARY('HDB_SAMBA4',
+                  source='hdb-samba4.c hdb-samba4-plugin.c',
+                  deps='ldb auth4_sam auth_sam_reply samba-credentials hdb db-glue samba-hostconfig com_err sdb_hdb',
+                  includes=kdc_include,
+                  private_library=True,
+                  enabled=bld.CONFIG_SET('SAMBA4_USES_HEIMDAL')
+                  )
+
+# A plugin for Heimdal's kadmin for users who need to operate that tool
+bld.SAMBA_LIBRARY('HDB_SAMBA4_PLUGIN',
+                  source='hdb-samba4-plugin.c',
+                  deps='hdb HDB_SAMBA4 samba-util samba-hostconfig ',
+                  includes=kdc_include,
+                  link_name='modules/hdb/hdb_samba4.so',
+                  realname='hdb_samba4.so',
+                  install_path='${MODULESDIR}/hdb',
+                  enabled = (bld.CONFIG_SET("USING_SYSTEM_KRB5") and bld.CONFIG_SET("USING_SYSTEM_HDB"))
+                  )
+
+bld.SAMBA_SUBSYSTEM('KDC-GLUE',
+        source='kdc-glue.c',
+        includes=kdc_include,
+        deps='hdb PAC_GLUE',
+        enabled=bld.CONFIG_SET('SAMBA4_USES_HEIMDAL')
         )
-
-
-bld.SAMBA_SUBSYSTEM('HDB_SAMBA4',
-        source='hdb-samba4.c',
-        deps='ldb auth4_sam auth_sam_reply credentials hdb db-glue samba-hostconfig com_err',
-        includes='../heimdal/kdc',
-        )
-
 
 bld.SAMBA_SUBSYSTEM('WDC_SAMBA4',
         source='wdc-samba4.c',
-        includes='../heimdal/kdc',
-        deps='ldb auth4_sam auth_sam_reply credentials hdb PAC_GLUE samba-hostconfig com_err'
+        includes=kdc_include,
+        deps='ldb auth4_sam auth_sam_reply samba-credentials hdb PAC_GLUE samba-hostconfig com_err KDC-GLUE',
+        enabled=bld.CONFIG_SET('SAMBA4_USES_HEIMDAL')
         )
 
+bld.SAMBA_SUBSYSTEM('sdb',
+        source='sdb.c',
+        includes=kdc_include,
+        deps='talloc krb5',
+        )
+
+bld.SAMBA_SUBSYSTEM('sdb_hdb',
+        source='sdb_to_hdb.c',
+        includes=kdc_include,
+        deps='talloc sdb hdb',
+        autoproto='sdb_hdb.h',
+        enabled=bld.CONFIG_SET('SAMBA4_USES_HEIMDAL')
+        )
 
 bld.SAMBA_SUBSYSTEM('PAC_GLUE',
         source='pac-glue.c',
-        includes='../heimdal/kdc',
-        deps='ldb auth4_sam auth_sam_reply credentials hdb samba-hostconfig com_err'
+        includes=kdc_include,
+        deps='ldb auth4_sam auth_sam_reply samba-credentials samba-hostconfig com_err'
         )
 
@@ -39 +88 @@
 bld.SAMBA_LIBRARY('db-glue',
         source='db-glue.c',
-        deps='ldb auth4_sam auth_sam_reply credentials hdb samba-hostconfig com_err kdc-policy',
-        private_library=True
+        deps='ldb auth4_sam auth_sam_reply samba-credentials sdb samba-hostconfig com_err',
+        private_library=True,
+        includes=kdc_include,
         )
 
-bld.SAMBA_LIBRARY('kdc-policy',
-        source='policy.c',
-        deps='samba-hostconfig authkrb5',
-        private_library=True,
-        autoproto = 'kdc-policy-proto.h'
-        )
-
+bld.SAMBA_SUBSYSTEM('KPASSWD_GLUE',
+        source='kpasswd_glue.c',
+        includes=kdc_include,
+        deps='ldb com_err')
 
 bld.SAMBA_SUBSYSTEM('MIT_SAMBA',
-        source='mit_samba.c',
-        deps='ldb auth4_sam auth_sam_reply credentials hdb db-glue PAC_GLUE samba-hostconfig com_err'
-        )
-
-
-bld.SAMBA_LIBRARY('mit-samba',
-        source='',
-        deps='MIT_SAMBA',
-        external_library=True,
-        realname='mit_samba.so'
-        )
-
+                    source='mit_samba.c',
+                    deps='''
+                         ldb
+                         auth4_sam
+                         auth_sam_reply
+                         samba-credentials
+                         hdb
+                         db-glue
+                         PAC_GLUE
+                         samba-hostconfig
+                         com_err
+                         ''',
+                    enabled=not bld.CONFIG_SET('SAMBA4_USES_HEIMDAL'))