Changeset 583 for trunk/server/source3/smbd/nttrans.c

Timestamp:

Jun 28, 2011, 10:17:44 AM (14 years ago)

Author:

Herwig Bauernfeind

Message:

Samba 3.5: Update trunk to 3.5.5

File:

• trunk/server/source3/smbd/nttrans.c (modified) (3 diffs)

trunk/server/source3/smbd/nttrans.c

@@ -2162 +2162 @@
                 /*unknown = IVAL(pdata,0);*/
 
-                sid_parse(pdata+4,sid_len,&sid);
+                if (!sid_parse(pdata+4,sid_len,&sid)) {
+                        reply_nterror(req, NT_STATUS_INVALID_PARAMETER);
+                        return;
+                }
+
                 DEBUGADD(10, ("for SID: %s\n", sid_string_dbg(&sid)));
 
@@ -2418 +2422 @@
                         }
 
-                        sid_parse(pdata+8,sid_len,&sid);
+                        if (!sid_parse(pdata+8,sid_len,&sid)) {
+                                reply_nterror(req, NT_STATUS_INVALID_PARAMETER);
+                                return;
+                        }
 
                         if (vfs_get_ntquota(fsp, SMB_USER_QUOTA_TYPE, &sid, &qt)!=0) {
@@ -2599 +2606 @@
 #endif /* LARGE_SMB_OFF_T */
 
-        sid_parse(pdata+40,sid_len,&sid);
+        if (!sid_parse(pdata+40,sid_len,&sid)) {
+                reply_nterror(req, NT_STATUS_INVALID_PARAMETER);
+                return;
+        }
+
         DEBUGADD(8,("SID: %s\n", sid_string_dbg(&sid)));