Changeset 491 for branches/samba-3.3.x/source/smbd/nttrans.c

Timestamp:

Sep 16, 2010, 10:06:10 AM (15 years ago)

Author:

Herwig Bauernfeind

Message:

Update Samba 3.3 to 3.3.14 (security update)

File:

• branches/samba-3.3.x/source/smbd/nttrans.c (modified) (3 diffs)

branches/samba-3.3.x/source/smbd/nttrans.c

@@ -1951 +1951 @@
                 /*unknown = IVAL(pdata,0);*/
 
-                sid_parse(pdata+4,sid_len,&sid);
+                if (!sid_parse(pdata+4,sid_len,&sid)) {
+                        reply_nterror(req, NT_STATUS_INVALID_PARAMETER);
+                        return;
+                }
+
                 DEBUGADD(10, ("for SID: %s\n", sid_string_dbg(&sid)));
 
@@ -2207 +2211 @@
                         }
 
-                        sid_parse(pdata+8,sid_len,&sid);
+                        if (!sid_parse(pdata+8,sid_len,&sid)) {
+                                reply_nterror(req, NT_STATUS_INVALID_PARAMETER);
+                                return;
+                        }
 
                         if (vfs_get_ntquota(fsp, SMB_USER_QUOTA_TYPE, &sid, &qt)!=0) {
@@ -2388 +2395 @@
 #endif /* LARGE_SMB_OFF_T */
 
-        sid_parse(pdata+40,sid_len,&sid);
+        if (!sid_parse(pdata+40,sid_len,&sid)) {
+                reply_nterror(req, NT_STATUS_INVALID_PARAMETER);
+                return;
+        }
+
         DEBUGADD(8,("SID: %s\n", sid_string_dbg(&sid)));