Changeset 1254 for python/trunk/Modules/posixmodule.c

Timestamp:

Nov 10, 2017, 12:00:15 AM (8 years ago)

Author:

dmik

Message:

python: Use spawn instead of fork in subprocess.

This significantly improves performance when running many external programs.
See #275 for more details.

Note that this commit also makes os.pipe use pipe() instead of socketpair() and
this in turn fixes #267. Note that socketpair() is still available via socket.socketpair()
in Python.

File:

• python/trunk/Modules/posixmodule.c (modified) (2 diffs)

python/trunk/Modules/posixmodule.c

@@ -4821 +4821 @@
     i = pipe_err = 0;
     while ((pipe_err == 0) && (i < file_count))
-#ifndef __KLIBC__
         pipe_err = pipe((int *)&p_fd[i++]);
-#else
-        pipe_err = socketpair(AF_UNIX, SOCK_STREAM,0,(int *)&p_fd[i++]);
-#endif
     if (pipe_err < 0)
     {
@@ -6962 +6958 @@
     int res;
     Py_BEGIN_ALLOW_THREADS
-#ifndef __KLIBC__
     res = pipe(fds);
-#else
-    res = socketpair(AF_UNIX, SOCK_STREAM,0, fds);
-#endif
     Py_END_ALLOW_THREADS
     if (res != 0)