Changeset 8753 for trunk/src/user32/oslibres.cpp

Timestamp:

Jun 25, 2002, 9:11:10 AM (23 years ago)

Author:

sandervl

Message:

Allocate space the two missing RGB2 entries

File:

• trunk/src/user32/oslibres.cpp (modified) (16 diffs)

trunk/src/user32/oslibres.cpp

@@ -1 @@
-/* $Id: oslibres.cpp,v 1.30 2002-02-18 10:14:56 sandervl Exp $ */
+/* $Id: oslibres.cpp,v 1.31 2002-06-25 07:11:10 sandervl Exp $ */
 /*
  * Window API wrappers for OS/2
@@ -247 +247 @@
             pixel = 0;
             memcpy(&pixel, os2rgb, increment);
-            if(nrcolors == 0) { 
+            if(nrcolors == 0) {
                 color[0] = pixel;
                 nrcolors = 1;
@@ -257 +257 @@
             }
             else {
-                if(color[0] != pixel && color[1] != pixel) 
+                if(color[0] != pixel && color[1] != pixel)
                 {
                     return FALSE;
@@ -271 +271 @@
 //******************************************************************************
 char *colorToMonoBitmap(HBITMAP bmpsrc, BITMAPINFO2 *pBmpDest)
-{ 
+{
     HDC hdcDest = 0;            /* device context handle                */
     HPS hpsDest = 0;
     SIZEL sizl = { 0, 0 };  /* use same page size as device         */
     DEVOPENSTRUC dop = {0L, "DISPLAY", NULL, 0L, 0L, 0L, 0L, 0L, 0L};
-    LONG lHits; 
+    LONG lHits;
     char *bmpbuffer = 0;
     BITMAPINFO2 *bmpinfo = NULL;
@@ -287 +287 @@
     /* create memory device context */
     hdcDest = DevOpenDC(hab, OD_MEMORY, "*", 5L, (PDEVOPENDATA)&dop, NULLHANDLE);
- 
+
     /* Create the presentation and associate the memory device
        context. */
     hpsDest = GpiCreatePS(hab, hdcDest, &sizl, PU_PELS |
                           GPIT_MICRO | GPIA_ASSOC);
-    if(!hpsDest) goto fail; 
+    if(!hpsDest) goto fail;
 
     GpiSetBitmap(hpsDest, bmpsrc);
@@ -322 +322 @@
                 else WriteLogNoEOL(".");
             }
-            else 
+            else
             if(j<16) {
                 if((*(bmpbuffer+1+i*4)) & (1<<(15-j))) {
@@ -355 +355 @@
     free(bmpinfo);
 
-    return bmpbuffer; 
+    return bmpbuffer;
 
 fail:
@@ -374 +374 @@
 //      Assumes 1 bpp bitmaps have a top left origin and all others have a bottom left origin
 //******************************************************************************
-HANDLE OSLibWinCreatePointer(CURSORICONINFO *pInfo, char *pAndBits, BITMAP_W *pAndBmp, char *pXorBits, 
+HANDLE OSLibWinCreatePointer(CURSORICONINFO *pInfo, char *pAndBits, BITMAP_W *pAndBmp, char *pXorBits,
                              BITMAP_W *pXorBmp, BOOL fCursor)
 {
@@ -434 +434 @@
                 }
         }
-        else    
+        else
         if(pXorBmp->bmBitsPixel == 16) {
                 ConvertRGB555to565(os2rgb, rgb, pXorBmp->bmHeight * pXorBmp->bmWidthBytes);
@@ -447 +447 @@
                 goto fail;
         }
-        if(fCursor && pXorBmp->bmBitsPixel >= 8) 
+        if(fCursor && pXorBmp->bmBitsPixel >= 8)
         {
-            if(fForceMonoCursor || isMonoBitmap(pXorBmp, (PBYTE)os2rgb) == TRUE) 
+            if(fForceMonoCursor || isMonoBitmap(pXorBmp, (PBYTE)os2rgb) == TRUE)
             {
                 pOS2XorBits = colorToMonoBitmap(hbmColor, pBmpColor);
@@ -466 +466 @@
     //SvL: 2*sizeof(RGB2) is enough, but GpiCreateBitmap seems to touch more
     //     memory. (Adobe Photoshop 6 running in the debugger)
-    masksize = sizeof(BITMAPINFO2) + (pAndBmp->bmHeight * 2 * pAndBmp->bmWidthBytes) + 16*sizeof(RGB2);
+    //bird: We should reserve the amount required anythingelse is stupid.
+    //      Looks like it's reading 3 bytes too much... Hopefully that's due to the
+    //      &pBmpMask->argbColor[2] which it assumes is 16 colors long. But no proofs.
+    masksize = sizeof(BITMAPINFO2) + (pAndBmp->bmHeight * 2 * pAndBmp->bmWidthBytes) + (16+2)*sizeof(RGB2);
     pBmpMask = (BITMAPINFO2 *)malloc(masksize);
     if(pBmpMask == NULL) {
@@ -723 +726 @@
 //******************************************************************************
 //******************************************************************************
-BOOL WIN32API OSLibWinCreateObject(LPSTR pszPath, LPSTR pszArgs, 
-                                   LPSTR pszWorkDir, LPSTR pszLink, 
+BOOL WIN32API OSLibWinCreateObject(LPSTR pszPath, LPSTR pszArgs,
+                                   LPSTR pszWorkDir, LPSTR pszLink,
                                    LPSTR pszDescription, LPSTR pszIcoPath,
                                    INT iIcoNdx, BOOL fDesktop)
@@ -748 +751 @@
        }
    }
-   dprintf(("OSLibWinCreateObject %s %s %s\n    %s %s %s %d %d", pszPath, pszArgs, 
+   dprintf(("OSLibWinCreateObject %s %s %s\n    %s %s %s %d %d", pszPath, pszArgs,
             pszWorkDir, pszName, pszDescription, pszIcoPath, iIcoNdx, fDesktop));
    dprintf(("Link path %s", pszLink));
@@ -761 +764 @@
    }
 
-   pszSetupString = (LPSTR)malloc(128 + strlen(pszPath) + strlen(pszName) + 
+   pszSetupString = (LPSTR)malloc(128 + strlen(pszPath) + strlen(pszName) +
                                   strlen(pszLink) + 2*strlen(szSystemDir) +
                                   strlen(szWorkDir) + strlen(pszIcoPath) +
-                                  ((pszArgs) ? strlen(pszArgs) : 0) + 
-                                  ((pszWorkDir) ? strlen(pszWorkDir) : 0)); 
+                                  ((pszArgs) ? strlen(pszArgs) : 0) +
+                                  ((pszWorkDir) ? strlen(pszWorkDir) : 0));
 
    sprintf(pszSetupString, "PROGTYPE=PM;OBJECTID=<%s>;EXENAME=%s\\PE.EXE;SET BEGINLIBPATH=%s;STARTUPDIR=%s;ICONFILE=%s;PARAMETERS=\"%s\"", pszName, szSystemDir, szSystemDir, szWorkDir, pszIcoPath, pszPath);
@@ -777 +780 @@
        dprintf(("Name = %s", pszName));
        dprintf(("Setup string = %s", pszSetupString));
-       hObject = WinCreateObject("WPProgram", pszName, pszSetupString, 
+       hObject = WinCreateObject("WPProgram", pszName, pszSetupString,
                                  "<WP_DESKTOP>", CO_REPLACEIFEXISTS);
    }
@@ -788 +791 @@
        hObject = WinCreateObject("WPFolder", pszFolder, szWorkDir,
                                  "<ODINFOLDER>", CO_UPDATEIFEXISTS);
-       hObject = WinCreateObject("WPProgram", pszName, pszSetupString, 
+       hObject = WinCreateObject("WPProgram", pszName, pszSetupString,
                                  temp, CO_REPLACEIFEXISTS);
    }
 // If SysCreateObject("WPProgram", "WarpMix", "<ICHAUDIO>",,
-//                    "PROGTYPE=PM;OBJECTID=<WARPMIX>;ICONFILE=WARPMIX.ICO;EXENAME="||bootDrive||"\MMOS2\WARPMIX.EXE")  
+//                    "PROGTYPE=PM;OBJECTID=<WARPMIX>;ICONFILE=WARPMIX.ICO;EXENAME="||bootDrive||"\MMOS2\WARPMIX.EXE")
 
    free(pszSetupString);