Changeset 6169 for trunk/src/user32/win32wbase.cpp

Timestamp:

Jul 4, 2001, 7:46:05 PM (24 years ago)

Author:

sandervl

Message:

fix for GetTopWindow/GetWindow calls during WM_NCCREATE

File:

• trunk/src/user32/win32wbase.cpp (modified) (20 diffs)

trunk/src/user32/win32wbase.cpp

@@ -1 @@
-/* $Id: win32wbase.cpp,v 1.273 2001-07-04 09:55:18 sandervl Exp $ */
+/* $Id: win32wbase.cpp,v 1.274 2001-07-04 17:46:04 sandervl Exp $ */
 /*
  * Win32 Window Base Class for OS/2
@@ -25 +25 @@
  *       Window rectangle in parent coordinates (relative to parent's client window)
  *       (screen coord. if no parent)
+ *
+ * NOTE: Status of window:
+ *       Before a window has processed WM_NCCREATE:
+ *       - GetTopWindow can't return that window handle
+ *       - GetWindow(parent, GW_CHILD) can't return that window handle
+ *       - IsChild works
+ *       TODO: Does this affect more functions?? (other GetWindow ops)
+ *       (verified in NT4, SP6)
  *
  * Project Odin Software License can be found in LICENSE.TXT
@@ -105 +113 @@
   OS2HwndModalDialog  = 0;
   fInternalMsg     = FALSE;
-  fNoSizeMsg       = FALSE;
   fParentChange    = FALSE;
-  fIsDestroyed     = FALSE;
   fDestroyWindowCalled = FALSE;
-  fCreated         = FALSE;
   fTaskList        = FALSE;
   fParentDC        = FALSE;
   fComingToTop     = FALSE;
-  fCreateSetWindowPos = FALSE;
-  fCreationFinished= FALSE;
   fMinMaxChange    = FALSE;
   fVisibleRegionChanged = FALSE;
   fEraseBkgndFlag  = TRUE;
 
+  state            = STATE_INIT;
   windowNameA      = NULL;
   windowNameW      = NULL;
@@ -502 +506 @@
     }
     OSLibWinSetVisibleRegionNotify(OS2Hwnd, TRUE);
-    fCreationFinished = TRUE;   //creation done with success
+    state = STATE_CREATED;
     SetLastError(0);
     return TRUE;
@@ -516 +520 @@
 
     OS2Hwnd      = hwndOS2;
-
-    fNoSizeMsg = TRUE;
 
     if(OSLibWinSetWindowULong(OS2Hwnd, OFFSET_WIN32WNDPTR, getWindowHandle()) == FALSE) {
@@ -718 +720 @@
     maxPos.x = rectWindow.left; maxPos.y = rectWindow.top;
 
-    //Note: Solitaire crashes when receiving WM_SIZE messages before WM_CREATE
-    fCreated = TRUE;
-
     if(fTaskList) {
         hTaskList = OSLibWinAddToTaskList(OS2HwndFrame, windowNameA, (cs->style & WS_VISIBLE) ? 1 : 0);
@@ -727 +726 @@
     localSend32 = (isUnicode) ? ::SendMessageW : ::SendMessageA;
 
+    state = STATE_PRE_WMNCCREATE;
     if(localSend32(getWindowHandle(), WM_NCCREATE,0,(LPARAM)cs))
     {
@@ -744 +744 @@
         }
         tmpRect = rectWindow;
-
-        fCreateSetWindowPos = TRUE;
+        state   = STATE_POST_WMNCCREATE;
 
         //set the window size and update the client
         SetWindowPos(hwndLinkAfter, tmpRect.left, tmpRect.top, tmpRect.right-tmpRect.left, tmpRect.bottom-tmpRect.top,SWP_NOACTIVATE | SWP_NOREDRAW | SWP_FRAMECHANGED);
-        fNoSizeMsg = FALSE;
+
+        state = STATE_PRE_WMCREATE;
         if (cs->style & WS_VISIBLE) dwStyle |= WS_VISIBLE; //program could change position in WM_CREATE
         if( (localSend32(getWindowHandle(), WM_CREATE, 0, (LPARAM)cs )) != -1 )
         {
+            state = STATE_POST_WMCREATE;
+
             if(!(flags & WIN_NEED_SIZE))
             {
@@ -839 +841 @@
  HWND hwnd = getWindowHandle();
 
-    fIsDestroyed = TRUE;
+    state = STATE_DESTROYED;
 
     if(fDestroyWindowCalled == FALSE)
@@ -863 +865 @@
     TIMER_KillTimerFromWindow(getWindowHandle());
 
-    if(getRefCount() == 0 && getFirstChild() == NULL && fCreationFinished) {
+    if(getRefCount() == 0 && getFirstChild() == NULL && state == STATE_CREATED) {
         delete this;
     }
@@ -895 +897 @@
 ULONG Win32BaseWindow::MsgShow(BOOL fShow)
 {
-    if(fNoSizeMsg || fDestroyWindowCalled) {
+    if(!CanReceiveSizeMsgs() || fDestroyWindowCalled) {
         return 1;
     }
@@ -917 +919 @@
     //SvL: Notes crashes when switching views (calls DestroyWindow -> PM sends
     //     a WM_WINDOWPOSCHANGED msg -> crash)
-    if(fNoSizeMsg || fDestroyWindowCalled)
+    if(!CanReceiveSizeMsgs() || fDestroyWindowCalled)
         return 0;
 
@@ -928 +930 @@
     //SvL: Notes crashes when switching views (calls DestroyWindow -> PM sends
     //     a WM_WINDOWPOSCHANGED msg -> crash)
-    if(fNoSizeMsg || fDestroyWindowCalled)
+    if(CanReceiveSizeMsgs() || fDestroyWindowCalled)
         return 1;
 
@@ -1202 +1204 @@
     dprintf(("MsgFormatFrame: old window rect (%d,%d)(%d,%d), new window (%d,%d)(%d,%d)", oldWindowRect.left, oldWindowRect.top, oldWindowRect.right, oldWindowRect.bottom, rectWindow.left, rectWindow.top, rectWindow.right, rectWindow.bottom));
 
-    if(fNoSizeMsg || !EqualRect(&client, &rectClient)) {
+    if(!CanReceiveSizeMsgs() || !EqualRect(&client, &rectClient)) {
         OSLibWinSetClientPos(getOS2WindowHandle(), rectClient.left, rectClient.top, getClientWidth(), getClientHeight(), getWindowHeight());
     }
@@ -1208 +1210 @@
 #if 1
 //this doesn't always work
-//  if(!fNoSizeMsg && (client.left != rectClient.left || client.top != rectClient.top))
-  if(!fNoSizeMsg && ((oldWindowRect.right - oldWindowRect.left < rectClient.left
+//  if(CanReceiveSizeMsgs() && (client.left != rectClient.left || client.top != rectClient.top))
+  if(CanReceiveSizeMsgs() && ((oldWindowRect.right - oldWindowRect.left < rectClient.left
                   || oldWindowRect.bottom - oldWindowRect.top < rectClient.top) ||
      (EqualRect(&oldWindowRect, &rectWindow) && (client.left != rectClient.left || client.top != rectClient.top))))
@@ -2447 +2449 @@
 #endif
 
-    if(!fCreateSetWindowPos)
+    //Note: Solitaire crashes when receiving WM_SIZE messages before WM_CREATE
+    if(state < STATE_POST_WMNCCREATE)
     {//don't change size; modify internal structures only
         //TODO: not 100% correct yet (activate)
@@ -2783 +2786 @@
    /* Windows hides the window first, then shows it again
     * including the WM_SHOWWINDOW messages and all */
-   if(fCreated && (getStyle() & WS_VISIBLE)) {
+   if(IsWindowCreated() && (getStyle() & WS_VISIBLE)) {
         ShowWindow(SW_HIDE);
         fShow = TRUE;
@@ -2832 +2835 @@
       WM_WINDOWPOSCHANGED notification messages.
    */
-   if(fCreated) {
+   if(state >= STATE_PRE_WMNCCREATE) {
         SetWindowPos(HWND_TOPMOST, 0, 0, 0, 0,
                      SWP_NOACTIVATE|SWP_NOMOVE|SWP_NOSIZE|(fShow? SWP_SHOWWINDOW : 0));
@@ -2864 +2867 @@
     {
         topwindow = GetWindowFromOS2FrameHandle(hwndTop);
-        if(topwindow) {
+        //Note: GetTopWindow can't return a window that hasn't processed
+        //      WM_NCCREATE yet (verified in NT4, SP6)
+        if(topwindow && topwindow->state >= STATE_POST_WMNCCREATE) {
             hwndTop = topwindow->getWindowHandle();
             RELEASE_WNDOBJ(topwindow);
             return hwndTop;
         }
+        if(topwindow) RELEASE_WNDOBJ(topwindow);
         return 0;
     }
     while(hwndTop) {
         topwindow = GetWindowFromOS2FrameHandle(hwndTop);
-        if(topwindow) {
+        //Note: GetTopWindow can't return a window that hasn't processed
+        //      WM_NCCREATE yet (verified in NT4, SP6)
+        if(topwindow && topwindow->state >= STATE_POST_WMNCCREATE) {
             hwndTop = topwindow->getWindowHandle();
             RELEASE_WNDOBJ(topwindow);
             return hwndTop;
         }
+        if(topwindow) RELEASE_WNDOBJ(topwindow);
         hwndTop = OSLibWinQueryWindow(hwndTop, QWOS_NEXT);
     }
@@ -3201 +3210 @@
         hwndRelated = OSLibWinQueryWindow(getOS2WindowHandle(), QWOS_TOP);
         window = GetWindowFromOS2FrameHandle(hwndRelated);
+
+        //Before a window has processed WM_NCCREATE:
+        //- GetWindow(parent, GW_CHILD) can't return that window handle
+        //(verified in NT4, SP6)
         if(window) {
-             hwndRelated = window->getWindowHandle();
-             RELEASE_WNDOBJ(window);
+             if(window->state >= STATE_POST_WMNCCREATE) {
+                 hwndRelated = window->getWindowHandle();
+                 RELEASE_WNDOBJ(window); 
+             }
+             else {
+                 hwndRelated = window->GetWindow(GW_HWNDNEXT);
+                 RELEASE_WNDOBJ(window); 
+             }
         }
         else hwndRelated = 0;
+
         break;
     }