Changeset 3821 for trunk/src/user32/dc.cpp

Timestamp:

Jul 15, 2000, 10:08:01 AM (25 years ago)

Author:

sandervl

Message:

RDW_INVALIDATE fix in RedrawWindow

File:

• trunk/src/user32/dc.cpp (modified) (6 diffs)

trunk/src/user32/dc.cpp

@@ -1 @@
-/* $Id: dc.cpp,v 1.65 2000-07-04 08:42:05 sandervl Exp $ */
+/* $Id: dc.cpp,v 1.66 2000-07-15 08:08:01 sandervl Exp $ */
 
 /*
@@ -1044 +1044 @@
             return FALSE;
         }
-        //TODO: If frame, exclude client window from update
-        if(redraw & RDW_FRAME_W) {
-                hwnd = wnd->getOS2WindowHandle();
-        }
-        else    hwnd = wnd->getOS2WindowHandle();
-
-   }
-
-   BOOL  IncludeChildren = redraw & RDW_ALLCHILDREN_W ? TRUE : FALSE;
+        hwnd = wnd->getOS2WindowHandle();
+   }
+
+   BOOL  IncludeChildren = (redraw & RDW_ALLCHILDREN_W) ? TRUE : FALSE;
    BOOL  success = TRUE;
    HPS   hpsTemp = NULLHANDLE;
@@ -1117 +1112 @@
         if (hrgn) {
             success = WinInvalidateRegion (hwnd, hrgnTemp, IncludeChildren);
+            if(IncludeChildren && WinQueryUpdateRect(hwnd, NULL) == FALSE) {
+                dprintf(("WARNING: WinQueryUpdateRect %x region %x returned false even though we just invalidated part of a window!!!", hwnd, hrgnTemp));
+                success = success = WinInvalidateRegion (hwnd, hrgnTemp, FALSE);
+            }
         }
-        else
+        else {
             success = WinInvalidateRect (hwnd, &rectl, IncludeChildren);
-
-#ifdef DEBUG
-        if(WinQueryUpdateRect(hwnd, NULL) == FALSE) {
+//SvL: If all children are included, then WinInvalidateRect is called
+//     with fIncludeChildren=1 -> rect of hwnd isn't invalidated if child(ren)
+//     overlap(s) the specified rectangle completely (EVEN if window doesn't 
+//     have WS_CLIPCHILREN!)
+//     -> example: XWing vs Tie Fighter install window
+//     WinInvalidateRect with fIncludeChildren=0 invalidates both the parent
+//     and child windows
+//SvL: Can't always set fIncludeChildren to FALSE or else some controls in
+//     the RealPlayer setup application aren't redrawn when invalidating
+//     their parent
+//     SO: Check if IncludeChildren is set and part of the window is invalid
+//         If not -> call WinInvalidateRect with IncludeChildren=0 to force
+//         the window rectangle to be invalidated
+//
+            if(IncludeChildren && WinQueryUpdateRect(hwnd, NULL) == FALSE) {
                 dprintf(("WARNING: WinQueryUpdateRect %x (%d,%d)(%d,%d) returned false even though we just invalidated part of a window!!!", hwnd, rectl.xLeft, rectl.yBottom, rectl.xRight, rectl.yTop));
-        }
-#endif
+                success = WinInvalidateRect (hwnd, &rectl, FALSE);
+            }
+        }
 
         if (!success) goto error;
@@ -1136 +1148 @@
         if (WinQueryUpdateRect (hwnd, NULL))
         {
-            if (!pRect && !hrgn)
+            if(!pRect && !hrgn) {
                 success = WinValidateRect (hwnd, NULL, IncludeChildren);
+            }
             else
-            if (hrgn) {
+            if(hrgn) {
                 success = WinValidateRegion (hwnd, hrgnTemp, IncludeChildren);
             }
-            else
+            else {
                 success = WinValidateRect (hwnd, &rectl, IncludeChildren);
-            if (!success) goto error;
+            }
+            if(!success) goto error;
         }
    }
@@ -1235 +1249 @@
    else dprintf(("InvalidateRect %x NULL erase=%d", hwnd, erase));
    result = RedrawWindow (hwnd, pRect, NULLHANDLE,
-//SvL: If all children are included, then WinInvalidateRect is called
-//     with fIncludeChildren=1 -> rect of hwnd isn't invalid if child(ren)
-//     overlap(s) it completely (EVEN if window doesn't have WS_CLIPCHILREN!)
-//     -> example: XWing vs Tie Fighter install window
-//     WinInvalidateRect with fIncludeChildren=0 invalidates both the parent
-//     and child windows
-//                          RDW_ALLCHILDREN_W | RDW_INVALIDATE_W |
-                          RDW_NOCHILDREN_W | RDW_INVALIDATE_W |
+                          RDW_ALLCHILDREN_W | RDW_INVALIDATE_W |
                           (erase ? RDW_ERASE_W : RDW_NOERASE_W) |
                           (hwnd == NULLHANDLE ? RDW_UPDATENOW_W : 0));
@@ -1255 +1262 @@
    dprintf(("InvalidateRgn %x %x erase=%d", hwnd, hrgn, erase));
    result = RedrawWindow (hwnd, NULL, hrgn,
-//SvL: If all children are included, then WinInvalidateRegion is called
-//     with fIncludeChildren=1 -> region of hwnd isn't invalid if child(ren)
-//     overlap(s) it completely (EVEN if window doesn't have WS_CLIPCHILREN!)
-//     -> example: XWing vs Tie Fighter install window
-//     WinInvalidateRegion with fIncludeChildren=0 invalidates both the parent
-//     and child windows
-//                          RDW_ALLCHILDREN_W | RDW_INVALIDATE_W |
-                          RDW_NOCHILDREN_W | RDW_INVALIDATE_W |
+                          RDW_ALLCHILDREN_W | RDW_INVALIDATE_W |
                           (erase ? RDW_ERASE_W : RDW_NOERASE_W) |
                           (hwnd == NULLHANDLE ? RDW_UPDATENOW_W : 0));