Changeset 22134 for trunk/src/user32/win32wbase.cpp

Timestamp:

Jul 25, 2017, 4:32:42 PM (8 years ago)

Author:

dmik

Message:

user32: Do not touch user data of foreign OS/2 windows.

This is plain wrong as these windows' classes are not created by Odin so
it must not make assumptions about window data usage. It fixes Firefox malfunction
when using Flash, see ​https://github.com/bitwiseworks/mozilla-os2/issues/229.

File:

• trunk/src/user32/win32wbase.cpp (modified) (1 diff)

trunk/src/user32/win32wbase.cpp

@@ -220 +220 @@
     }
 
-    OSLibWinSetVisibleRegionNotify(OS2Hwnd, FALSE);
-    OSLibWinSetWindowULong(OS2Hwnd, OFFSET_WIN32WNDPTR, 0);
-    OSLibWinSetWindowULong(OS2Hwnd, OFFSET_WIN32PM_MAGIC, 0);
+    if (!isFakeWindow()) {   
+        OSLibWinSetVisibleRegionNotify(OS2Hwnd, FALSE);
+        OSLibWinSetWindowULong(OS2Hwnd, OFFSET_WIN32WNDPTR, 0);
+        OSLibWinSetWindowULong(OS2Hwnd, OFFSET_WIN32PM_MAGIC, 0);
+    }
 
     if(fDestroyAll) {