Changeset 22024 for trunk/src/kernel32/npipe.cpp

Timestamp:

Sep 27, 2012, 4:08:58 PM (13 years ago)

Author:

dmik

Message:

kernel32: Fix inverted return values in dummy HMDeviceHandler implementations.

This in particular affected GetFileInformationByHandle and other APIs. Some applications
(like Flash 10.1+) could be completely confused by the fact that the unimplemented API
returns success.

File:

• trunk/src/kernel32/npipe.cpp (modified) (2 diffs)

trunk/src/kernel32/npipe.cpp

@@ -360 +360 @@
                                 LPOVERLAPPED lpo)
 {
-  BOOL      lpResult;                /* result from the device handler's API */
+  BOOL      bResult;                 /* result from the device handler's API */
   PHMHANDLE pHMHandle;       /* pointer to the handle structure in the table */
 
@@ -371 +371 @@
   }
 
-  lpResult = pHMHandle->pDeviceHandler->TransactNamedPipe(&pHMHandle->hmHandleData,
-                                                          lpvWriteBuf,
-                                                          cbWriteBuf,
-                                                          lpvReadBuf,
-                                                          cbReadBuf,
-                                                          lpcbRead,
-                                                          lpo);
-
-  return (lpResult);                                  /* deliver return code */
+  bResult = pHMHandle->pDeviceHandler->TransactNamedPipe(&pHMHandle->hmHandleData,
+                                                         lpvWriteBuf,
+                                                         cbWriteBuf,
+                                                         lpvReadBuf,
+                                                         cbReadBuf,
+                                                         lpcbRead,
+                                                         lpo);
+
+  return (bResult);                                  /* deliver return code */
 }