Changeset 22024 for trunk/src/kernel32/hmopen32.cpp

Timestamp:

Sep 27, 2012, 4:08:58 PM (13 years ago)

Author:

dmik

Message:

kernel32: Fix inverted return values in dummy HMDeviceHandler implementations.

This in particular affected GetFileInformationByHandle and other APIs. Some applications
(like Flash 10.1+) could be completely confused by the fact that the unimplemented API
returns success.

File:

• trunk/src/kernel32/hmopen32.cpp (modified) (3 diffs)

trunk/src/kernel32/hmopen32.cpp

@@ -68 +68 @@
            ulRequestCode));
 
-  return(ERROR_INVALID_FUNCTION);
+  SetLastError(ERROR_INVALID_FUNCTION);
+  return FALSE;
 }
 
@@ -153 +154 @@
 
 /*****************************************************************************
- * Name      : DWORD HMDeviceOpen32Class::GetFileInformationByHandle
+ * Name      : BOOL HMDeviceOpen32Class::GetFileInformationByHandle
  * Purpose   : determine the handle type
  * Parameters: PHMHANDLEDATA               pHMHandleData
@@ -165 +166 @@
  *****************************************************************************/
 
-DWORD HMDeviceOpen32Class::GetFileInformationByHandle(PHMHANDLEDATA               pHMHandleData,
-                                                      BY_HANDLE_FILE_INFORMATION* pHFI)
+BOOL HMDeviceOpen32Class::GetFileInformationByHandle(PHMHANDLEDATA               pHMHandleData,
+                                                     BY_HANDLE_FILE_INFORMATION* pHFI)
 {
   dprintfl(("KERNEL32: HandleManager::Open32::GetFileInformationByHandle %s(%08xh,%08xh)\n",