Changeset 22024 for trunk/src/kernel32/HandleManager.cpp

Timestamp:

Sep 27, 2012, 4:08:58 PM (13 years ago)

Author:

dmik

Message:

kernel32: Fix inverted return values in dummy HMDeviceHandler implementations.

This in particular affected GetFileInformationByHandle and other APIs. Some applications
(like Flash 10.1+) could be completely confused by the fact that the unimplemented API
returns success.

File:

• trunk/src/kernel32/HandleManager.cpp (modified) (2 diffs)

trunk/src/kernel32/HandleManager.cpp

@@ -2372 +2372 @@
 {
   int       iIndex;                           /* index into the handle table */
-  BOOL      dwResult;                /* result from the device handler's API */
+  BOOL      bResult;                 /* result from the device handler's API */
   PHMHANDLE pHMHandle;       /* pointer to the handle structure in the table */
 
@@ -2388 +2388 @@
       return ERROR_SYS_INTERNAL;
 
-  dwResult = pHMHandle->pDeviceHandler->UnlockFileEx(&pHMHandle->hmHandleData,
-                                                     dwReserved,
-                                                     nNumberOfBytesToLockLow,
-                                                     nNumberOfBytesToLockHigh,
-                                                     lpOverlapped);
-
-  return (dwResult);                                  /* deliver return code */
+  bResult = pHMHandle->pDeviceHandler->UnlockFileEx(&pHMHandle->hmHandleData,
+                                                    dwReserved,
+                                                    nNumberOfBytesToLockLow,
+                                                    nNumberOfBytesToLockHigh,
+                                                    lpOverlapped);
+
+  return (bResult);                                   /* deliver return code */
 }