Changeset 21983 for trunk/src/kernel32/thread.cpp

Timestamp:

Mar 18, 2012, 8:34:29 PM (13 years ago)

Author:

dmik

Message:

kernel32: Fix crash in CreateThread() (r21981 regression).

File:

• trunk/src/kernel32/thread.cpp (modified) (2 diffs)

trunk/src/kernel32/thread.cpp

@@ -698 +698 @@
     DWORD            rc;
     TEB             *winteb    = (TEB *)me->teb;
-
+    DWORD            cbCommitStack = me->cbCommitStack;
+
+    // @todo the approach to copy all fields to local vars and delete the
+    // instance is dumb, fix it later
     delete(me);    //only called once
+    me = 0;
 
     if(InitializeThread(winteb) == FALSE) {
@@ -723 +727 @@
     dprintf(("Stack top 0x%x, stack end 0x%x", winteb->stack_top, winteb->stack_low));
 
-    if (me->cbCommitStack) {
+    if (cbCommitStack) {
         // pre-commit part of the stack
+        dprintf(("Pre-commit 0x%x bytes of stack", me->cbCommitStack));
         PBYTE stack = ((PBYTE) (winteb->stack_top)) - 1;
         for (int i = 0; i < (me->cbCommitStack + 0xFFF) / 0x1000; i++) {