Changeset 1695 for trunk/src/shell32/shlview.cpp

Timestamp:

Nov 10, 1999, 11:14:12 PM (26 years ago)

Author:

phaller

Message:

Add: updated to WINE19991108

File:

• trunk/src/shell32/shlview.cpp (modified) (13 diffs)

trunk/src/shell32/shlview.cpp

@@ -1 @@
-/* $Id: shlview.cpp,v 1.4 1999-11-02 20:38:48 phaller Exp $ */
+/* $Id: shlview.cpp,v 1.5 1999-11-10 22:13:10 phaller Exp $ */
 /*
  * ShellView
@@ -8 +8 @@
  *  Release() ???
  *
+ *  FIXME: There is still a design problem in this implementation.
+ * This implementation is more or less ok for file system folders
+ * but there are many more kinds of folders.
+ * The shellview is not supposed to know much about the colums
+ * appearing in the view. To fix this it should use the IShellFolder2
+ * interface when possible to get the informations dynamically
+ * this will take a lot of work to implemet and wont likely not
+ * be done in near future
+ * Please considder this when code new features. Mail me if you
+ * are in doubt how to do things. (jsch 25/10/99)
+ *
+ * FIXME: Set the buttons in the filedialog according to the view state
+
  */
 
@@ -227 +240 @@
  * change the style of the listview control
  */
-
 static void SetStyle(IShellViewImpl * This, DWORD dwAdd, DWORD dwRemove)
 {
@@ -285 +297 @@
 /**********************************************************
 * ShellView_InitList()
+*
+* NOTES
+*  FIXME: the headers should depend on the kind of shellfolder
+*  thats creating the shellview. this hack implements only the
+*  correct headers for a filesystem folder (jsch 25/10/99)
 */
 static BOOL ShellView_InitList(IShellViewImpl * This)
@@ -304 +321 @@
    ListView_InsertColumnA(This->hWndList, 0, &lvColumn);
 
-   lvColumn.cx = 80;
+   lvColumn.cx = 60;
    LoadStringA(shell32_hInstance, IDS_SHV_COLUMN2, szString, sizeof(szString));
    ListView_InsertColumnA(This->hWndList, 1, &lvColumn);
 
-   lvColumn.cx = 170;
+   lvColumn.cx = 120;
    LoadStringA(shell32_hInstance, IDS_SHV_COLUMN3, szString, sizeof(szString));
    ListView_InsertColumnA(This->hWndList, 2, &lvColumn);
@@ -356 +373 @@
  *
  * NOTES
+ * FIXME: function does what ShellView_CompareItems is supposed to do.
+ * unify it and figure out how to use the undocumented first parameter
+ * of IShellFolder_CompareIDs to do the job this function does and
+ * move this code to IShellFolder.
+ * make LISTVIEW_SORT_INFO obsolete
+ * the way this function works is only usable if we had only
+ * filesystemfolders  (25/10/99 jsch)
  *
  */
@@ -968 +992 @@
      case 0x32:
      case 0x33:
-       ListView_SortItems(This->hWndList, ShellView_ListViewCompareItems, (LPARAM) (dwCmdID - 0x30));
+       This->ListViewSortInfo.nHeaderID = (LPARAM) (dwCmdID - 0x30);
+       This->ListViewSortInfo.bIsAscending = TRUE;
+       This->ListViewSortInfo.nLastHeaderID = This->ListViewSortInfo.nHeaderID;
+       ListView_SortItems(This->hWndList, ShellView_ListViewCompareItems, (LPARAM) (&(This->ListViewSortInfo)));
+       CheckToolbar(This);
        break;
 
@@ -1021 +1049 @@
 
      case LVN_COLUMNCLICK:
-     {
             This->ListViewSortInfo.nHeaderID = lpnmlv->iSubItem;
             if(This->ListViewSortInfo.nLastHeaderID == This->ListViewSortInfo.nHeaderID)
@@ -1034 +1061 @@
 
        ListView_SortItems(lpnmlv->hdr.hwndFrom, ShellView_ListViewCompareItems, (LPARAM) (&(This->ListViewSortInfo)));
-
        break;
-     }
 
      case LVN_GETDISPINFOA:
@@ -1326 +1351 @@
    ICOM_THIS(IShellViewImpl, iface);
 
+#if 0
    FIXME("(%p)->(%p: hwnd=%x msg=%x lp=%lx wp=%x) stub\n",This,lpmsg, lpmsg->hwnd, lpmsg->message, lpmsg->lParam, lpmsg->wParam);
-
-
-   switch (lpmsg->message)
-   { case WM_KEYDOWN:                    TRACE("-- key=0x04%x",lpmsg->wParam) ;
-   }
-   return NOERROR;
+#endif
+
+   if ((lpmsg->message>=WM_KEYFIRST) && (lpmsg->message>=WM_KEYLAST))
+   {
+     TRACE("-- key=0x04%x",lpmsg->wParam) ;
+   }
+   return S_FALSE; /* not handled */
 }
 
@@ -1348 +1375 @@
    ICOM_THIS(IShellViewImpl, iface);
 
+/*
    CHAR  szName[MAX_PATH];
+*/
    LRESULT  lResult;
    int   nPartArray[1] = {-1};
@@ -1367 +1396 @@
    {
 
+/*
+   GetFolderPath is not a method of IShellFolder
      IShellFolder_GetFolderPath( This->pSFParent, szName, sizeof(szName) );
-
+*/
      /* set the number of parts */
      IShellBrowser_SendControlMsg(This->pShellBrowser, FCW_STATUS, SB_SETPARTS, 1,
@@ -1374 +1405 @@
 
      /* set the text for the parts */
+/*
      IShellBrowser_SendControlMsg(This->pShellBrowser, FCW_STATUS, SB_SETTEXTA,
                                          0, (LPARAM)szName, &lResult);
+*/
    }