Changeset 959 for trunk/dll/command.c

Timestamp:

Feb 18, 2008, 1:47:31 AM (17 years ago)

Author:

Gregg Young

Message:

Use xfree where appropriate. Check that buffer exists following all xmallocs. Stopped at eas.c with xfree checking. One remaining xmalloc without test in dirsize.c

File:

• trunk/dll/command.c (modified) (6 diffs)

trunk/dll/command.c

@@ -305 +305 @@
   while (info) {
     next = info->next;
-    free(info->title);
-    free(info->cl);
+    xfree(info->title);
+    xfree(info->cl);
     free(info);
     info = next;
@@ -353 +353 @@
         info->flags = atol(flags);
         if (!info->cl || !info->title) {
-          if (info->cl)
-            free(info->cl);
-          if (info->title)
-            free(info->title);
+          xfree(info->cl);
+          xfree(info->title);
           free(info);
           break;
@@ -459 +457 @@
             cmdtail = info->prev;
         }
-        free(info->cl);
-        free(info->title);
+        xfree(info->cl);
+        xfree(info->title);
         free(info);
         return TRUE;
@@ -625 +623 @@
 
         pszWorkBuf = xmalloc(MAXCOMLINESTRG, pszSrcFile, __LINE__);
+        if (!pszWorkBuf)
+          break; //already complained
         memset(&temp, 0, sizeof(COMMAND));
         WinQueryDlgItemText(hwnd, CMD_CL, sizeof(temp.cl), temp.cl);
@@ -721 +721 @@
 
         pszWorkBuf = xmalloc(MAXCOMLINESTRG, pszSrcFile, __LINE__);
+        if (!pszWorkBuf)
+          break; //already complained
         memset(&temp, 0, sizeof(COMMAND));
         WinQueryDlgItemText(hwnd, CMD_CL, sizeof(temp.cl), temp.cl);
@@ -823 +825 @@
 
         pszWorkBuf = xmalloc(MAXCOMLINESTRG, pszSrcFile, __LINE__);
+        if (!pszWorkBuf)
+          break; //already complained
         memset(&temp, 0, sizeof(COMMAND));
         WinQueryDlgItemText(hwnd, CMD_CL, sizeof(temp.cl), temp.cl);