Changeset 871 for trunk/dll/inis.c

Timestamp:

Nov 17, 2007, 2:13:23 AM (18 years ago)

Author:

Steven Levine

Message:

Correct hex edit buffer sizing to avoid data loss
Detect and report overflows in fixup()

File:

• trunk/dll/inis.c (modified) (3 diffs)

trunk/dll/inis.c

@@ -20 +20 @@
   19 Apr 07 SHL Use FreeDragInfoData.  Add more drag/drop error checks.
   20 Aug 07 GKY Move #pragma alloc_text to end for OpenWatcom compat
+  16 Nov 07 SHL Ensure fixup buffer sufficiently large
 
 ***********************************************************************/
@@ -1216 +1217 @@
 {
   INIDATA *inidata;
+  size_t l;
 
   switch (msg) {
@@ -1261 +1263 @@
                      GetPString(IDS_INIBINARYDATASKIPTEXT)) == MBID_CANCEL)
             WinDismissDlg(hwnd, 0);
-          p = xmallocz(inidata->datalen * 2, pszSrcFile, __LINE__);
+          l = inidata->datalen * 4 + 1;
+          p = xmallocz(l, pszSrcFile, __LINE__);
           if (p) {
-            fixup(inidata->data, p, inidata->datalen * 2, inidata->datalen);
+            fixup(inidata->data, p, l, inidata->datalen);
             WinSetDlgItemText(hwnd, IAD_DATA, p);
             free(p);