Changeset 1915 for trunk/dll/getnames.c

Timestamp:

Nov 1, 2025, 7:27:49 PM (44 hours ago)

Author:

Gregg Young

Message:

Improve readability of insert_filename (use 0,1,2 instead of FALSE, TRUE,2 for loadit). Fix it so pszIDrive is only set from lastfilename if filename is NULL.

File:

• trunk/dll/getnames.c (modified) (4 diffs)

trunk/dll/getnames.c

@@ -233 +233 @@
   fdlg.cbSize = (ULONG) sizeof(FILEDLG);
   fdlg.fl = FDS_CENTER | FDS_OPEN_DIALOG;
-  if (!loadit) {
+  if (loadit == 0) {
     fdlg.pszTitle = (PSZ)GetPString(IDS_ENTERFILEINSERTTEXT);
     fdlg.pszOKButton = (PSZ)GetPString(IDS_INSERTTEXT);
   }
-  else if (loadit == TRUE) {
+  else if (loadit == 1) {
     fdlg.pszTitle = (PSZ)GetPString(IDS_ENTERFILELOADTEXT);
     fdlg.pszOKButton = (PSZ)GetPString(IDS_LOADTEXT);
@@ -251 +251 @@
     fdlg.pszIDrive = pdrive;
   }
-  else if (*lastfilename) {
+  else if (!*filename && *lastfilename) {
     *drive = *lastfilename;
     drive[1] = ':';
@@ -267 +267 @@
       }
     }
-    if (!loadit || loadit == TRUE)
+    if (loadit < 2)
       strcat(fdlg.szFullFile, PCSZ_STARDOTTXT);
     else
@@ -341 +341 @@
     fdlg.pszIDrive = pdrive;
   }
-  else if (*lastfilename) {
+  else if (!*filename && *lastfilename) {
     *drive = *lastfilename;
     drive[1] = ':';