Changeset 1780 for trunk/dll/arccnrs.c

Timestamp:

Jun 28, 2014, 8:05:22 PM (11 years ago)

Author:

Gregg Young

Message:

Fixed errors found by cppcheck. Most had the potential to cause difficult to reproduce traps. Also fixed retry code for failure to create an archive work directory and the failure of the mailto code to drop trailing >.

File:

• trunk/dll/arccnrs.c (modified) (3 diffs)

trunk/dll/arccnrs.c

@@ -105 +105 @@
                 or gzip.exe on TAR.B/GZ archives.
   06 Apr 14 GKY Removed all BZ/GZ checks
+  28 Jun 14 GKY Fix errors identified with CPPCheck; Fix retry to create workdir code
 
 ***********************************************************************/
@@ -2489 +2490 @@
                 for (z = 0; z < 99; z++) {
                   was++;
-                  sprintf(p, "%03x");
+                  sprintf(p, "%03x", was);
                   rc = DosCreateDir(dcd->workdir, 0);
                   if (!rc || rc != ERROR_ACCESS_DENIED)
@@ -2496 +2497 @@
               }
             }
-            if (rc)
+            if (rc) {
               PostMsg(hwnd, WM_CLOSE, MPVOID, MPVOID);
-            return 0;
+              return 0;
+            }
           }
         }