Changeset 99 for trunk/bootcode/special/lvm.asm

Timestamp:

Apr 8, 2017, 12:26:53 AM (8 years ago)

Author:

Ben Rietbroek

Message:

LVM CRC-check was always forced to be successful [v1.1.1-testing]

Wow, this is a naughty one !
Function 'DriveIO_LVMSectorValid' was introduced in 'DRIVEIO.ASM' in
r30: http://trac.netlabs.org/air-boot/changeset/30/#file19

The CRC-check was always forced to OK with 'stc' because it always
failed. This failing was the result of checking the CRC *before* the
'LVM_InitCRCTable' was called. So AirBoot never catched bad LVM CRCs!

The LVM stuff is now being revisited, but we'll correct it here for the
record.

CAUTION:
This is a testbuild !
AirBoot uses the BIOS to access disks and a small coding error can trash
partition tables or other vital disk structures. You are advised to make
backups of TRACK0 and EBRs before using this testbuild. More info at:
​https://rousseaux.github.io/netlabs.air-boot/pdf/AirBoot-v1.1.0-manual.pdf

File:

• trunk/bootcode/special/lvm.asm (modified) (1 diff)

trunk/bootcode/special/lvm.asm

@@ -137 +137 @@
         call    LVM_CheckSectorCRC
         ; Force valid !!!
-        stc
+        ;~ stc
 
     DriveIO_LVMSectorValid_End: