Changeset 86 for trunk/src/os2ahci/ahci.c

Timestamp:

Apr 28, 2011, 7:41:44 PM (14 years ago)

Author:

chris

Message:

• Cosmetic changes to comments
• Fix number to string conversion for negative [decimal] numbers (the minus sign was at the wrong location and the two's complement was not respected). This functionality was unused so far but popped up during a code review.

File:

• trunk/src/os2ahci/ahci.c (modified) (2 diffs)

trunk/src/os2ahci/ahci.c

@@ -1236 +1236 @@
 
 /******************************************************************************
- * set device into IDLE mode (spin down); this was used during
- * debugging/testing and is still there since it does not hurt...
+ * Set device into IDLE mode (spin down); this was used during
+ * debugging/testing and is now unused; it's still there in case we need it
+ * again...
+ *
  * If 'idle' is != 0, the idle timeout is set to 5 seconds, otherwise it
  * is turned off.
@@ -1258 +1260 @@
  * the driver-level spinlock when actually changing the driver state (IORB
  * queues, ...)
+ *
+ * NOTE: OS/2 expects the carry flag set upon return from an interrupt
+ *       handler if the interrupt has not been handled. We do this by
+ *       shifting the return code from this function one bit to the right,
+ *       thus the return code must set bit 0 in this case.
  */
 int ahci_intr(u16 irq)