Changeset 82 for trunk/src/os2ahci/ata.h

Timestamp:

Mar 2, 2011, 11:48:03 PM (14 years ago)

Author:

chris

Message:

Version 1.09
============

• Added new command line parameter, "/4", which will force a track size of 56 sectors to be reported in geometry requests. This will improve performance for newer HDs with 4K sectors and file systems which use block sizes larger than 512 bytes (FAT, JFS, ...) because all partitions will be aligned on 4K (8 sector) boundaries.

• Changed AP_DEVICE parameter to ata_cmd() from 16 bits to 8 bits -- the corresponding field in ATA_CMD has always been 8 bits and there's no point discarding the lower 8 bits of the AP_DEVICE parameter as a general rule. Besides, it confused me in the end...

• Always return some kind of error in ata_req_sense() because this function will only be called when we received an error interrupt; atapi_req_sense() already does this.

• Cosmetic changes

File:

• trunk/src/os2ahci/ata.h (modified) (2 diffs)

trunk/src/os2ahci/ata.h

@@ -21 +21 @@
 
 /* -------------------------- macros and constants ------------------------- */
+
+/******************************************************************************
+ * Right now, os2ahci uses a fixed sector size of 512 bytes for hard disks.
+ * This may change in the future...
+ */
+#define ATA_SECTOR_SIZE    512
 
 /******************************************************************************
@@ -411 +417 @@
   AP_SECTOR_28,    /* [u32]               28-bit sector address              */
   AP_SECTOR_48,    /* [u32, u16]          48-bit sector address              */
-  AP_DEVICE,       /* [u16]               ATA cmd "device" field (LSB masked) */
+  AP_DEVICE,       /* [u16]               ATA cmd "device" field             */
   AP_SGLIST,       /* [void _far *, u16]  buffer S/G (SCATGATENTRY/count)    */
   AP_VADDR,        /* [void _far *, u16]  buffer virtual address (buf/len)   */