Changeset 69 for trunk/src/os2ahci/atapi.c

Timestamp:

Jan 7, 2011, 4:54:46 PM (15 years ago)

Author:

markus

Message:

fixed ATAPI packet commands; added cache flush in shutdown handler; allow write cache for NCQ commands

File:

• trunk/src/os2ahci/atapi.c (modified) (4 diffs)

trunk/src/os2ahci/atapi.c

@@ -75 +75 @@
   /* translate read command to SCSI/ATAPI READ12 command.
    * READ12 seems to be the most supported READ variant - according to MMC,
-   * and its enough even for BluRay.
+   * and it's enough even for BluRay.
    */
   memset(&cdb, 0x00, sizeof(cdb));
@@ -167 +167 @@
                AP_SGLIST, pt->pSGList, pt->cSGList,
                AP_WRITE, !(pt->Flags & PT_DIRECTION_IN),
-               /* TODO: do we have to clear DMA_TO_HOST bit for
-                * write, mode select etc. commands?
-                */
-               AP_FEATURES,  ATAPI_FEAT_DMA | ATAPI_FEAT_DMA_TO_HOST,
+               AP_FEATURES, ATAPI_FEAT_DMA,
+               AP_FEATURES, (pt->Flags & PT_DIRECTION_IN) ? ATAPI_FEAT_DMA_TO_HOST : 0,
                AP_END);
 
@@ -224 +222 @@
     iorb_seterr(iorb, IOERR_CMD_SGLIST_BAD);
 
-  } else {
+  } else if (rc < 0) {
     /* we failed to get info about an error -> return
      * non specific device error
@@ -242 +240 @@
   ADD_WORKSPACE _far *aws = add_workspace(iorb);
   ATAPI_SENSE_DATA *psd = (ATAPI_SENSE_DATA *) aws->buf;
+
+  ddphex(psd, sizeof(psd), "sense buffer:\n");
 
   /* map sense data to some IOERR_ value */