Changeset 147 for trunk/src/os2ahci/os2ahci.c

Timestamp:

Feb 21, 2013, 10:37:43 AM (12 years ago)

Author:

rousseau

Message:

Changed the default value of the /r option (TRACK ticket #21)

Reason for the change

o Snip from the TRAC ticket

<snip>

One thing that keeps coming up in some cases is that on systems with an
Intel disc controller you need the /R option specified.
In some cases the system is able to boot with from the CD but it does
not recognize the hard disc.
Using the /R option fixes.

</snip>

o Logic suggests...

Since /r was already turned on when an Intel AHCI controller was detected
to be in SATA mode, this report seems to imply that for some obscure reason
a port reset is needed even when the BIOS programmed the controller in
AHCI mode. This would suggest some faulty BIOS initialization.

Changed behavior

o The /r option is now on by default

It can be turned off by specifying /!r on the driver command-line.
However, when the [Intel] AHCI controller was found to be initialized
by the BIOS in SATA mode, ports will always be reset, even when /!r
is specified. This seems to be an [Intel] AHCI controller requirement.

Comment reference

o From a comment in ahci.c around line 146

<snip>

Adapter is not in AHCI mode and the spec says a COMRESET is
required when switching from SATA to AHCI mode and vice versa.

</snip>

File:

• trunk/src/os2ahci/os2ahci.c (modified) (2 diffs)

trunk/src/os2ahci/os2ahci.c

@@ -87 +87 @@
 int             debug = 0;         /* if > 0, print debug messages to COM1 */
 int             thorough_scan = 1; /* if != 0, perform thorough PCI scan */
-int             init_reset;        /* if != 0, reset ports during init */
+int             init_reset = 1;    /* if != 0, reset ports during init */
 int             force_write_cache; /* if != 0, force write cache */
 int             verbosity = 1;     /* == 1 -> show sign on banner
@@ -265 +265 @@
       case 'r':
         /* reset ports during initialization */
-        init_reset = 1;
+        init_reset = !invert_option;
         break;