Move AAC to Utility Process and avoid extra layers of IPC for Android
Categories
(Core :: Security: Process Sandboxing, enhancement, P2)
Tracking
()
People
(Reporter: gerard-majax, Assigned: gerard-majax)
References
Details
Attachments
(1 file)
https://phabricator.services.mozilla.com/D145785#4813745
I am okay with most changes, but as alwu mentioned in the comment, adding AndroidDecoderModule doesn't really move AAC decoding from content to utility. I would suggest leaving AndroidDecoderModule out of the utility, as to how rdd behaves and testing audio formats other than AAC in test_utility_audio_on.html for now. A follow-up bug that makes Android codecs run in utility should be filed too.
Updated•2 years ago
|
Comment 1•2 years ago
•
|
||
I think the solution for this should be replacing RemoteAudioDecoder
[1] with one that calls Android NDK media codec API[2].
The topic of rewriting the Android decoder module using NDK to work with the RDD architecture was brought up before but we never put it in high enough priority and to cover all existing features (both audio/video decoding & encoding with hardware video buffers for rendering) is not a simple task. Limit the scope to audio (AAC only really) decoding support would be much easier to archive and should be no more the 2 man-months for someone with Android NDK and media codec API experience, IMHO.
[1] https://searchfox.org/mozilla-central/source/dom/media/platforms/android/RemoteDataDecoder.cpp#356
[2] https://developer.android.com/ndk/guides/stable_apis#libmediandk
Comment hidden (off-topic) |
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 3•1 year ago
|
||
Description
•