Move Downloads Spam UX work behind a pref
Categories
(Firefox :: Downloads Panel, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox94 | --- | fixed |
People
(Reporter: mtigley, Assigned: mtigley)
References
Details
Attachments
(1 file)
We should put the existing Downloads Spam UX work behind a pref as its being developed. Currently, we only have this callsite here: https://searchfox.org/mozilla-central/rev/cf90d36979cc9c411cea50fadedfb12df827908b/uriloader/exthandler/nsExternalHelperAppService.cpp#1686-1689. We'll want to migrate this check from the browser.download.improvements_to_download_panel pref to a new one, perhaps browser.download.download_spam_enabled?
|
Assignee | |
Comment 1•3 years ago
|
||
|
||
Updated•3 years ago
|
Pushed by mtigley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/03a33d194255 Move downloads spam prevention work behind a pref. r=mhowell
|
||
Comment 3•3 years ago
|
||
Backed out for causing mochitest failures on browser_download_spam_permissions.js
|
|
Assignee | |
Comment 4•3 years ago
•
|
||
(In reply to Cristian Tuns from comment #3)
Backed out for causing mochitest failures on browser_download_spam_permissions.js
The test timed out here because it's expecting the downloads to be saved directly to disk, which is enabled by the "browser.download.improvements_to_download_panel" pref. I've updated the revision to have this pref set.
Try push: https://treeherder.mozilla.org/jobs?repo=try&revision=b583fe84152c95fd9cf03483bc026ee1d0986c78
Pushed by mtigley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/18bc50e4ae9c Move downloads spam prevention work behind a pref. r=mhowell
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
I have this bug now.
It started a few months ago (not sure of the exact date) when I tried to download pdfs from some sites.
Now the window fills with the pdf displayed inline and the address bar shows:
blob:https://site.example.com/some.pdf
I have to use the back button to return to the site
|
||
Comment 9•2 years ago
|
||
(In reply to Kodey from comment #8)
I have this bug now.
It started a few months ago (not sure of the exact date) when I tried to download pdfs from some sites.
Now the window fills with the pdf displayed inline and the address bar shows:
blob:https://site.example.com/some.pdf
I have to use the back button to return to the site
This is unrelated to this bug and is fixed to open in a new tab (rather than the same tab) in Firefox 101, which is being released this week. There's more context in bug 1756980. If you want to save a copy of the PDF, you can do so with Ctrl-S (cmd-S on a mac), or using the 'save' button on the top right, in the PDF viewer toolbar.
Description
•