No shield icon in the url bar when the top-level page is sandboxed
Categories
(Firefox :: Protections UI, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox85 | --- | verified |
People
(Reporter: dimi, Assigned: pbz)
References
()
Details
Attachments
(3 files, 1 obsolete file)
Details can be found in Bug 1647681 Comment 0.
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
Assignee | |
Comment 1•4 years ago
•
|
||
Seems like the protection panel works fine with a nullprincipal, except for the TP toggle. It's currently disabled by the check here:
https://searchfox.org/mozilla-central/rev/f081504642a115cb8236bea4d8250e5cb0f39b02/toolkit/components/antitracking/ContentBlockingAllowList.jsm#49 (isContentPrincipal).
Disabling / hiding the toggle for the top level sandbox case would work, but then the user loses the ability to turn TP off. I'll look into how we can persist the trackingprotection permission for the top level sandbox case.
| Comment hidden (obsolete) |
|
|
Assignee | |
Comment 3•4 years ago
|
||
Depends on D98054
|
|
Assignee | |
Comment 4•4 years ago
|
||
|
|
Assignee | |
Comment 5•4 years ago
|
||
Depends on D98055
|
||
Updated•4 years ago
|
Pushed by pzuhlcke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e7c2aad1aade Don't set contentBlockingAllowListPrincipal to NullPrincipal for sandboxed documents. r=timhuang,emilio https://hg.mozilla.org/integration/autoland/rev/0796dd620879 Test that we show the protection UI for top level sandboxed pages. r=timhuang https://hg.mozilla.org/integration/autoland/rev/101d2f54673f Added test for the contentBlockingAllowListPrincipal. r=timhuang
|
||
Comment 7•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e7c2aad1aade
https://hg.mozilla.org/mozilla-central/rev/0796dd620879
https://hg.mozilla.org/mozilla-central/rev/101d2f54673f
|
||
Updated•4 years ago
|
|
||
Comment 8•4 years ago
|
||
I have managed to reproduce this bug using the test page from bug 1647681#c0, the shield icon was not displayed on an affected Nightly build (79.0a1, 20200623213840).
The issue is verified as fixed on latest Beta 85.0b4 (20201220193140) under macOS 10.15, Windows 10 x64 and Ubuntu 18.04 x64.
Description
•