JS: tolerate out of order requests in TypeScript extractor #14167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgerf
force-pushed
the
ts/tolerate-out-of-order-requests
branch
from
0adede6
to
ea384b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TypeScript extractor expects that all files are requested in a predetermined order. However, this conflicted with the recent change to exclude large files, where this filtering occurs only at a later stage.
This is the second time this out-of-order check has caused extraction failures due to an otherwise benign change in the Java part of the extractor. I'd like to remove the hard failure and instead regard the queue as speculative optimization that misses in rare cases.