Page MenuHomePhabricator

Bug 1896390 - Add getter for Iterator.constructor to eager-ecma-allowlist.js; r=nchevobbe!
ClosedPublic

Authored by dminor on Jul 30 2024, 8:07 PM.

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Lint Not Applicable
Unit
Tests Not Applicable
Build Status
Buildable 690738
Build 790107: arc lint + arc unit

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.

I'm fairly certain that the getter for Iterator.constructor is side-effect free (https://tc39.es/proposal-iterator-helpers/#sec-get-iteratorprototype-constructor) but perhaps I'm missing something.

Code analysis found 1 defect in diff 897053:

  • 1 defect found by eslint (Mozlint)
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 897053.

Looks good! Thank you!

nchevobbe added a project: testing-approved.

Sounds good to me to, thanks Daniel

This revision is now accepted and ready to land.Jul 31 2024, 5:11 AM

1 defect closed compared to the previous diff 897053.


If you see a problem in this automated review, please report it here.