Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dataset & other shared IDL attributes from SVGElement to HTMLOrSVGElement #60

Closed
jarek-foksa opened this issue Mar 4, 2016 · 8 comments

Comments

@jarek-foksa
Copy link

The current draft of the SVG spec defines dataset attribute on the SVGElement interface while HTML 5 spec defines it on the HTMLElement interface.

Is there any particular reason why dataset couldn't be defined just once on the Element interface like other similar attributes such as classList?

@AmeliaBR
Copy link
Contributor

I don't think dataset can be generalized to all XML languages (because of the expectations it creates re valid attributes), so putting it on Element is unlikely to happen.

However, it may be preferable to define it within the DOM specs as a "mixin" interface that can then be implemented by both HTMLElement and SVGElement. That would ensure that we had one, canonical definition that would always be updated consistently.

Anyone want to take responsibility for looking into this possibility with HTML WG and WHATWG?

@dstorey
Copy link
Member

dstorey commented Mar 7, 2018

There is now a PR for this and blur/focus/tabindex in HTML whatwg/html#3543

@dstorey dstorey self-assigned this Mar 23, 2018
@dstorey
Copy link
Member

dstorey commented Mar 23, 2018

To be clear, we're moving this to a mixin in HTML (tests pending) that will still be included on SVGElement, rather than moving it to Element.

annevk added a commit to whatwg/html that referenced this issue Mar 23, 2018
This exposes dataset, tabIndex, focus(), and blur() on SVG elements.

It also does away with NoncedElement.

Tests: web-platform-tests/wpt#10110 and web-platform-tests/wpt#10149 (dataset tests for SVG already exist).

Fixes #3471 and fixes w3c/svgwg#60.
@annevk
Copy link
Member

annevk commented Mar 23, 2018

In the above referenced commit I said that it fixed this issue, but I guess what still remains is that you need to remove dataset from SVGElement's IDL.

@AmeliaBR
Copy link
Contributor

Yep, marking this as "needs edits" and updating the title to match the chosen solution.

@AmeliaBR AmeliaBR changed the title Move dataset IDL attribute from SVGElement to Element Move dataset & other shared IDL attributes from SVGElement to HTMLOrSVGElement Mar 23, 2018
@AmeliaBR
Copy link
Contributor

This brings up again the issue of whether SVG wants to link normatively to WHATWG interfaces; we currently reference W3C versions. With the new WHATWG royalty commitments, it's probably less of an issue, but still a little messy & political to make the change.

I'll file an issue on W3C/html to ask if they can mirror the change, but not sure how long that might take.

@domenic
Copy link

domenic commented Mar 24, 2018

We would appreciate it if in working collaboratively with us, you did not then turn around and request that another group copy our work so that you can proceed to ignore our work in your spec :(.

@css-meeting-bot
Copy link
Member

The Working Group just discussed (Revisiting) Move dataset & other shared IDL attributes from SVGElement to HTMLOrSVGElement.

The full IRC log of that discussion <BogdanBrinza> topic: (Revisiting) Move dataset & other shared IDL attributes from SVGElement to HTMLOrSVGElement
<BogdanBrinza> GitHub: https://github.com//issues/60
<BogdanBrinza> dstorey: SVG 2.0 current draft already links to the Fetch specification so we won't make things worse in PR if we add another one
<BogdanBrinza> Resolution: Link to WHATWG spec now to resolve github.com//issues/60, while Liam is confirming this with W3C

yutakahirano pushed a commit to yutakahirano/html that referenced this issue Apr 26, 2018
This exposes dataset, tabIndex, focus(), and blur() on SVG elements.

It also does away with NoncedElement.

Tests: web-platform-tests/wpt#10110 and web-platform-tests/wpt#10149 (dataset tests for SVG already exist).

Fixes whatwg#3471 and fixes w3c/svgwg#60.
alice pushed a commit to alice/html that referenced this issue Jan 8, 2019
This exposes dataset, tabIndex, focus(), and blur() on SVG elements.

It also does away with NoncedElement.

Tests: web-platform-tests/wpt#10110 and web-platform-tests/wpt#10149 (dataset tests for SVG already exist).

Fixes whatwg#3471 and fixes w3c/svgwg#60.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants