resolves bug on days when DST is added. #2009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vsn4ik Looks good to me, what do you think? |
|
Can't reproduce issue. I can not find a city with AEDT. |
|
@vsn4ik are you on Mac? Try Point Cook, Australia. It is AEST and on October 2nd, it switches to AEDT.
|
vsn4ik
reviewed
Sep 18, 2016
| @@ -528,7 +528,20 @@ | |||
| }, | |||
|
|
|||
| _utc_to_local: function(utc){ | |||
| return utc && new Date(utc.getTime() + (utc.getTimezoneOffset()*60000)); | |||
|
|
|||
| return utc && new Date(utc.getTime() + (utc.getTimezoneOffset()*60000)); | ||
|
|
||
| if (!utc) | ||
| { |
| var local = new Date(utc.getTime() + (utc.getTimezoneOffset() * 60000)); | ||
|
|
||
| if (local.getTimezoneOffset() !== utc.getTimezoneOffset()) | ||
| { |
| local = new Date(utc.getTime() + (local.getTimezoneOffset() * 60000)); | ||
| } | ||
|
|
||
| return utc && local; |
|
@vsn4ik I'm not sure I understand what you mean by
Are you saying you accept the pull request with the suggested changes? Do you want me to submit the changes? |
|
@kylethielk LGTM! It is necessary to correct the remarks. |
|
@kylethielk can you fix the comments from @vsn4ik. After those fixes the PR is ready! |
|
Thanks @kylethielk! |
Closed
cpsievert
added a commit
to rstudio/shiny
that referenced
this pull request
Aug 19, 2020
…e for bootstraplib theming Note also that the 000 patch is no longer relevant as 1.9.0 includes the same fix uxsolutions/bootstrap-datepicker#2009
cpsievert
added a commit
to rstudio/shiny
that referenced
this pull request
Aug 26, 2020
…e for bootstraplib theming Note also that the 000 patch is no longer relevant as 1.9.0 includes the same fix uxsolutions/bootstrap-datepicker#2009
cpsievert
added a commit
to rstudio/shiny
that referenced
this pull request
Sep 9, 2020
* upgrade bootstrap-datepicker from 1.6.4 to 1.9.0; setup infrastructure for bootstraplib theming Note also that the 000 patch is no longer relevant as 1.9.0 includes the same fix uxsolutions/bootstrap-datepicker#2009 * Patch sass code for BS4 support and more general color contrasting * Wrap sass compilation into reusable function * remove check warning * Have bootstrapPage() use bootstraplib * yarn build * Use new output_template() * Deprecate bootstrapLib() in favor of bootstraplib::bootstrap() * Require bootstraplib 0.1.0.9001 * Sync up DESCRIPTION * document * rollback changes to pkgdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On days when DST is added this results in getDate call returning the incorrect day.
As an example on October 2, 2016 many parts of Australia move from AEST to AEDT. Clicking on October 2, 2016 and then triggering datepicker('getDate') results in October 1, 2016 being returned.
Here is a JSFiddle demonstrating the issue (with instructions): https://jsfiddle.net/kylethielk/x6eafu3g/
Here is a JSFiddle with my proposed changes that resolve the issue:
https://jsfiddle.net/kylethielk/aea7jobw/2/
Let me know if you have any questions.