-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove jcenter repository #836
Remove jcenter repository #836
Conversation
Codecov Report
@@ Coverage Diff @@
## main #836 +/- ##
==========================================
Coverage 75.67% 75.67%
+ Complexity 316 8 -308
==========================================
Files 54 54
Lines 2689 2689
Branches 428 428
==========================================
Hits 2035 2035
Misses 329 329
Partials 325 325
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good! Thanks for taking the time to perform the migration. I think it's about time we upgraded ExoPlayer despite its gapless issue on a few devices.
Although, it needs a change so that the build can proceed.
@@ -115,11 +115,11 @@ dependencies { | |||
implementation 'androidx.recyclerview:recyclerview:1.2.1' | |||
implementation 'com.github.AppIntro:AppIntro:6.1.0' | |||
implementation 'io.github.medyo:android-about-page:2.0.0' | |||
implementation 'com.google.android.exoplayer:exoplayer-core:2.11.8' | |||
implementation 'com.google.android:flexbox:2.0.1' | |||
implementation 'com.google.android.exoplayer:exoplayer-core:2.13.3' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes
Remove the now deprecated jcenter from the project and migrate / update all dependencies which are only available on jcenter.
Testing
Dependencies that have been updated / changed:
ExoPlayer
Update to
v2.13.3
. It is available on Google maven starting with release 2.13.3.Source: https://mvnrepository.com/artifact/com.google.android.exoplayer/exoplayer
Flexbox
Updated to
v3.0.0
. Has been moved to google maven starting with version 3.0.0. Group ID was changed fromcom.google.android to
com.google.android.flexbox`Source: https://github.com/google/flexbox-layout/releases/tag/3.0.0
Flextools
Updated to
v1.0.3
. Group ID has been changed fromcom.hopenlib.library
toio.github.mrherintsoahasina
furing migration to mavenCentral:Compare v1.0.1 with v1.0.3.
Source: https://github.com/mrHerintsoaHasina/flextools/releases/tag/v1.0.3
Falcon
Edit: Falcon has been updated in screengrab v2.1.1
Transitive dependencie to
screengrab v2.1.0
(latest version). Has been moved to mavenCentral starting with v2.2.0.Source: https://github.com/jraska/Falcon/releases/tag/2.2.0
This transitive dependency has been manually overriden since no new release of screengrab is available, yet. The constraint can be removed once a new version of screengrab is released.
I created an issue for this on the fastlane repository.