subscriber: don't gate with_ansi() on the "ansi" feature
#3020
+0
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Github actions aren't starting. I'm guessing that's because this PR is more than 30 days old. I'll try a no-op push to the branch to see if it gets things moving. |
auto-merge was automatically disabled
July 31, 2024 00:52
Head branch was pushed to by a user without write access
eric-seppanen
force-pushed
the
fix_ansi_cfg
branch
from
be13955
to
8544143
Compare
|
Ah, now it's stopped by "This workflow requires approval from a maintainer." @hawkw can you help? Also, auto-merge was disabled because I pushed to the branch. (No changes were made.) |
|
Ping? @hawkw you approved this PR but CI won't run until a maintainer intervenes. |
|
My bad! Running the workflow now. |
|
Clippy lint warnings appear to be unrelated; CI runs latest stable and at least some of the lints are things I recognize as being new in 1.80. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit 1cb523b removed this cfg gate on master. However, when the change was backported in 049ad73 the docs were updated but the
cfgchange was omitted. Some more detail and links are in issue #2996.This made the docs misleading, since they say "This method itself is still available without the feature flag."
Fixes #2996.