Add EnvFilter::from_directives
#2763
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! I’m happy to see a PR to make such an API public. For what it’s worth, I was looking for it, but ended up parsing strings instead. |
hawkw
approved these changes
Oct 19, 2023
|
Are there any blockers to getting this merged besides the branch being out-of-date? Just bumped into this, I can make an updated the PR if the sentiment hasn't changed and @Plebshot doesn't mind |
|
No blockers, it only awaits review as far as I know. I just synced the fork to be up to date though. Thanks for the reminder. |
Erigara
reviewed
Jul 12, 2024
| /// # Ok(()) } | ||
| /// ``` | ||
| pub fn from_directives(dirs: impl IntoIterator<Item = Directive>) -> Self { | ||
| Self::builder().from_directives(dirs) |
There was a problem hiding this comment.
Should Builder::from_directives be part of public API as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I was using an
EnvFilterwithin atracing_subscriber::reloadlayer, to be able to change the filter at runtime via a config file.Here, I let the deserialization take care of validating the correctness of the configured filter directives.
However, there wasn't a straightforward way to construct the
EnvFiltervia already parsed directives.Solution
There is a private
from_directivesmethod on theBuilder, which was already considered by @hawkw to be made public.Instead, I opted to creating a new, similar method directly on the
EnvFilter.This should be easier to discover and more convenient than having to call
EnvFilter::builder().from_directives().Though, we could consider making both variants public.
This is my first contribution to tokio, so let me know if something is missing from the PR!