Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fileinput with inplace=True ignores errors parameter #93157

Closed
JelleZijlstra opened this issue May 24, 2022 · 0 comments · Fixed by #95128
Closed

fileinput with inplace=True ignores errors parameter #93157

JelleZijlstra opened this issue May 24, 2022 · 0 comments · Fixed by #95128
Labels
3.10 only security fixes 3.11 only security fixes 3.12 bugs and security fixes type-bug An unexpected behavior, bug, or error

Comments

@JelleZijlstra
Copy link
Member

#25272 by @methane added encoding and errors parameters to fileinput.FileInput, but ignored them in the case where inplace=True is passed. Later #25648 added use of encoding in this branch, but not errors. I don't see why errors shouldn't also be used in that branch, but maybe I'm missing something.
@JelleZijlstra JelleZijlstra added type-bug An unexpected behavior, bug, or error 3.11 only security fixes 3.10 only security fixes 3.12 bugs and security fixes labels May 24, 2022
@JelleZijlstra JelleZijlstra mentioned this issue May 24, 2022
Merged
JelleZijlstra added a commit to JelleZijlstra/typeshed that referenced this issue May 24, 2022
@JelleZijlstra
fileinput: Fix TypeVar usage
860cd4a 
Fixes python#7922, part of python#7928.

Also discovered an apparent CPython bug in the process: python/cpython#93157
@bedevere-bot bedevere-bot mentioned this issue Jul 22, 2022
Merged
@methane methane linked a pull request Jul 22, 2022 that will close this issue
gh-93157: Fix fileinput didn't support errors in inplace mode #95128
Merged
This was referenced Jul 24, 2022
Merged
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 24, 2022
@methane @miss-islington
pythongh-93157: Fix fileinput didn't support errors in inplace mo…
a3dbeef 
…de (pythonGH-95128)

(cherry picked from commit 5c7f3bc)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 24, 2022
@methane @miss-islington
pythongh-93157: Fix fileinput didn't support errors in inplace mo…
c4ebeea 
…de (pythonGH-95128)

(cherry picked from commit 5c7f3bc)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
methane added a commit that referenced this issue Jul 24, 2022
@methane
gh-93157: Fix fileinput didn't support errors in inplace mode (GH…
5c7f3bc 
…-95128)
miss-islington added a commit that referenced this issue Jul 24, 2022
@miss-islington @methane
gh-93157: Fix fileinput didn't support errors in inplace mode (GH…
4a682b4 
…-95128)

(cherry picked from commit 5c7f3bc)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
miss-islington added a commit that referenced this issue Jul 24, 2022
@miss-islington @methane
gh-93157: Fix fileinput didn't support errors in inplace mode (GH…
22f06d6 
…-95128)

(cherry picked from commit 5c7f3bc)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.10 only security fixes 3.11 only security fixes 3.12 bugs and security fixes type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-93157: Fix fileinput didn't support errors in inplace mode methane/cpython
1 participant
@JelleZijlstra