lib/libzfs, rpm: Install pkgconfig files in the correct directory #10628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libzfs is an architecture-specific library, thus its pkgconfig files should also be installed into the architecture-specific path for pkgconfig files so that systems that support multilib or multiarch installation will be able to work properly. Signed-off-by: Neal Gompa <ngompa@datto.com>
|
@behlendorf @tonyhutter This change mimics one that has already been done to |
@Conan-Kudo would you mind rebasing this against the new openzfs/zfs-0.8.5-staging branch. We're going to start collecting and testing the backports for the 0.8.5 tag on this branch. |
|
@behlendorf Done. |
tonyhutter
approved these changes
Aug 19, 2020
behlendorf
approved these changes
Aug 20, 2020
|
@Conan-Kudo thanks! |
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Sep 15, 2020
…enzfs#10628) libzfs is an architecture-specific library, thus its pkgconfig files should also be installed into the architecture-specific path for pkgconfig files so that systems that support multilib or multiarch installation will be able to work properly. Signed-off-by: Neal Gompa <ngompa@datto.com> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Sep 15, 2020
…enzfs#10628) libzfs is an architecture-specific library, thus its pkgconfig files should also be installed into the architecture-specific path for pkgconfig files so that systems that support multilib or multiarch installation will be able to work properly. Signed-off-by: Neal Gompa <ngompa@datto.com> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
libzfsis an architecture-specific library, thus its pkgconfig files should also be installed into the architecture-specific path for pkgconfig files so that systems that support multilib or multiarch installation will be able to work properly.Description
%{_datarootdir}/pkgconfigto%{_libdir}/pkgconfigHow Has This Been Tested?
Did local package builds for CentOS 8, Fedora 32, Ubuntu 16.04, and Ubuntu 20.04 with success. The
pkg-configtool still is able to look up the pkgconfig content installed by thelibzfs2-develpackage.Types of changes
Checklist:
Signed-off-by.