Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: create invalidation array once for WebGL MSAA #27505

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

aardgoose
Copy link
Contributor

Avoid creating a new array for each frame when using MSAA.

also add support for depth + stencil depth textures for renderTargets.

@sunag sunag added this to the r161 milestone Jan 4, 2024
@sunag sunag merged commit 2ab27ea into mrdoob:dev Jan 4, 2024
11 checks passed
@RenaudRohlinger
Copy link
Collaborator

Interesting, we actually create the invalidation array each frame in WebGLTextures. I guess we could bring that same optimization. /cc @Mugen87

@Mugen87
Copy link
Collaborator

Mugen87 commented Jan 5, 2024

If that's possible, that would be great!

@aardgoose aardgoose deleted the cache-invalidate-array branch January 12, 2024 14:13
AdaRoseCannon pushed a commit to AdaRoseCannon/three.js that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants