Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Improve LineDashedMaterial page. #27276

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Docs: Improve LineDashedMaterial page. #27276

merged 1 commit into from
Nov 29, 2023

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Nov 29, 2023

Related issue: #27255

Description

Adds a note to the LineDashedMaterial page that Line.computeLineDistances() has to be used with this material type.

@Mugen87 Mugen87 added this to the r159 milestone Nov 29, 2023
@Mugen87 Mugen87 merged commit 2f7a342 into mrdoob:dev Nov 29, 2023
1 check was pending
@@ -12,7 +12,8 @@
<h1>[name]</h1>

<p class="desc">
A material for drawing wireframe-style geometries with dashed lines.
A material for drawing wireframe-style geometries with dashed lines.<br />
Note: Make sure to call [page:Line.computeLineDistances]() when using [name].
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An argument can be made that "Be sure to call" is more appropriate here. But I think a better way to say it is:

Note: You must call page:Line.computeLineDistances when using [name].

AdaRoseCannon pushed a commit to AdaRoseCannon/three.js that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants