Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes Support For TransformChatHistory and CompressibleAgent #3313

Merged
merged 6 commits into from
Aug 13, 2024

Conversation

WaelKarkoub
Copy link
Contributor

@WaelKarkoub WaelKarkoub commented Aug 7, 2024

Why are these changes needed?

Doing some cleanup, removing TransformChatHistory and CompressibleAgent in favor of TransformMessages.

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.98%. Comparing base (6279247) to head (246015e).
Report is 80 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3313       +/-   ##
===========================================
- Coverage   32.90%   21.98%   -10.92%     
===========================================
  Files          94       95        +1     
  Lines       10235    10637      +402     
  Branches     2193     2442      +249     
===========================================
- Hits         3368     2339     -1029     
- Misses       6580     8128     +1548     
+ Partials      287      170      -117     
Flag Coverage Δ
unittests 21.94% <ø> (-10.97%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marklysze
Copy link
Collaborator

Thanks @WaelKarkoub, should we remove this section from the FAQ?

Rest looks good to me :)

@thinkall thinkall added this pull request to the merge queue Aug 13, 2024
Merged via the queue into main with commit 6682b6d Aug 13, 2024
134 of 146 checks passed
@thinkall thinkall deleted the wael/delete-old-compression branch August 13, 2024 03:35
victordibia pushed a commit that referenced this pull request Aug 28, 2024
…3313)

* remove old files

* removes ci

* removes faq

---------

Co-authored-by: Li Jiang <bnujli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants