Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing req. arg for new datasets package #1334

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

Borda
Copy link
Collaborator

@Borda Borda commented Aug 11, 2024

Why are these changes needed?

seems recent CI is not passing at all due to changes in the datasets package which now for loading requires specifying trust_remote_code=True|False

Related issue number

actual state on the main branch
cc: @thinkall
see: EleutherAI/lm-evaluation-harness#1135

Checks

Copy link
Collaborator

@thinkall thinkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Borda !

@thinkall thinkall added this pull request to the merge queue Aug 12, 2024
Merged via the queue into microsoft:main with commit cd0e88e Aug 12, 2024
16 of 19 checks passed
@Borda Borda deleted the fix/datasets branch August 12, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants