fix: whitelist match failure due to case ignoring #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leizongmin
reviewed
Apr 6, 2022
| function keysToLowerCase(obj) { | ||
| var ret = {}; | ||
| for (var i in obj) { | ||
| if (Array.isArray(obj[i])) { |
There was a problem hiding this comment.
考虑到整体代码风格的统一，这里不要用箭头函数。可改为：
ret[i.toLowerCase()] = obj[i].map(function (item) {
return item.toLowerCase();
});
leizongmin
reviewed
Apr 17, 2022
test/test_xss.js
Outdated
| @@ -15,8 +15,8 @@ function xss(html, options) { | |||
| return ret; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
test_xss.js 这个文件也是类似的问题，跟本次要修复的问题无关的地方不要做修改（比如这里将 function() 改为 function ()），其次不要用箭头函数
leizongmin
reviewed
Apr 17, 2022
test/test_xss.js
Outdated
| @@ -367,17 +367,17 @@ describe("test XSS", function() { | |||
| assert.equal( | |||
| xss( | |||
| "<!--[if gte IE 4]><SCRI" + | |||
| "PT>alert('XSS');</SCRI" + | |||
| "PT><![endif]--> END", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #173