cmd/protoc-gen-go-grpc: default use_generic_streams_experimental to true #7387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvindbr8
added
the
Type: Behavior Change
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7387 +/- ##
==========================================
+ Coverage 81.30% 81.46% +0.16%
==========================================
Files 348 348
Lines 26744 26744
==========================================
+ Hits 21744 21788 +44
+ Misses 3800 3771 -29
+ Partials 1200 1185 -15 |
dfawley
approved these changes
Jul 3, 2024
printchard
pushed a commit
to printchard/grpc-go
that referenced
this pull request
Jul 11, 2024
printchard
pushed a commit
to printchard/grpc-go
that referenced
this pull request
Jul 30, 2024
printchard
pushed a commit
to printchard/grpc-go
that referenced
this pull request
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relnotes for cmd/protoc-gen-go-grpc:
BidiStreamingServerorClientStreamingClient) instead of producing complete interfaces and implementations for the streaming methods. This can be disabled by settinguse_generic_streams_experimental=false. Please file a bug if you encounter any issues with this behavior. This will become the default behavior in an upcoming release.RELEASE NOTES: NONE