Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dialogflow-cx] datastore summary prompt missing #12853

Closed
1 task done
iuiu34 opened this issue Jul 1, 2024 · 3 comments
Closed
1 task done

[dialogflow-cx] datastore summary prompt missing #12853

iuiu34 opened this issue Jul 1, 2024 · 3 comments
Assignees
Labels
status: investigating The issue is under investigation, which is determined to be non-trivial. type: question Request for information or clarification. Not an issue.

Comments

@iuiu34
Copy link

iuiu34 commented Jul 1, 2024

Determine this is the right repository

  • I determined this is the correct repository in which to report this bug.

Summary of the issue

in packages/google-cloud-dialogflow-cx, the option to "Customize summarization prompt" seems missing in the api.
But rest of option in Generative Ai, no: agent name, business, etc. are there.

I'm using

  • google.cloud.dialogflow.cx.v3beta1.Agents.UpdateGenerativeSettings
  • google.cloud.dialogflowcx_v3beta1.types.GenerativeSettings
    image

API client name and version

google-cloud-dialogflow-cx-1.34.0

Reproduction steps: code

def data_store_system_push(model='gemini-1.5-flash'):
    print('data_store_system_push')
    client_options = get_client_options()
    client = AgentsClient(client_options=client_options)
    agent_path = get_agent_path()
    generative_settings_path = f"{agent_path}/generativeSettings"
    generative_settings = GenerativeSettings(name=generative_settings_path,
                                             language_code='en')
    generative_settings.llm_model_settings.model = model
    generative_settings.llm_model_settings.prompt_text = 'test'
    generative_settings.knowledge_connector_settings.business = "business_name"

    request = UpdateGenerativeSettingsRequest(generative_settings=generative_settings)
    client.update_generative_settings(request=request)

Reproduction steps: supporting files

No response

Reproduction steps: actual results

No response

Reproduction steps: expected results

No response

OS & version + platform

No response

Python environment

py 3.9

Python dependencies

google-cloud-dialogflow-cx 1.34.0

@iuiu34 iuiu34 added triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jul 1, 2024
@iuiu34
Copy link
Author

iuiu34 commented Jul 1, 2024

could be related with that in generative_settings.py
the LlmModelSettings is not a subclass of GenerativeSettings?
And that is passed as string to llm_model_settings?

@parthea parthea self-assigned this Jul 2, 2024
@parthea parthea added the status: investigating The issue is under investigation, which is determined to be non-trivial. label Jul 2, 2024
@parthea
Copy link
Contributor

parthea commented Jul 8, 2024

@yil532, Please see the screenshot in #12853 (comment), specifically the field where it says this is missing. Please can you clarify which field this corresponds to in the Dialogflow CX API, and whether the field exists on this page?

@parthea parthea added type: question Request for information or clarification. Not an issue. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. triage me I really want to be triaged. labels Jul 8, 2024
@parthea
Copy link
Contributor

parthea commented Aug 26, 2024

I'm going to close this issue due to inactivity but please feel free to open a new issue with more information.

@parthea parthea closed this as completed Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: investigating The issue is under investigation, which is determined to be non-trivial. type: question Request for information or clarification. Not an issue.
Projects
None yet
Development

No branches or pull requests

2 participants