Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPDATE_KOTLIN_VERSION: 1.9.20-dev-4459 #1420

Merged
merged 2 commits into from
Jun 24, 2023
Merged

Conversation

ting-yuan
Copy link
Collaborator

No description provided.

which is incorrectly registered with

  JvmStubBasedDeserializedSymbolProviderFactory

in

  FirStandaloneServiceRegistrar

Unfortunately, the workaround requires accessing LLAPI.
@ting-yuan ting-yuan requested a review from neetopia June 24, 2023 00:09
@ting-yuan ting-yuan changed the title UPDATE_KOTLIN_VERSION: 1.9.20-dev-3234 UPDATE_KOTLIN_VERSION: 1.9.20-dev-4459 Jun 24, 2023
}.apply {
(project as MockProject).registerService(
JvmFirDeserializedSymbolProviderFactory::class.java,
JvmFirDeserializedSymbolProviderFactory::class.java
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any insight on this magic?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FirStandaloneServiceRegistrar registers JvmStubBasedDeserializedSymbolProviderFactory, which is IDE only. Standalone mode should go with JvmFirDeserializedSymbolProviderFactory per this comment.

@ting-yuan ting-yuan merged commit 448af70 into google:main Jun 24, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants